commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t.@apache.org
Subject svn commit: r1439967 - in /commons/proper/cli/trunk/src: conf/checkstyle-suppressions.xml conf/checkstyle.xml main/java/org/apache/commons/cli/OptionValidator.java main/java/org/apache/commons/cli/Util.java
Date Tue, 29 Jan 2013 16:08:59 GMT
Author: tn
Date: Tue Jan 29 16:08:59 2013
New Revision: 1439967

URL: http://svn.apache.org/viewvc?rev=1439967&view=rev
Log:
Fix checkstyle warnings, add suppressions for not possible changes due to bc.

Modified:
    commons/proper/cli/trunk/src/conf/checkstyle-suppressions.xml
    commons/proper/cli/trunk/src/conf/checkstyle.xml
    commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionValidator.java
    commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Util.java

Modified: commons/proper/cli/trunk/src/conf/checkstyle-suppressions.xml
URL: http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/conf/checkstyle-suppressions.xml?rev=1439967&r1=1439966&r2=1439967&view=diff
==============================================================================
--- commons/proper/cli/trunk/src/conf/checkstyle-suppressions.xml (original)
+++ commons/proper/cli/trunk/src/conf/checkstyle-suppressions.xml Tue Jan 29 16:08:59 2013
@@ -4,7 +4,11 @@
 <suppressions>
 
   <!-- Suppress visibility check of some member fields as they have to be kept
-       for backwards compatibility reasons                                      -->
+       for binary compatibility reasons                                         -->
   <suppress checks="VisibilityModifier" files="HelpFormatter.java" />
 
+  <!-- Cannot hide public constructor due to binary compatibility reasons       -->
+  <suppress checks="HideUtilityClassConstructor" files="PatternOptionBuilder.java" />
+  <suppress checks="HideUtilityClassConstructor" files="TypeHandler.java" />
+
 </suppressions>

Modified: commons/proper/cli/trunk/src/conf/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/conf/checkstyle.xml?rev=1439967&r1=1439966&r2=1439967&view=diff
==============================================================================
--- commons/proper/cli/trunk/src/conf/checkstyle.xml (original)
+++ commons/proper/cli/trunk/src/conf/checkstyle.xml Tue Jan 29 16:08:59 2013
@@ -98,7 +98,7 @@ limitations under the License.
         </module>
         <module name="MethodLength"/>
         <module name="ParameterNumber">
-            <property name="max" value="8"/>
+            <property name="max" value="9"/>
         </module>
 
 

Modified: commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionValidator.java
URL: http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionValidator.java?rev=1439967&r1=1439966&r2=1439967&view=diff
==============================================================================
--- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionValidator.java (original)
+++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/OptionValidator.java Tue
Jan 29 16:08:59 2013
@@ -24,7 +24,7 @@ package org.apache.commons.cli;
  * @version $Revision$, $Date$
  * @since 1.1
  */
-class OptionValidator
+final class OptionValidator
 {
     /**
      * Hide constructor for a utility class.

Modified: commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Util.java
URL: http://svn.apache.org/viewvc/commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Util.java?rev=1439967&r1=1439966&r2=1439967&view=diff
==============================================================================
--- commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Util.java (original)
+++ commons/proper/cli/trunk/src/main/java/org/apache/commons/cli/Util.java Tue Jan 29 16:08:59
2013
@@ -23,7 +23,7 @@ package org.apache.commons.cli;
  * @author John Keyes (john at integralsource.com)
  * @version $Revision$, $Date$
  */
-class Util
+final class Util
 {
     /**
      * Hide constructor for a utility class.



Mime
View raw message