commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1437527 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
Date Wed, 23 Jan 2013 16:05:47 GMT
Author: sebb
Date: Wed Jan 23 16:05:46 2013
New Revision: 1437527

URL: http://svn.apache.org/viewvc?rev=1437527&view=rev
Log:
Add Javadoc and deprecate currently useless methods

Modified:
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java?rev=1437527&r1=1437526&r2=1437527&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
(original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
Wed Jan 23 16:05:46 2013
@@ -28,7 +28,7 @@ import org.apache.commons.compress.archi
 
 /**
  *
- * @NotThreadSafe
+ * @NotThreadSafe (parent is not thread-safe)
  */
 public class JarArchiveEntry extends ZipArchiveEntry {
 
@@ -53,12 +53,28 @@ public class JarArchiveEntry extends Zip
 
     }
 
+    /**
+     * This method is not implemented and won't ever be.
+     * The JVM equivalent has a different name {@link java.util.jar.JarEntry#getAttributes()}
+     *
+     * @deprecated Do not use; always returns null
+     * @return Always returns null.
+     */
+    @Deprecated
     public Attributes getManifestAttributes() {
         return manifestAttributes;
     }
 
+    /**
+     * Return a copy of the list of certificates or null if there are none.
+     *
+     * @return Always returns null in the current implementation
+     *
+     * @deprecated Not currently implemented
+     */
+    @Deprecated
     public Certificate[] getCertificates() {
-        if (certificates != null) {
+        if (certificates != null) { // never true currently
             Certificate[] certs = new Certificate[certificates.length];
             System.arraycopy(certificates, 0, certs, 0, certs.length);
             return certs;



Mime
View raw message