commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t.@apache.org
Subject svn commit: r1436903 - in /commons/proper/collections/trunk: checkstyle-suppressions.xml checkstyle.xml findbugs-exclude-filter.xml
Date Tue, 22 Jan 2013 13:26:00 GMT
Author: tn
Date: Tue Jan 22 13:26:00 2013
New Revision: 1436903

URL: http://svn.apache.org/viewvc?rev=1436903&view=rev
Log:
Add more suppressions rules to checkstyle and findbugs.

Modified:
    commons/proper/collections/trunk/checkstyle-suppressions.xml
    commons/proper/collections/trunk/checkstyle.xml
    commons/proper/collections/trunk/findbugs-exclude-filter.xml

Modified: commons/proper/collections/trunk/checkstyle-suppressions.xml
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/checkstyle-suppressions.xml?rev=1436903&r1=1436902&r2=1436903&view=diff
==============================================================================
--- commons/proper/collections/trunk/checkstyle-suppressions.xml (original)
+++ commons/proper/collections/trunk/checkstyle-suppressions.xml Tue Jan 22 13:26:00 2013
@@ -5,5 +5,11 @@
   <!-- Suppress switch fallthrough / default case for class Flat3Map -->
   <suppress checks="FallThrough" files="Flat3Map.java" />
   <suppress checks="MissingSwitchDefault" files="Flat3Map.java" />
+
+  <!-- Ignore missing javadoc for Get/Put interfaces, they refer to java.util.Map -->
+  <suppress checks="JavadocMethod" files="Get.java" />
+  <suppress checks="JavadocMethod" files="Put.java" />
   
+  <!-- Ignore missing javadoc param for unsupported method -->
+  <suppress checks="JavadocMethod" files="FilterListIterator.java" lines="116,166" />
 </suppressions>

Modified: commons/proper/collections/trunk/checkstyle.xml
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/checkstyle.xml?rev=1436903&r1=1436902&r2=1436903&view=diff
==============================================================================
--- commons/proper/collections/trunk/checkstyle.xml (original)
+++ commons/proper/collections/trunk/checkstyle.xml Tue Jan 22 13:26:00 2013
@@ -19,6 +19,10 @@
 	<property name="localeLanguage" value="en" />
 	<property name="severity" value="warning" />
 
+	<module name="SuppressionFilter">
+	    <property name="file" value="${checkstyle.suppressions.file}"/>
+	</module>
+
 	<module name="JavadocPackage">
 		<property name="allowLegacy" value="true" />
 	</module>

Modified: commons/proper/collections/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/findbugs-exclude-filter.xml?rev=1436903&r1=1436902&r2=1436903&view=diff
==============================================================================
--- commons/proper/collections/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/collections/trunk/findbugs-exclude-filter.xml Tue Jan 22 13:26:00 2013
@@ -30,10 +30,13 @@
     <Bug pattern="NP_BOOLEAN_RETURN_NULL" />
   </Match>
 
-  <!--  Flat3Map and its inner classes use intentional switch fall-through. The missing
-        default clause is safe and omitted for better readibility.                      
-->
+  <!--  Flat3Map and its inner classes use intentional switch fall-through. The missing
 -->
+  <!--  default clause is safe and omitted for better readability.                   
   -->
   <Match>
-	<Class name="~org.apache.commons.collections.map.Flat3Map.*" />
+    <Or>
+      <Class name="~.*\.Flat3Map$" />
+      <Class name="~.*\.Flat3Map\$\w+Iterator$" />
+    </Or>
     <Or>
 	  <Bug pattern="SF_SWITCH_FALLTHROUGH" />
 	  <Bug pattern="SF_SWITCH_NO_DEFAULT" />



Mime
View raw message