commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1436768 [6/13] - in /commons/proper/lang/trunk/src: main/java/org/apache/commons/lang3/ main/java/org/apache/commons/lang3/builder/ main/java/org/apache/commons/lang3/concurrent/ main/java/org/apache/commons/lang3/event/ main/java/org/apac...
Date Tue, 22 Jan 2013 07:07:46 GMT
Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Validate.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Validate.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Validate.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/Validate.java Tue Jan 22 07:07:42 2013
@@ -101,7 +101,7 @@ public class Validate {
      * @see #isTrue(boolean, String, double)
      * @see #isTrue(boolean, String, Object...)
      */
-    public static void isTrue(boolean expression, String message, long value) {
+    public static void isTrue(final boolean expression, final String message, final long value) {
         if (expression == false) {
             throw new IllegalArgumentException(String.format(message, Long.valueOf(value)));
         }
@@ -126,7 +126,7 @@ public class Validate {
      * @see #isTrue(boolean, String, long)
      * @see #isTrue(boolean, String, Object...)
      */
-    public static void isTrue(boolean expression, String message, double value) {
+    public static void isTrue(final boolean expression, final String message, final double value) {
         if (expression == false) {
             throw new IllegalArgumentException(String.format(message, Double.valueOf(value)));
         }
@@ -150,7 +150,7 @@ public class Validate {
      * @see #isTrue(boolean, String, long)
      * @see #isTrue(boolean, String, double)
      */
-    public static void isTrue(boolean expression, String message, Object... values) {
+    public static void isTrue(final boolean expression, final String message, final Object... values) {
         if (expression == false) {
             throw new IllegalArgumentException(String.format(message, values));
         }
@@ -175,7 +175,7 @@ public class Validate {
      * @see #isTrue(boolean, String, double)
      * @see #isTrue(boolean, String, Object...)
      */
-    public static void isTrue(boolean expression) {
+    public static void isTrue(final boolean expression) {
         if (expression == false) {
             throw new IllegalArgumentException(DEFAULT_IS_TRUE_EX_MESSAGE);
         }
@@ -199,7 +199,7 @@ public class Validate {
      * @throws NullPointerException if the object is {@code null}
      * @see #notNull(Object, String, Object...)
      */
-    public static <T> T notNull(T object) {
+    public static <T> T notNull(final T object) {
         return notNull(object, DEFAULT_IS_NULL_EX_MESSAGE);
     }
 
@@ -217,7 +217,7 @@ public class Validate {
      * @throws NullPointerException if the object is {@code null}
      * @see #notNull(Object)
      */
-    public static <T> T notNull(T object, String message, Object... values) {
+    public static <T> T notNull(final T object, final String message, final Object... values) {
         if (object == null) {
             throw new NullPointerException(String.format(message, values));
         }
@@ -243,7 +243,7 @@ public class Validate {
      * @throws IllegalArgumentException if the array is empty
      * @see #notEmpty(Object[])
      */
-    public static <T> T[] notEmpty(T[] array, String message, Object... values) {
+    public static <T> T[] notEmpty(final T[] array, final String message, final Object... values) {
         if (array == null) {
             throw new NullPointerException(String.format(message, values));
         }
@@ -269,7 +269,7 @@ public class Validate {
      * @throws IllegalArgumentException if the array is empty
      * @see #notEmpty(Object[], String, Object...)
      */
-    public static <T> T[] notEmpty(T[] array) {
+    public static <T> T[] notEmpty(final T[] array) {
         return notEmpty(array, DEFAULT_NOT_EMPTY_ARRAY_EX_MESSAGE);
     }
 
@@ -292,7 +292,7 @@ public class Validate {
      * @throws IllegalArgumentException if the collection is empty
      * @see #notEmpty(Object[])
      */
-    public static <T extends Collection<?>> T notEmpty(T collection, String message, Object... values) {
+    public static <T extends Collection<?>> T notEmpty(final T collection, final String message, final Object... values) {
         if (collection == null) {
             throw new NullPointerException(String.format(message, values));
         }
@@ -318,7 +318,7 @@ public class Validate {
      * @throws IllegalArgumentException if the collection is empty
      * @see #notEmpty(Collection, String, Object...)
      */
-    public static <T extends Collection<?>> T notEmpty(T collection) {
+    public static <T extends Collection<?>> T notEmpty(final T collection) {
         return notEmpty(collection, DEFAULT_NOT_EMPTY_COLLECTION_EX_MESSAGE);
     }
 
@@ -341,7 +341,7 @@ public class Validate {
      * @throws IllegalArgumentException if the map is empty
      * @see #notEmpty(Object[])
      */
-    public static <T extends Map<?, ?>> T notEmpty(T map, String message, Object... values) {
+    public static <T extends Map<?, ?>> T notEmpty(final T map, final String message, final Object... values) {
         if (map == null) {
             throw new NullPointerException(String.format(message, values));
         }
@@ -367,7 +367,7 @@ public class Validate {
      * @throws IllegalArgumentException if the map is empty
      * @see #notEmpty(Map, String, Object...)
      */
-    public static <T extends Map<?, ?>> T notEmpty(T map) {
+    public static <T extends Map<?, ?>> T notEmpty(final T map) {
         return notEmpty(map, DEFAULT_NOT_EMPTY_MAP_EX_MESSAGE);
     }
 
@@ -390,7 +390,7 @@ public class Validate {
      * @throws IllegalArgumentException if the character sequence is empty
      * @see #notEmpty(CharSequence)
      */
-    public static <T extends CharSequence> T notEmpty(T chars, String message, Object... values) {
+    public static <T extends CharSequence> T notEmpty(final T chars, final String message, final Object... values) {
         if (chars == null) {
             throw new NullPointerException(String.format(message, values));
         }
@@ -417,7 +417,7 @@ public class Validate {
      * @throws IllegalArgumentException if the character sequence is empty
      * @see #notEmpty(CharSequence, String, Object...)
      */
-    public static <T extends CharSequence> T notEmpty(T chars) {
+    public static <T extends CharSequence> T notEmpty(final T chars) {
         return notEmpty(chars, DEFAULT_NOT_EMPTY_CHAR_SEQUENCE_EX_MESSAGE);
     }
 
@@ -443,7 +443,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T extends CharSequence> T notBlank(T chars, String message, Object... values) {
+    public static <T extends CharSequence> T notBlank(final T chars, final String message, final Object... values) {
         if (chars == null) {
             throw new NullPointerException(String.format(message, values));
         }
@@ -472,7 +472,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T extends CharSequence> T notBlank(T chars) {
+    public static <T extends CharSequence> T notBlank(final T chars) {
         return notBlank(chars, DEFAULT_NOT_BLANK_EX_MESSAGE);
     }
 
@@ -502,7 +502,7 @@ public class Validate {
      * @throws IllegalArgumentException if an element is {@code null}
      * @see #noNullElements(Object[])
      */
-    public static <T> T[] noNullElements(T[] array, String message, Object... values) {
+    public static <T> T[] noNullElements(final T[] array, final String message, final Object... values) {
         Validate.notNull(array);
         for (int i = 0; i < array.length; i++) {
             if (array[i] == null) {
@@ -534,7 +534,7 @@ public class Validate {
      * @throws IllegalArgumentException if an element is {@code null}
      * @see #noNullElements(Object[], String, Object...)
      */
-    public static <T> T[] noNullElements(T[] array) {
+    public static <T> T[] noNullElements(final T[] array) {
         return noNullElements(array, DEFAULT_NO_NULL_ELEMENTS_ARRAY_EX_MESSAGE);
     }
 
@@ -564,7 +564,7 @@ public class Validate {
      * @throws IllegalArgumentException if an element is {@code null}
      * @see #noNullElements(Iterable)
      */
-    public static <T extends Iterable<?>> T noNullElements(T iterable, String message, Object... values) {
+    public static <T extends Iterable<?>> T noNullElements(final T iterable, final String message, final Object... values) {
         Validate.notNull(iterable);
         int i = 0;
         for (Iterator<?> it = iterable.iterator(); it.hasNext(); i++) {
@@ -597,7 +597,7 @@ public class Validate {
      * @throws IllegalArgumentException if an element is {@code null}
      * @see #noNullElements(Iterable, String, Object...)
      */
-    public static <T extends Iterable<?>> T noNullElements(T iterable) {
+    public static <T extends Iterable<?>> T noNullElements(final T iterable) {
         return noNullElements(iterable, DEFAULT_NO_NULL_ELEMENTS_COLLECTION_EX_MESSAGE);
     }
 
@@ -625,7 +625,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T> T[] validIndex(T[] array, int index, String message, Object... values) {
+    public static <T> T[] validIndex(final T[] array, final int index, final String message, final Object... values) {
         Validate.notNull(array);
         if (index < 0 || index >= array.length) {
             throw new IndexOutOfBoundsException(String.format(message, values));
@@ -656,7 +656,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T> T[] validIndex(T[] array, int index) {
+    public static <T> T[] validIndex(final T[] array, final int index) {
         return validIndex(array, index, DEFAULT_VALID_INDEX_ARRAY_EX_MESSAGE, Integer.valueOf(index));
     }
 
@@ -684,7 +684,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T extends Collection<?>> T validIndex(T collection, int index, String message, Object... values) {
+    public static <T extends Collection<?>> T validIndex(final T collection, final int index, final String message, final Object... values) {
         Validate.notNull(collection);
         if (index < 0 || index >= collection.size()) {
             throw new IndexOutOfBoundsException(String.format(message, values));
@@ -712,7 +712,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T extends Collection<?>> T validIndex(T collection, int index) {
+    public static <T extends Collection<?>> T validIndex(final T collection, final int index) {
         return validIndex(collection, index, DEFAULT_VALID_INDEX_COLLECTION_EX_MESSAGE, Integer.valueOf(index));
     }
 
@@ -741,7 +741,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T extends CharSequence> T validIndex(T chars, int index, String message, Object... values) {
+    public static <T extends CharSequence> T validIndex(final T chars, final int index, final String message, final Object... values) {
         Validate.notNull(chars);
         if (index < 0 || index >= chars.length()) {
             throw new IndexOutOfBoundsException(String.format(message, values));
@@ -773,7 +773,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T extends CharSequence> T validIndex(T chars, int index) {
+    public static <T extends CharSequence> T validIndex(final T chars, final int index) {
         return validIndex(chars, index, DEFAULT_VALID_INDEX_CHAR_SEQUENCE_EX_MESSAGE, Integer.valueOf(index));
     }
 
@@ -799,7 +799,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static void validState(boolean expression) {
+    public static void validState(final boolean expression) {
         if (expression == false) {
             throw new IllegalStateException(DEFAULT_VALID_STATE_EX_MESSAGE);
         }
@@ -821,7 +821,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static void validState(boolean expression, String message, Object... values) {
+    public static void validState(final boolean expression, final String message, final Object... values) {
         if (expression == false) {
             throw new IllegalStateException(String.format(message, values));
         }
@@ -845,7 +845,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static void matchesPattern(CharSequence input, String pattern) {
+    public static void matchesPattern(final CharSequence input, final String pattern) {
         // TODO when breaking BC, consider returning input
         if (Pattern.matches(pattern, input) == false) {
             throw new IllegalArgumentException(String.format(DEFAULT_MATCHES_PATTERN_EX, input, pattern));
@@ -869,7 +869,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static void matchesPattern(CharSequence input, String pattern, String message, Object... values) {
+    public static void matchesPattern(final CharSequence input, final String pattern, final String message, final Object... values) {
         // TODO when breaking BC, consider returning input
         if (Pattern.matches(pattern, input) == false) {
             throw new IllegalArgumentException(String.format(message, values));
@@ -894,7 +894,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T> void inclusiveBetween(T start, T end, Comparable<T> value) {
+    public static <T> void inclusiveBetween(final T start, final T end, final Comparable<T> value) {
         // TODO when breaking BC, consider returning value
         if (value.compareTo(start) < 0 || value.compareTo(end) > 0) {
             throw new IllegalArgumentException(String.format(DEFAULT_INCLUSIVE_BETWEEN_EX_MESSAGE, value, start, end));
@@ -919,7 +919,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T> void inclusiveBetween(T start, T end, Comparable<T> value, String message, Object... values) {
+    public static <T> void inclusiveBetween(final T start, final T end, final Comparable<T> value, final String message, final Object... values) {
         // TODO when breaking BC, consider returning value
         if (value.compareTo(start) < 0 || value.compareTo(end) > 0) {
             throw new IllegalArgumentException(String.format(message, values));
@@ -944,7 +944,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T> void exclusiveBetween(T start, T end, Comparable<T> value) {
+    public static <T> void exclusiveBetween(final T start, final T end, final Comparable<T> value) {
         // TODO when breaking BC, consider returning value
         if (value.compareTo(start) <= 0 || value.compareTo(end) >= 0) {
             throw new IllegalArgumentException(String.format(DEFAULT_EXCLUSIVE_BETWEEN_EX_MESSAGE, value, start, end));
@@ -969,7 +969,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static <T> void exclusiveBetween(T start, T end, Comparable<T> value, String message, Object... values) {
+    public static <T> void exclusiveBetween(final T start, final T end, final Comparable<T> value, final String message, final Object... values) {
         // TODO when breaking BC, consider returning value
         if (value.compareTo(start) <= 0 || value.compareTo(end) >= 0) {
             throw new IllegalArgumentException(String.format(message, values));
@@ -995,7 +995,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static void isInstanceOf(Class<?> type, Object obj) {
+    public static void isInstanceOf(final Class<?> type, final Object obj) {
         // TODO when breaking BC, consider returning obj
         if (type.isInstance(obj) == false) {
             throw new IllegalArgumentException(String.format(DEFAULT_IS_INSTANCE_OF_EX_MESSAGE, type.getName(),
@@ -1020,7 +1020,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static void isInstanceOf(Class<?> type, Object obj, String message, Object... values) {
+    public static void isInstanceOf(final Class<?> type, final Object obj, final String message, final Object... values) {
         // TODO when breaking BC, consider returning obj
         if (type.isInstance(obj) == false) {
             throw new IllegalArgumentException(String.format(message, values));
@@ -1046,7 +1046,7 @@ public class Validate {
      *
      * @since 3.0
      */
-    public static void isAssignableFrom(Class<?> superType, Class<?> type) {
+    public static void isAssignableFrom(final Class<?> superType, final Class<?> type) {
         // TODO when breaking BC, consider returning type
         if (superType.isAssignableFrom(type) == false) {
             throw new IllegalArgumentException(String.format(DEFAULT_IS_ASSIGNABLE_EX_MESSAGE, type == null ? "null" : type.getName(),
@@ -1071,7 +1071,7 @@ public class Validate {
      * @throws IllegalArgumentException if argument can not be converted to the specified class
      * @see #isAssignableFrom(Class, Class)
      */
-    public static void isAssignableFrom(Class<?> superType, Class<?> type, String message, Object... values) {
+    public static void isAssignableFrom(final Class<?> superType, final Class<?> type, final String message, final Object... values) {
         // TODO when breaking BC, consider returning type
         if (superType.isAssignableFrom(type) == false) {
             throw new IllegalArgumentException(String.format(message, values));

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/CompareToBuilder.java Tue Jan 22 07:07:42 2013
@@ -131,7 +131,7 @@ public class CompareToBuilder implements
      * @throws ClassCastException  if <code>rhs</code> is not assignment-compatible
      *  with <code>lhs</code>
      */
-    public static int reflectionCompare(Object lhs, Object rhs) {
+    public static int reflectionCompare(final Object lhs, final Object rhs) {
         return reflectionCompare(lhs, rhs, false, null);
     }
 
@@ -163,7 +163,7 @@ public class CompareToBuilder implements
      * @throws ClassCastException  if <code>rhs</code> is not assignment-compatible
      *  with <code>lhs</code>
      */
-    public static int reflectionCompare(Object lhs, Object rhs, boolean compareTransients) {
+    public static int reflectionCompare(final Object lhs, final Object rhs, final boolean compareTransients) {
         return reflectionCompare(lhs, rhs, compareTransients, null);
     }
 
@@ -196,7 +196,7 @@ public class CompareToBuilder implements
      *  with <code>lhs</code>
      * @since 2.2
      */
-    public static int reflectionCompare(Object lhs, Object rhs, Collection<String> excludeFields) {
+    public static int reflectionCompare(final Object lhs, final Object rhs, final Collection<String> excludeFields) {
         return reflectionCompare(lhs, rhs, ReflectionToStringBuilder.toNoNullStringArray(excludeFields));
     }
 
@@ -229,7 +229,7 @@ public class CompareToBuilder implements
      *  with <code>lhs</code>
      * @since 2.2
      */
-    public static int reflectionCompare(Object lhs, Object rhs, String... excludeFields) {
+    public static int reflectionCompare(final Object lhs, final Object rhs, final String... excludeFields) {
         return reflectionCompare(lhs, rhs, false, null, excludeFields);
     }
 
@@ -266,11 +266,11 @@ public class CompareToBuilder implements
      * @since 2.2 (2.0 as <code>reflectionCompare(Object, Object, boolean, Class)</code>)
      */
     public static int reflectionCompare(
-        Object lhs, 
-        Object rhs, 
-        boolean compareTransients, 
-        Class<?> reflectUpToClass, 
-        String... excludeFields) {
+        final Object lhs, 
+        final Object rhs, 
+        final boolean compareTransients, 
+        final Class<?> reflectUpToClass, 
+        final String... excludeFields) {
 
         if (lhs == rhs) {
             return 0;
@@ -303,12 +303,12 @@ public class CompareToBuilder implements
      * @param excludeFields  fields to exclude
      */
     private static void reflectionAppend(
-        Object lhs,
-        Object rhs,
-        Class<?> clazz,
-        CompareToBuilder builder,
-        boolean useTransients,
-        String[] excludeFields) {
+        final Object lhs,
+        final Object rhs,
+        final Class<?> clazz,
+        final CompareToBuilder builder,
+        final boolean useTransients,
+        final String[] excludeFields) {
         
         Field[] fields = clazz.getDeclaredFields();
         AccessibleObject.setAccessible(fields, true);
@@ -338,7 +338,7 @@ public class CompareToBuilder implements
      * @return this - used to chain append calls
      * @since 2.0
      */
-    public CompareToBuilder appendSuper(int superCompareTo) {
+    public CompareToBuilder appendSuper(final int superCompareTo) {
         if (comparison != 0) {
             return this;
         }
@@ -366,7 +366,7 @@ public class CompareToBuilder implements
      * @throws ClassCastException  if <code>rhs</code> is not assignment-compatible
      *  with <code>lhs</code>
      */
-    public CompareToBuilder append(Object lhs, Object rhs) {
+    public CompareToBuilder append(final Object lhs, final Object rhs) {
         return append(lhs, rhs, null);
     }
 
@@ -395,7 +395,7 @@ public class CompareToBuilder implements
      *  with <code>lhs</code>
      * @since 2.0
      */
-    public CompareToBuilder append(Object lhs, Object rhs, Comparator<?> comparator) {
+    public CompareToBuilder append(final Object lhs, final Object rhs, final Comparator<?> comparator) {
         if (comparison != 0) {
             return this;
         }
@@ -459,7 +459,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand value
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(long lhs, long rhs) {
+    public CompareToBuilder append(final long lhs, final long rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -475,7 +475,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand value
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(int lhs, int rhs) {
+    public CompareToBuilder append(final int lhs, final int rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -491,7 +491,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand value
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(short lhs, short rhs) {
+    public CompareToBuilder append(final short lhs, final short rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -507,7 +507,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand value
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(char lhs, char rhs) {
+    public CompareToBuilder append(final char lhs, final char rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -523,7 +523,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand value
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(byte lhs, byte rhs) {
+    public CompareToBuilder append(final byte lhs, final byte rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -544,7 +544,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand value
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(double lhs, double rhs) {
+    public CompareToBuilder append(final double lhs, final double rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -565,7 +565,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand value
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(float lhs, float rhs) {
+    public CompareToBuilder append(final float lhs, final float rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -581,7 +581,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand value
      * @return this - used to chain append calls
       */
-    public CompareToBuilder append(boolean lhs, boolean rhs) {
+    public CompareToBuilder append(final boolean lhs, final boolean rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -617,7 +617,7 @@ public class CompareToBuilder implements
      * @throws ClassCastException  if <code>rhs</code> is not assignment-compatible
      *  with <code>lhs</code>
      */
-    public CompareToBuilder append(Object[] lhs, Object[] rhs) {
+    public CompareToBuilder append(final Object[] lhs, final Object[] rhs) {
         return append(lhs, rhs, null);
     }
     
@@ -644,7 +644,7 @@ public class CompareToBuilder implements
      *  with <code>lhs</code>
      * @since 2.0
      */
-    public CompareToBuilder append(Object[] lhs, Object[] rhs, Comparator<?> comparator) {
+    public CompareToBuilder append(final Object[] lhs, final Object[] rhs, final Comparator<?> comparator) {
         if (comparison != 0) {
             return this;
         }
@@ -684,7 +684,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand array
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(long[] lhs, long[] rhs) {
+    public CompareToBuilder append(final long[] lhs, final long[] rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -724,7 +724,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand array
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(int[] lhs, int[] rhs) {
+    public CompareToBuilder append(final int[] lhs, final int[] rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -764,7 +764,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand array
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(short[] lhs, short[] rhs) {
+    public CompareToBuilder append(final short[] lhs, final short[] rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -804,7 +804,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand array
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(char[] lhs, char[] rhs) {
+    public CompareToBuilder append(final char[] lhs, final char[] rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -844,7 +844,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand array
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(byte[] lhs, byte[] rhs) {
+    public CompareToBuilder append(final byte[] lhs, final byte[] rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -884,7 +884,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand array
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(double[] lhs, double[] rhs) {
+    public CompareToBuilder append(final double[] lhs, final double[] rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -924,7 +924,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand array
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(float[] lhs, float[] rhs) {
+    public CompareToBuilder append(final float[] lhs, final float[] rhs) {
         if (comparison != 0) {
             return this;
         }
@@ -964,7 +964,7 @@ public class CompareToBuilder implements
      * @param rhs  right-hand array
      * @return this - used to chain append calls
      */
-    public CompareToBuilder append(boolean[] lhs, boolean[] rhs) {
+    public CompareToBuilder append(final boolean[] lhs, final boolean[] rhs) {
         if (comparison != 0) {
             return this;
         }

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java Tue Jan 22 07:07:42 2013
@@ -131,7 +131,7 @@ public class EqualsBuilder implements Bu
      *
      * @return the pair
      */
-    static Pair<IDKey, IDKey> getRegisterPair(Object lhs, Object rhs) {
+    static Pair<IDKey, IDKey> getRegisterPair(final Object lhs, final Object rhs) {
         IDKey left = new IDKey(lhs);
         IDKey right = new IDKey(rhs);
         return Pair.of(left, right);
@@ -150,7 +150,7 @@ public class EqualsBuilder implements Bu
      * @return boolean <code>true</code> if the registry contains the given object.
      * @since 3.0
      */
-    static boolean isRegistered(Object lhs, Object rhs) {
+    static boolean isRegistered(final Object lhs, final Object rhs) {
         Set<Pair<IDKey, IDKey>> registry = getRegistry();
         Pair<IDKey, IDKey> pair = getRegisterPair(lhs, rhs);
         Pair<IDKey, IDKey> swappedPair = Pair.of(pair.getLeft(), pair.getRight());
@@ -168,7 +168,7 @@ public class EqualsBuilder implements Bu
      * @param lhs <code>this</code> object to register
      * @param rhs the other object to register
      */
-    static void register(Object lhs, Object rhs) {
+    static void register(final Object lhs, final Object rhs) {
         synchronized (EqualsBuilder.class) {
             if (getRegistry() == null) {
                 REGISTRY.set(new HashSet<Pair<IDKey, IDKey>>());
@@ -192,7 +192,7 @@ public class EqualsBuilder implements Bu
      * @param rhs the other object to unregister
      * @since 3.0
      */
-    static void unregister(Object lhs, Object rhs) {
+    static void unregister(final Object lhs, final Object rhs) {
         Set<Pair<IDKey, IDKey>> registry = getRegistry();
         if (registry != null) {
             Pair<IDKey, IDKey> pair = getRegisterPair(lhs, rhs);
@@ -244,7 +244,7 @@ public class EqualsBuilder implements Bu
      * @param excludeFields  Collection of String field names to exclude from testing
      * @return <code>true</code> if the two Objects have tested equals.
      */
-    public static boolean reflectionEquals(Object lhs, Object rhs, Collection<String> excludeFields) {
+    public static boolean reflectionEquals(final Object lhs, final Object rhs, final Collection<String> excludeFields) {
         return reflectionEquals(lhs, rhs, ReflectionToStringBuilder.toNoNullStringArray(excludeFields));
     }
 
@@ -267,7 +267,7 @@ public class EqualsBuilder implements Bu
      * @param excludeFields  array of field names to exclude from testing
      * @return <code>true</code> if the two Objects have tested equals.
      */
-    public static boolean reflectionEquals(Object lhs, Object rhs, String... excludeFields) {
+    public static boolean reflectionEquals(final Object lhs, final Object rhs, final String... excludeFields) {
         return reflectionEquals(lhs, rhs, false, null, excludeFields);
     }
 
@@ -291,7 +291,7 @@ public class EqualsBuilder implements Bu
      * @param testTransients  whether to include transient fields
      * @return <code>true</code> if the two Objects have tested equals.
      */
-    public static boolean reflectionEquals(Object lhs, Object rhs, boolean testTransients) {
+    public static boolean reflectionEquals(final Object lhs, final Object rhs, final boolean testTransients) {
         return reflectionEquals(lhs, rhs, testTransients, null);
     }
 
@@ -321,8 +321,8 @@ public class EqualsBuilder implements Bu
      * @return <code>true</code> if the two Objects have tested equals.
      * @since 2.0
      */
-    public static boolean reflectionEquals(Object lhs, Object rhs, boolean testTransients, Class<?> reflectUpToClass,
-            String... excludeFields) {
+    public static boolean reflectionEquals(final Object lhs, final Object rhs, final boolean testTransients, final Class<?> reflectUpToClass,
+            final String... excludeFields) {
         if (lhs == rhs) {
             return true;
         }
@@ -382,12 +382,12 @@ public class EqualsBuilder implements Bu
      * @param excludeFields  array of field names to exclude from testing
      */
     private static void reflectionAppend(
-        Object lhs,
-        Object rhs,
-        Class<?> clazz,
-        EqualsBuilder builder,
-        boolean useTransients,
-        String[] excludeFields) {
+        final Object lhs,
+        final Object rhs,
+        final Class<?> clazz,
+        final EqualsBuilder builder,
+        final boolean useTransients,
+        final String[] excludeFields) {
 
         if (isRegistered(lhs, rhs)) {
             return;
@@ -426,7 +426,7 @@ public class EqualsBuilder implements Bu
      * @return EqualsBuilder - used to chain calls.
      * @since 2.0
      */
-    public EqualsBuilder appendSuper(boolean superEquals) {
+    public EqualsBuilder appendSuper(final boolean superEquals) {
         if (isEquals == false) {
             return this;
         }
@@ -444,7 +444,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand object
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(Object lhs, Object rhs) {
+    public EqualsBuilder append(final Object lhs, final Object rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -499,7 +499,7 @@ public class EqualsBuilder implements Bu
      *                  the right hand <code>long</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(long lhs, long rhs) {
+    public EqualsBuilder append(final long lhs, final long rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -514,7 +514,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>int</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(int lhs, int rhs) {
+    public EqualsBuilder append(final int lhs, final int rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -529,7 +529,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>short</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(short lhs, short rhs) {
+    public EqualsBuilder append(final short lhs, final short rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -544,7 +544,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>char</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(char lhs, char rhs) {
+    public EqualsBuilder append(final char lhs, final char rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -559,7 +559,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>byte</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(byte lhs, byte rhs) {
+    public EqualsBuilder append(final byte lhs, final byte rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -580,7 +580,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>double</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(double lhs, double rhs) {
+    public EqualsBuilder append(final double lhs, final double rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -600,7 +600,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>float</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(float lhs, float rhs) {
+    public EqualsBuilder append(final float lhs, final float rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -614,7 +614,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>boolean</code>
      * @return EqualsBuilder - used to chain calls.
       */
-    public EqualsBuilder append(boolean lhs, boolean rhs) {
+    public EqualsBuilder append(final boolean lhs, final boolean rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -632,7 +632,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>Object[]</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(Object[] lhs, Object[] rhs) {
+    public EqualsBuilder append(final Object[] lhs, final Object[] rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -663,7 +663,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>long[]</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(long[] lhs, long[] rhs) {
+    public EqualsBuilder append(final long[] lhs, final long[] rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -694,7 +694,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>int[]</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(int[] lhs, int[] rhs) {
+    public EqualsBuilder append(final int[] lhs, final int[] rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -725,7 +725,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>short[]</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(short[] lhs, short[] rhs) {
+    public EqualsBuilder append(final short[] lhs, final short[] rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -756,7 +756,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>char[]</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(char[] lhs, char[] rhs) {
+    public EqualsBuilder append(final char[] lhs, final char[] rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -787,7 +787,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>byte[]</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(byte[] lhs, byte[] rhs) {
+    public EqualsBuilder append(final byte[] lhs, final byte[] rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -818,7 +818,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>double[]</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(double[] lhs, double[] rhs) {
+    public EqualsBuilder append(final double[] lhs, final double[] rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -849,7 +849,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>float[]</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(float[] lhs, float[] rhs) {
+    public EqualsBuilder append(final float[] lhs, final float[] rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -880,7 +880,7 @@ public class EqualsBuilder implements Bu
      * @param rhs  the right hand <code>boolean[]</code>
      * @return EqualsBuilder - used to chain calls.
      */
-    public EqualsBuilder append(boolean[] lhs, boolean[] rhs) {
+    public EqualsBuilder append(final boolean[] lhs, final boolean[] rhs) {
         if (isEquals == false) {
             return this;
         }
@@ -931,7 +931,7 @@ public class EqualsBuilder implements Bu
      * @param isEquals The value to set.
      * @since 2.1
      */
-    protected void setEquals(boolean isEquals) {
+    protected void setEquals(final boolean isEquals) {
         this.isEquals = isEquals;
     }
 

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/HashCodeBuilder.java Tue Jan 22 07:07:42 2013
@@ -147,7 +147,7 @@ public class HashCodeBuilder implements 
      * @return boolean <code>true</code> if the registry contains the given object.
      * @since 2.3
      */
-    static boolean isRegistered(Object value) {
+    static boolean isRegistered(final Object value) {
         Set<IDKey> registry = getRegistry();
         return registry != null && registry.contains(new IDKey(value));
     }
@@ -168,8 +168,8 @@ public class HashCodeBuilder implements 
      * @param excludeFields
      *            Collection of String field names to exclude from use in calculation of hash code
      */
-    private static void reflectionAppend(Object object, Class<?> clazz, HashCodeBuilder builder, boolean useTransients,
-            String[] excludeFields) {
+    private static void reflectionAppend(final Object object, final Class<?> clazz, final HashCodeBuilder builder, final boolean useTransients,
+            final String[] excludeFields) {
         if (isRegistered(object)) {
             return;
         }
@@ -234,7 +234,7 @@ public class HashCodeBuilder implements 
      * @throws IllegalArgumentException
      *             if the number is zero or even
      */
-    public static int reflectionHashCode(int initialNonZeroOddNumber, int multiplierNonZeroOddNumber, Object object) {
+    public static int reflectionHashCode(final int initialNonZeroOddNumber, final int multiplierNonZeroOddNumber, final Object object) {
         return reflectionHashCode(initialNonZeroOddNumber, multiplierNonZeroOddNumber, object, false, null);
     }
 
@@ -277,8 +277,8 @@ public class HashCodeBuilder implements 
      * @throws IllegalArgumentException
      *             if the number is zero or even
      */
-    public static int reflectionHashCode(int initialNonZeroOddNumber, int multiplierNonZeroOddNumber, Object object,
-            boolean testTransients) {
+    public static int reflectionHashCode(final int initialNonZeroOddNumber, final int multiplierNonZeroOddNumber, final Object object,
+            final boolean testTransients) {
         return reflectionHashCode(initialNonZeroOddNumber, multiplierNonZeroOddNumber, object, testTransients, null);
     }
 
@@ -329,8 +329,8 @@ public class HashCodeBuilder implements 
      *             if the number is zero or even
      * @since 2.0
      */
-    public static <T> int reflectionHashCode(int initialNonZeroOddNumber, int multiplierNonZeroOddNumber, T object,
-            boolean testTransients, Class<? super T> reflectUpToClass, String... excludeFields) {
+    public static <T> int reflectionHashCode(final int initialNonZeroOddNumber, final int multiplierNonZeroOddNumber, final T object,
+            final boolean testTransients, final Class<? super T> reflectUpToClass, final String... excludeFields) {
 
         if (object == null) {
             throw new IllegalArgumentException("The object to build a hash code for must not be null");
@@ -377,7 +377,7 @@ public class HashCodeBuilder implements 
      * @throws IllegalArgumentException
      *             if the object is <code>null</code>
      */
-    public static int reflectionHashCode(Object object, boolean testTransients) {
+    public static int reflectionHashCode(final Object object, final boolean testTransients) {
         return reflectionHashCode(17, 37, object, testTransients, null);
     }
 
@@ -413,7 +413,7 @@ public class HashCodeBuilder implements 
      * @throws IllegalArgumentException
      *             if the object is <code>null</code>
      */
-    public static int reflectionHashCode(Object object, Collection<String> excludeFields) {
+    public static int reflectionHashCode(final Object object, final Collection<String> excludeFields) {
         return reflectionHashCode(object, ReflectionToStringBuilder.toNoNullStringArray(excludeFields));
     }
 
@@ -451,7 +451,7 @@ public class HashCodeBuilder implements 
      * @throws IllegalArgumentException
      *             if the object is <code>null</code>
      */
-    public static int reflectionHashCode(Object object, String... excludeFields) {
+    public static int reflectionHashCode(final Object object, final String... excludeFields) {
         return reflectionHashCode(17, 37, object, false, null, excludeFields);
     }
 
@@ -463,7 +463,7 @@ public class HashCodeBuilder implements 
      * @param value
      *            The object to register.
      */
-    static void register(Object value) {
+    static void register(final Object value) {
         synchronized (HashCodeBuilder.class) {
             if (getRegistry() == null) {
                 REGISTRY.set(new HashSet<IDKey>());
@@ -484,7 +484,7 @@ public class HashCodeBuilder implements 
      *            The object to unregister.
      * @since 2.3
      */
-    static void unregister(Object value) {
+    static void unregister(final Object value) {
         Set<IDKey> registry = getRegistry();
         if (registry != null) {
             registry.remove(new IDKey(value));
@@ -535,7 +535,7 @@ public class HashCodeBuilder implements 
      * @throws IllegalArgumentException
      *             if the number is zero or even
      */
-    public HashCodeBuilder(int initialNonZeroOddNumber, int multiplierNonZeroOddNumber) {
+    public HashCodeBuilder(final int initialNonZeroOddNumber, final int multiplierNonZeroOddNumber) {
         if (initialNonZeroOddNumber == 0) {
             throw new IllegalArgumentException("HashCodeBuilder requires a non zero initial value");
         }
@@ -573,7 +573,7 @@ public class HashCodeBuilder implements 
      *            the boolean to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(boolean value) {
+    public HashCodeBuilder append(final boolean value) {
         iTotal = iTotal * iConstant + (value ? 0 : 1);
         return this;
     }
@@ -587,7 +587,7 @@ public class HashCodeBuilder implements 
      *            the array to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(boolean[] array) {
+    public HashCodeBuilder append(final boolean[] array) {
         if (array == null) {
             iTotal = iTotal * iConstant;
         } else {
@@ -609,7 +609,7 @@ public class HashCodeBuilder implements 
      *            the byte to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(byte value) {
+    public HashCodeBuilder append(final byte value) {
         iTotal = iTotal * iConstant + value;
         return this;
     }
@@ -625,7 +625,7 @@ public class HashCodeBuilder implements 
      *            the array to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(byte[] array) {
+    public HashCodeBuilder append(final byte[] array) {
         if (array == null) {
             iTotal = iTotal * iConstant;
         } else {
@@ -645,7 +645,7 @@ public class HashCodeBuilder implements 
      *            the char to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(char value) {
+    public HashCodeBuilder append(final char value) {
         iTotal = iTotal * iConstant + value;
         return this;
     }
@@ -659,7 +659,7 @@ public class HashCodeBuilder implements 
      *            the array to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(char[] array) {
+    public HashCodeBuilder append(final char[] array) {
         if (array == null) {
             iTotal = iTotal * iConstant;
         } else {
@@ -679,7 +679,7 @@ public class HashCodeBuilder implements 
      *            the double to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(double value) {
+    public HashCodeBuilder append(final double value) {
         return append(Double.doubleToLongBits(value));
     }
 
@@ -692,7 +692,7 @@ public class HashCodeBuilder implements 
      *            the array to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(double[] array) {
+    public HashCodeBuilder append(final double[] array) {
         if (array == null) {
             iTotal = iTotal * iConstant;
         } else {
@@ -712,7 +712,7 @@ public class HashCodeBuilder implements 
      *            the float to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(float value) {
+    public HashCodeBuilder append(final float value) {
         iTotal = iTotal * iConstant + Float.floatToIntBits(value);
         return this;
     }
@@ -726,7 +726,7 @@ public class HashCodeBuilder implements 
      *            the array to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(float[] array) {
+    public HashCodeBuilder append(final float[] array) {
         if (array == null) {
             iTotal = iTotal * iConstant;
         } else {
@@ -746,7 +746,7 @@ public class HashCodeBuilder implements 
      *            the int to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(int value) {
+    public HashCodeBuilder append(final int value) {
         iTotal = iTotal * iConstant + value;
         return this;
     }
@@ -760,7 +760,7 @@ public class HashCodeBuilder implements 
      *            the array to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(int[] array) {
+    public HashCodeBuilder append(final int[] array) {
         if (array == null) {
             iTotal = iTotal * iConstant;
         } else {
@@ -784,7 +784,7 @@ public class HashCodeBuilder implements 
     //       Long.hashCode do. Ideally we should switch to >>> at
     //       some stage. There are backwards compat issues, so
     //       that will have to wait for the time being. cf LANG-342.
-    public HashCodeBuilder append(long value) {
+    public HashCodeBuilder append(final long value) {
         iTotal = iTotal * iConstant + ((int) (value ^ (value >> 32)));
         return this;
     }
@@ -798,7 +798,7 @@ public class HashCodeBuilder implements 
      *            the array to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(long[] array) {
+    public HashCodeBuilder append(final long[] array) {
         if (array == null) {
             iTotal = iTotal * iConstant;
         } else {
@@ -818,7 +818,7 @@ public class HashCodeBuilder implements 
      *            the Object to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(Object object) {
+    public HashCodeBuilder append(final Object object) {
         if (object == null) {
             iTotal = iTotal * iConstant;
 
@@ -862,7 +862,7 @@ public class HashCodeBuilder implements 
      *            the array to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(Object[] array) {
+    public HashCodeBuilder append(final Object[] array) {
         if (array == null) {
             iTotal = iTotal * iConstant;
         } else {
@@ -882,7 +882,7 @@ public class HashCodeBuilder implements 
      *            the short to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(short value) {
+    public HashCodeBuilder append(final short value) {
         iTotal = iTotal * iConstant + value;
         return this;
     }
@@ -896,7 +896,7 @@ public class HashCodeBuilder implements 
      *            the array to add to the <code>hashCode</code>
      * @return this
      */
-    public HashCodeBuilder append(short[] array) {
+    public HashCodeBuilder append(final short[] array) {
         if (array == null) {
             iTotal = iTotal * iConstant;
         } else {
@@ -917,7 +917,7 @@ public class HashCodeBuilder implements 
      * @return this HashCodeBuilder, used to chain calls.
      * @since 2.0
      */
-    public HashCodeBuilder appendSuper(int superHashCode) {
+    public HashCodeBuilder appendSuper(final int superHashCode) {
         iTotal = iTotal * iConstant + superHashCode;
         return this;
     }

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/IDKey.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/IDKey.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/IDKey.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/IDKey.java Tue Jan 22 07:07:42 2013
@@ -36,7 +36,7 @@ final class IDKey {
          * Constructor for IDKey
          * @param _value The value
          */ 
-        public IDKey(Object _value) {
+        public IDKey(final Object _value) {
             // This is the Object hashcode 
             id = System.identityHashCode(_value);  
             // There have been some cases (LANG-459) that return the 
@@ -60,7 +60,7 @@ final class IDKey {
          * @return if the instances are for the same object
          */ 
         @Override
-        public boolean equals(Object other) {
+        public boolean equals(final Object other) {
             if (!(other instanceof IDKey)) {
                 return false;
             }

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/ReflectionToStringBuilder.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/ReflectionToStringBuilder.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/ReflectionToStringBuilder.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/ReflectionToStringBuilder.java Tue Jan 22 07:07:42 2013
@@ -109,7 +109,7 @@ public class ReflectionToStringBuilder e
      * @throws IllegalArgumentException
      *             if the Object is <code>null</code>
      */
-    public static String toString(Object object) {
+    public static String toString(final Object object) {
         return toString(object, null, false, false, null);
     }
 
@@ -141,7 +141,7 @@ public class ReflectionToStringBuilder e
      * @throws IllegalArgumentException
      *             if the Object or <code>ToStringStyle</code> is <code>null</code>
      */
-    public static String toString(Object object, ToStringStyle style) {
+    public static String toString(final Object object, final ToStringStyle style) {
         return toString(object, style, false, false, null);
     }
 
@@ -179,7 +179,7 @@ public class ReflectionToStringBuilder e
      * @throws IllegalArgumentException
      *             if the Object is <code>null</code>
      */
-    public static String toString(Object object, ToStringStyle style, boolean outputTransients) {
+    public static String toString(final Object object, final ToStringStyle style, final boolean outputTransients) {
         return toString(object, style, outputTransients, false, null);
     }
 
@@ -225,7 +225,7 @@ public class ReflectionToStringBuilder e
      *             if the Object is <code>null</code>
      * @since 2.1
      */
-    public static String toString(Object object, ToStringStyle style, boolean outputTransients, boolean outputStatics) {
+    public static String toString(final Object object, final ToStringStyle style, final boolean outputTransients, final boolean outputStatics) {
         return toString(object, style, outputTransients, outputStatics, null);
     }
 
@@ -277,8 +277,8 @@ public class ReflectionToStringBuilder e
      * @since 2.1
      */
     public static <T> String toString(
-            T object, ToStringStyle style, boolean outputTransients,
-            boolean outputStatics, Class<? super T> reflectUpToClass) {
+            final T object, final ToStringStyle style, final boolean outputTransients,
+            final boolean outputStatics, final Class<? super T> reflectUpToClass) {
         return new ReflectionToStringBuilder(object, style, null, reflectUpToClass, outputTransients, outputStatics)
                 .toString();
     }
@@ -292,7 +292,7 @@ public class ReflectionToStringBuilder e
      *            The field names to exclude. Null excludes nothing.
      * @return The toString value.
      */
-    public static String toStringExclude(Object object, Collection<String> excludeFieldNames) {
+    public static String toStringExclude(final Object object, final Collection<String> excludeFieldNames) {
         return toStringExclude(object, toNoNullStringArray(excludeFieldNames));
     }
 
@@ -305,7 +305,7 @@ public class ReflectionToStringBuilder e
      *            The collection to convert
      * @return A new array of Strings.
      */
-    static String[] toNoNullStringArray(Collection<String> collection) {
+    static String[] toNoNullStringArray(final Collection<String> collection) {
         if (collection == null) {
             return ArrayUtils.EMPTY_STRING_ARRAY;
         }
@@ -321,7 +321,7 @@ public class ReflectionToStringBuilder e
      *            The array to check
      * @return The given array or a new array without null.
      */
-    static String[] toNoNullStringArray(Object[] array) {
+    static String[] toNoNullStringArray(final Object[] array) {
         List<String> list = new ArrayList<String>(array.length);
         for (Object e : array) {
             if (e != null) {
@@ -341,7 +341,7 @@ public class ReflectionToStringBuilder e
      *            The field names to exclude
      * @return The toString value.
      */
-    public static String toStringExclude(Object object, String... excludeFieldNames) {
+    public static String toStringExclude(final Object object, final String... excludeFieldNames) {
         return new ReflectionToStringBuilder(object).setExcludeFieldNames(excludeFieldNames).toString();
     }
 
@@ -381,7 +381,7 @@ public class ReflectionToStringBuilder e
      * @throws IllegalArgumentException
      *             if the Object passed in is <code>null</code>
      */
-    public ReflectionToStringBuilder(Object object) {
+    public ReflectionToStringBuilder(final Object object) {
         super(object);
     }
 
@@ -401,7 +401,7 @@ public class ReflectionToStringBuilder e
      * @throws IllegalArgumentException
      *             if the Object passed in is <code>null</code>
      */
-    public ReflectionToStringBuilder(Object object, ToStringStyle style) {
+    public ReflectionToStringBuilder(final Object object, final ToStringStyle style) {
         super(object, style);
     }
 
@@ -427,7 +427,7 @@ public class ReflectionToStringBuilder e
      * @throws IllegalArgumentException
      *             if the Object passed in is <code>null</code>
      */
-    public ReflectionToStringBuilder(Object object, ToStringStyle style, StringBuffer buffer) {
+    public ReflectionToStringBuilder(final Object object, final ToStringStyle style, final StringBuffer buffer) {
         super(object, style, buffer);
     }
 
@@ -451,8 +451,8 @@ public class ReflectionToStringBuilder e
      * @since 2.1
      */
     public <T> ReflectionToStringBuilder(
-            T object, ToStringStyle style, StringBuffer buffer,
-            Class<? super T> reflectUpToClass, boolean outputTransients, boolean outputStatics) {
+            final T object, final ToStringStyle style, final StringBuffer buffer,
+            final Class<? super T> reflectUpToClass, final boolean outputTransients, final boolean outputStatics) {
         super(object, style, buffer);
         this.setUpToClass(reflectUpToClass);
         this.setAppendTransients(outputTransients);
@@ -471,7 +471,7 @@ public class ReflectionToStringBuilder e
      *            The Field to test.
      * @return Whether or not to append the given <code>Field</code>.
      */
-    protected boolean accept(Field field) {
+    protected boolean accept(final Field field) {
         if (field.getName().indexOf(ClassUtils.INNER_CLASS_SEPARATOR_CHAR) != -1) {
             // Reject field from inner class.
             return false;
@@ -505,7 +505,7 @@ public class ReflectionToStringBuilder e
      * @param clazz
      *            The class of object parameter
      */
-    protected void appendFieldsIn(Class<?> clazz) {
+    protected void appendFieldsIn(final Class<?> clazz) {
         if (clazz.isArray()) {
             this.reflectionAppendArray(this.getObject());
             return;
@@ -565,7 +565,7 @@ public class ReflectionToStringBuilder e
      *
      * @see java.lang.reflect.Field#get(Object)
      */
-    protected Object getValue(Field field) throws IllegalArgumentException, IllegalAccessException {
+    protected Object getValue(final Field field) throws IllegalArgumentException, IllegalAccessException {
         return field.get(this.getObject());
     }
 
@@ -601,7 +601,7 @@ public class ReflectionToStringBuilder e
      *            the array to add to the <code>toString</code>
      * @return this
      */
-    public ReflectionToStringBuilder reflectionAppendArray(Object array) {
+    public ReflectionToStringBuilder reflectionAppendArray(final Object array) {
         this.getStyle().reflectionAppendArrayDetail(this.getStringBuffer(), null, array);
         return this;
     }
@@ -615,7 +615,7 @@ public class ReflectionToStringBuilder e
      *            Whether or not to append static fields.
      * @since 2.1
      */
-    public void setAppendStatics(boolean appendStatics) {
+    public void setAppendStatics(final boolean appendStatics) {
         this.appendStatics = appendStatics;
     }
 
@@ -627,7 +627,7 @@ public class ReflectionToStringBuilder e
      * @param appendTransients
      *            Whether or not to append transient fields.
      */
-    public void setAppendTransients(boolean appendTransients) {
+    public void setAppendTransients(final boolean appendTransients) {
         this.appendTransients = appendTransients;
     }
 
@@ -638,7 +638,7 @@ public class ReflectionToStringBuilder e
      *            The excludeFieldNames to excluding from toString or <code>null</code>.
      * @return <code>this</code>
      */
-    public ReflectionToStringBuilder setExcludeFieldNames(String... excludeFieldNamesParam) {
+    public ReflectionToStringBuilder setExcludeFieldNames(final String... excludeFieldNamesParam) {
         if (excludeFieldNamesParam == null) {
             this.excludeFieldNames = null;
         } else {
@@ -657,7 +657,7 @@ public class ReflectionToStringBuilder e
      * @param clazz
      *            The last super class to stop appending fields for.
      */
-    public void setUpToClass(Class<?> clazz) {
+    public void setUpToClass(final Class<?> clazz) {
         if (clazz != null) {
             Object object = getObject();
             if (object != null && clazz.isInstance(object) == false) {

Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/StandardToStringStyle.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/StandardToStringStyle.java?rev=1436768&r1=1436767&r2=1436768&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/StandardToStringStyle.java (original)
+++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/builder/StandardToStringStyle.java Tue Jan 22 07:07:42 2013
@@ -62,7 +62,7 @@ public class StandardToStringStyle exten
      * @param useClassName  the new useClassName flag
      */
     @Override
-    public void setUseClassName(boolean useClassName) { // NOPMD as this is implementing the abstract class
+    public void setUseClassName(final boolean useClassName) { // NOPMD as this is implementing the abstract class
         super.setUseClassName(useClassName);
     }
 
@@ -86,7 +86,7 @@ public class StandardToStringStyle exten
      * @since 2.0
      */
     @Override
-    public void setUseShortClassName(boolean useShortClassName) { // NOPMD as this is implementing the abstract class
+    public void setUseShortClassName(final boolean useShortClassName) { // NOPMD as this is implementing the abstract class
         super.setUseShortClassName(useShortClassName);
     }
 
@@ -107,7 +107,7 @@ public class StandardToStringStyle exten
      * @param useIdentityHashCode  the new useIdentityHashCode flag
      */
     @Override
-    public void setUseIdentityHashCode(boolean useIdentityHashCode) { // NOPMD as this is implementing the abstract class
+    public void setUseIdentityHashCode(final boolean useIdentityHashCode) { // NOPMD as this is implementing the abstract class
         super.setUseIdentityHashCode(useIdentityHashCode);
     }
 
@@ -129,7 +129,7 @@ public class StandardToStringStyle exten
      * @param useFieldNames  the new useFieldNames flag
      */
     @Override
-    public void setUseFieldNames(boolean useFieldNames) { // NOPMD as this is implementing the abstract class
+    public void setUseFieldNames(final boolean useFieldNames) { // NOPMD as this is implementing the abstract class
         super.setUseFieldNames(useFieldNames);
     }
 
@@ -153,7 +153,7 @@ public class StandardToStringStyle exten
      * @param defaultFullDetail  the new defaultFullDetail flag
      */
     @Override
-    public void setDefaultFullDetail(boolean defaultFullDetail) { // NOPMD as this is implementing the abstract class
+    public void setDefaultFullDetail(final boolean defaultFullDetail) { // NOPMD as this is implementing the abstract class
         super.setDefaultFullDetail(defaultFullDetail);
     }
 
@@ -175,7 +175,7 @@ public class StandardToStringStyle exten
      * @param arrayContentDetail  the new arrayContentDetail flag
      */
     @Override
-    public void setArrayContentDetail(boolean arrayContentDetail) { // NOPMD as this is implementing the abstract class
+    public void setArrayContentDetail(final boolean arrayContentDetail) { // NOPMD as this is implementing the abstract class
         super.setArrayContentDetail(arrayContentDetail);
     }
 
@@ -200,7 +200,7 @@ public class StandardToStringStyle exten
      * @param arrayStart  the new array start text
      */
     @Override
-    public void setArrayStart(String arrayStart) { // NOPMD as this is implementing the abstract class
+    public void setArrayStart(final String arrayStart) { // NOPMD as this is implementing the abstract class
         super.setArrayStart(arrayStart);
     }
 
@@ -225,7 +225,7 @@ public class StandardToStringStyle exten
      * @param arrayEnd  the new array end text
      */
     @Override
-    public void setArrayEnd(String arrayEnd) { // NOPMD as this is implementing the abstract class
+    public void setArrayEnd(final String arrayEnd) { // NOPMD as this is implementing the abstract class
         super.setArrayEnd(arrayEnd);
     }
 
@@ -250,7 +250,7 @@ public class StandardToStringStyle exten
      * @param arraySeparator  the new array separator text
      */
     @Override
-    public void setArraySeparator(String arraySeparator) { // NOPMD as this is implementing the abstract class
+    public void setArraySeparator(final String arraySeparator) { // NOPMD as this is implementing the abstract class
         super.setArraySeparator(arraySeparator);
     }
 
@@ -275,7 +275,7 @@ public class StandardToStringStyle exten
      * @param contentStart  the new content start text
      */
     @Override
-    public void setContentStart(String contentStart) { // NOPMD as this is implementing the abstract class
+    public void setContentStart(final String contentStart) { // NOPMD as this is implementing the abstract class
         super.setContentStart(contentStart);
     }
 
@@ -300,7 +300,7 @@ public class StandardToStringStyle exten
      * @param contentEnd  the new content end text
      */
     @Override
-    public void setContentEnd(String contentEnd) { // NOPMD as this is implementing the abstract class
+    public void setContentEnd(final String contentEnd) { // NOPMD as this is implementing the abstract class
         super.setContentEnd(contentEnd);
     }
 
@@ -325,7 +325,7 @@ public class StandardToStringStyle exten
      * @param fieldNameValueSeparator  the new field name value separator text
      */
     @Override
-    public void setFieldNameValueSeparator(String fieldNameValueSeparator) { // NOPMD as this is implementing the abstract class
+    public void setFieldNameValueSeparator(final String fieldNameValueSeparator) { // NOPMD as this is implementing the abstract class
         super.setFieldNameValueSeparator(fieldNameValueSeparator);
     }
 
@@ -350,7 +350,7 @@ public class StandardToStringStyle exten
      * @param fieldSeparator  the new field separator text
      */
     @Override
-    public void setFieldSeparator(String fieldSeparator) { // NOPMD as this is implementing the abstract class
+    public void setFieldSeparator(final String fieldSeparator) { // NOPMD as this is implementing the abstract class
         super.setFieldSeparator(fieldSeparator);
     }
 
@@ -376,7 +376,7 @@ public class StandardToStringStyle exten
      * @since 2.0
      */
     @Override
-    public void setFieldSeparatorAtStart(boolean fieldSeparatorAtStart) { // NOPMD as this is implementing the abstract class
+    public void setFieldSeparatorAtStart(final boolean fieldSeparatorAtStart) { // NOPMD as this is implementing the abstract class
         super.setFieldSeparatorAtStart(fieldSeparatorAtStart);
     }
 
@@ -402,7 +402,7 @@ public class StandardToStringStyle exten
      * @since 2.0
      */
     @Override
-    public void setFieldSeparatorAtEnd(boolean fieldSeparatorAtEnd) { // NOPMD as this is implementing the abstract class
+    public void setFieldSeparatorAtEnd(final boolean fieldSeparatorAtEnd) { // NOPMD as this is implementing the abstract class
         super.setFieldSeparatorAtEnd(fieldSeparatorAtEnd);
     }
 
@@ -427,7 +427,7 @@ public class StandardToStringStyle exten
      * @param nullText  the new text to output when <code>null</code> found
      */
     @Override
-    public void setNullText(String nullText) { // NOPMD as this is implementing the abstract class
+    public void setNullText(final String nullText) { // NOPMD as this is implementing the abstract class
         super.setNullText(nullText);
     }
 
@@ -458,7 +458,7 @@ public class StandardToStringStyle exten
      * @param sizeStartText  the new start of size text
      */
     @Override
-    public void setSizeStartText(String sizeStartText) { // NOPMD as this is implementing the abstract class
+    public void setSizeStartText(final String sizeStartText) { // NOPMD as this is implementing the abstract class
         super.setSizeStartText(sizeStartText);
     }
 
@@ -489,7 +489,7 @@ public class StandardToStringStyle exten
      * @param sizeEndText  the new end of size text
      */
     @Override
-    public void setSizeEndText(String sizeEndText) { // NOPMD as this is implementing the abstract class
+    public void setSizeEndText(final String sizeEndText) { // NOPMD as this is implementing the abstract class
         super.setSizeEndText(sizeEndText);
     }
 
@@ -520,7 +520,7 @@ public class StandardToStringStyle exten
      * @param summaryObjectStartText  the new start of summary text
      */
     @Override
-    public void setSummaryObjectStartText(String summaryObjectStartText) { // NOPMD as this is implementing the abstract class
+    public void setSummaryObjectStartText(final String summaryObjectStartText) { // NOPMD as this is implementing the abstract class
         super.setSummaryObjectStartText(summaryObjectStartText);
     }
 
@@ -551,7 +551,7 @@ public class StandardToStringStyle exten
      * @param summaryObjectEndText  the new end of summary text
      */
     @Override
-    public void setSummaryObjectEndText(String summaryObjectEndText) { // NOPMD as this is implementing the abstract class
+    public void setSummaryObjectEndText(final String summaryObjectEndText) { // NOPMD as this is implementing the abstract class
         super.setSummaryObjectEndText(summaryObjectEndText);
     }
 



Mime
View raw message