commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1432209 - in /commons/proper/imaging/trunk/src: changes/changes.xml main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
Date Fri, 11 Jan 2013 18:25:37 GMT
Author: ggregory
Date: Fri Jan 11 18:25:37 2013
New Revision: 1432209

URL: http://svn.apache.org/viewvc?rev=1432209&view=rev
Log:
[IMAGING-101] GIF dimensions transposed.

Modified:
    commons/proper/imaging/trunk/src/changes/changes.xml
    commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java

Modified: commons/proper/imaging/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/changes/changes.xml?rev=1432209&r1=1432208&r2=1432209&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/changes/changes.xml (original)
+++ commons/proper/imaging/trunk/src/changes/changes.xml Fri Jan 11 18:25:37 2013
@@ -46,6 +46,9 @@ The <action> type attribute can be add,u
   <body>
 
     <release version="1.0" date="TBA" description="TBA">
+      <action issue="IMAGING-101" dev="ggregory" type="fix" due-to="Colm O hEigeartaigh">
+        GIF dimensions transposed.
+      </action>
       <action issue="IMAGING-23" dev="cmchen" type="fix">
         JpegXMPWriter throws NullPointerException.
       </action>

Modified: commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java?rev=1432209&r1=1432208&r2=1432209&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
(original)
+++ commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging/formats/gif/GifImageParser.java
Fri Jan 11 18:25:37 2013
@@ -564,10 +564,9 @@ public class GifImageParser extends Imag
                 blocks.blocks, GRAPHIC_CONTROL_EXTENSION);
 
         // Prefer the size information in the ImageDescriptor; it is more
-        // reliable
-        // than the size information in the header.
-        final int height = id.imageWidth;
-        final int width = id.imageHeight;
+        // reliable than the size information in the header.
+        final int height = id.imageHeight;
+        final int width = id.imageWidth;
 
         final List<String> comments = getComments(blocks.blocks);
         final int bitsPerPixel = (bhi.colorResolution + 1);



Mime
View raw message