commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1429905 [6/26] - in /commons/proper/collections/trunk/src: main/java/org/apache/commons/collections/ main/java/org/apache/commons/collections/bag/ main/java/org/apache/commons/collections/bidimap/ main/java/org/apache/commons/collections/b...
Date Mon, 07 Jan 2013 17:15:24 GMT
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/SynchronizedCollection.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/SynchronizedCollection.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/SynchronizedCollection.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/SynchronizedCollection.java Mon Jan  7 17:15:14 2013
@@ -56,7 +56,7 @@ public class SynchronizedCollection<E> i
      * @return a new synchronized collection
      * @throws IllegalArgumentException if collection is null
      */
-    public static <T> SynchronizedCollection<T> synchronizedCollection(Collection<T> coll) {
+    public static <T> SynchronizedCollection<T> synchronizedCollection(final Collection<T> coll) {
         return new SynchronizedCollection<T>(coll);
     }
 
@@ -67,7 +67,7 @@ public class SynchronizedCollection<E> i
      * @param collection  the collection to decorate, must not be null
      * @throws IllegalArgumentException if the collection is null
      */
-    protected SynchronizedCollection(Collection<E> collection) {
+    protected SynchronizedCollection(final Collection<E> collection) {
         if (collection == null) {
             throw new IllegalArgumentException("Collection must not be null");
         }
@@ -82,7 +82,7 @@ public class SynchronizedCollection<E> i
      * @param lock  the lock object to use, must not be null
      * @throws IllegalArgumentException if the collection is null
      */
-    protected SynchronizedCollection(Collection<E> collection, Object lock) {
+    protected SynchronizedCollection(final Collection<E> collection, final Object lock) {
         if (collection == null) {
             throw new IllegalArgumentException("Collection must not be null");
         }
@@ -101,13 +101,13 @@ public class SynchronizedCollection<E> i
 
     //-----------------------------------------------------------------------
     
-    public boolean add(E object) {
+    public boolean add(final E object) {
         synchronized (lock) {
             return decorated().add(object);
         }
     }
 
-    public boolean addAll(Collection<? extends E> coll) {
+    public boolean addAll(final Collection<? extends E> coll) {
         synchronized (lock) {
             return decorated().addAll(coll);
         }
@@ -119,13 +119,13 @@ public class SynchronizedCollection<E> i
         }
     }
 
-    public boolean contains(Object object) {
+    public boolean contains(final Object object) {
         synchronized (lock) {
             return decorated().contains(object);
         }
     }
 
-    public boolean containsAll(Collection<?> coll) {
+    public boolean containsAll(final Collection<?> coll) {
         synchronized (lock) {
             return decorated().containsAll(coll);
         }
@@ -157,25 +157,25 @@ public class SynchronizedCollection<E> i
         }
     }
 
-    public <T> T[] toArray(T[] object) {
+    public <T> T[] toArray(final T[] object) {
         synchronized (lock) {
             return decorated().toArray(object);
         }
     }
 
-    public boolean remove(Object object) {
+    public boolean remove(final Object object) {
         synchronized (lock) {
             return decorated().remove(object);
         }
     }
 
-    public boolean removeAll(Collection<?> coll) {
+    public boolean removeAll(final Collection<?> coll) {
         synchronized (lock) {
             return decorated().removeAll(coll);
         }
     }
 
-    public boolean retainAll(Collection<?> coll) {
+    public boolean retainAll(final Collection<?> coll) {
         synchronized (lock) {
             return decorated().retainAll(coll);
         }
@@ -188,7 +188,7 @@ public class SynchronizedCollection<E> i
     }
 
     @Override
-    public boolean equals(Object object) {
+    public boolean equals(final Object object) {
         synchronized (lock) {
             if (object == this) {
                 return true;

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/TransformedCollection.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/TransformedCollection.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/TransformedCollection.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/TransformedCollection.java Mon Jan  7 17:15:14 2013
@@ -57,8 +57,8 @@ public class TransformedCollection<E> ex
      * @return a new transformed collection
      * @throws IllegalArgumentException if collection or transformer is null
      */
-    public static <E> TransformedCollection<E> transformingCollection(Collection<E> coll,
-                                                                      Transformer<? super E, ? extends E> transformer) {
+    public static <E> TransformedCollection<E> transformingCollection(final Collection<E> coll,
+                                                                      final Transformer<? super E, ? extends E> transformer) {
         return new TransformedCollection<E>(coll, transformer);
     }
 
@@ -77,15 +77,16 @@ public class TransformedCollection<E> ex
      * @throws IllegalArgumentException if collection or transformer is null
      * @since 3.3
      */
-    public static <E> TransformedCollection<E> transformedCollection(Collection<E> collection,
-                                                                     Transformer<? super E, ? extends E> transformer) {
-        TransformedCollection<E> decorated = new TransformedCollection<E>(collection, transformer);
+    public static <E> TransformedCollection<E> transformedCollection(final Collection<E> collection,
+                                                                     final Transformer<? super E, ? extends E> transformer) {
+        final TransformedCollection<E> decorated = new TransformedCollection<E>(collection, transformer);
         // null collection & transformer are disallowed by the constructor call above 
         if (collection.size() > 0) {
             @SuppressWarnings("unchecked") // collection is of type E
+            final
             E[] values = (E[]) collection.toArray();
             collection.clear();
-            for (E value : values) {
+            for (final E value : values) {
                 decorated.decorated().add(transformer.transform(value));
             }
         }
@@ -103,7 +104,7 @@ public class TransformedCollection<E> ex
      * @param transformer  the transformer to use for conversion, must not be null
      * @throws IllegalArgumentException if collection or transformer is null
      */
-    protected TransformedCollection(Collection<E> coll, Transformer<? super E, ? extends E> transformer) {
+    protected TransformedCollection(final Collection<E> coll, final Transformer<? super E, ? extends E> transformer) {
         super(coll);
         if (transformer == null) {
             throw new IllegalArgumentException("Transformer must not be null");
@@ -119,7 +120,7 @@ public class TransformedCollection<E> ex
      * @param object  the object to transform
      * @return a transformed object
      */
-    protected E transform(E object) {
+    protected E transform(final E object) {
         return transformer.transform(object);
     }
 
@@ -131,9 +132,9 @@ public class TransformedCollection<E> ex
      * @param coll  the collection to transform
      * @return a transformed object
      */
-    protected Collection<E> transform(Collection<? extends E> coll) {
-        List<E> list = new ArrayList<E>(coll.size());
-        for (E item : coll) {
+    protected Collection<E> transform(final Collection<? extends E> coll) {
+        final List<E> list = new ArrayList<E>(coll.size());
+        for (final E item : coll) {
             list.add(transform(item));
         }
         return list;
@@ -141,12 +142,12 @@ public class TransformedCollection<E> ex
 
     //-----------------------------------------------------------------------
     @Override
-    public boolean add(E object) {
+    public boolean add(final E object) {
         return decorated().add(transform(object));
     }
 
     @Override
-    public boolean addAll(Collection<? extends E> coll) {
+    public boolean addAll(final Collection<? extends E> coll) {
         return decorated().addAll(transform(coll));
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableBoundedCollection.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableBoundedCollection.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableBoundedCollection.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableBoundedCollection.java Mon Jan  7 17:15:14 2013
@@ -53,7 +53,7 @@ public final class UnmodifiableBoundedCo
      * @return a new unmodifiable bounded collection
      * @throws IllegalArgumentException if {@code coll} is {@code null}
      */
-    public static <E> BoundedCollection<E> unmodifiableBoundedCollection(BoundedCollection<E> coll) {
+    public static <E> BoundedCollection<E> unmodifiableBoundedCollection(final BoundedCollection<E> coll) {
         return new UnmodifiableBoundedCollection<E>(coll);
     }
 
@@ -98,7 +98,7 @@ public final class UnmodifiableBoundedCo
      * @param coll  the collection to decorate, must not be null
      * @throws IllegalArgumentException if coll is null
      */
-    private UnmodifiableBoundedCollection(BoundedCollection<E> coll) {
+    private UnmodifiableBoundedCollection(final BoundedCollection<E> coll) {
         super(coll);
     }
 
@@ -109,12 +109,12 @@ public final class UnmodifiableBoundedCo
     }
 
     @Override
-    public boolean add(E object) {
+    public boolean add(final E object) {
         throw new UnsupportedOperationException();
     }
 
     @Override
-    public boolean addAll(Collection<? extends E> coll) {
+    public boolean addAll(final Collection<? extends E> coll) {
         throw new UnsupportedOperationException();
     }
 
@@ -124,17 +124,17 @@ public final class UnmodifiableBoundedCo
     }
 
     @Override
-    public boolean remove(Object object) {
+    public boolean remove(final Object object) {
         throw new UnsupportedOperationException();
     }
 
     @Override
-    public boolean removeAll(Collection<?> coll) {
+    public boolean removeAll(final Collection<?> coll) {
         throw new UnsupportedOperationException();
     }
 
     @Override
-    public boolean retainAll(Collection<?> coll) {
+    public boolean retainAll(final Collection<?> coll) {
         throw new UnsupportedOperationException();
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableCollection.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableCollection.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableCollection.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/collection/UnmodifiableCollection.java Mon Jan  7 17:15:14 2013
@@ -50,7 +50,7 @@ public final class UnmodifiableCollectio
      * @return an unmodifiable collection
      * @throws IllegalArgumentException if collection is null
      */
-    public static <T> Collection<T> unmodifiableCollection(Collection<T> coll) {
+    public static <T> Collection<T> unmodifiableCollection(final Collection<T> coll) {
         if (coll instanceof Unmodifiable) {
             return coll;
         }
@@ -64,7 +64,7 @@ public final class UnmodifiableCollectio
      * @param coll  the collection to decorate, must not be null
      * @throws IllegalArgumentException if collection is null
      */
-    private UnmodifiableCollection(Collection<E> coll) {
+    private UnmodifiableCollection(final Collection<E> coll) {
         super(coll);
     }
 
@@ -75,12 +75,12 @@ public final class UnmodifiableCollectio
     }
 
     @Override
-    public boolean add(E object) {
+    public boolean add(final E object) {
         throw new UnsupportedOperationException();
     }
 
     @Override
-    public boolean addAll(Collection<? extends E> coll) {
+    public boolean addAll(final Collection<? extends E> coll) {
         throw new UnsupportedOperationException();
     }
 
@@ -90,17 +90,17 @@ public final class UnmodifiableCollectio
     }
 
     @Override
-    public boolean remove(Object object) {
+    public boolean remove(final Object object) {
         throw new UnsupportedOperationException();
     }
 
     @Override
-    public boolean removeAll(Collection<?> coll) {
+    public boolean removeAll(final Collection<?> coll) {
         throw new UnsupportedOperationException();
     }
 
     @Override
-    public boolean retainAll(Collection<?> coll) {
+    public boolean retainAll(final Collection<?> coll) {
         throw new UnsupportedOperationException();
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/BooleanComparator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/BooleanComparator.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/BooleanComparator.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/BooleanComparator.java Mon Jan  7 17:15:14 2013
@@ -92,7 +92,7 @@ public final class BooleanComparator imp
      * <code>true</code> <code>Boolean</code>s before <code>false</code>
      * @return a singleton BooleanComparator instance
      */
-    public static BooleanComparator booleanComparator(boolean trueFirst) {
+    public static BooleanComparator booleanComparator(final boolean trueFirst) {
         return trueFirst ? TRUE_FIRST : FALSE_FIRST;
     }
 
@@ -119,7 +119,7 @@ public final class BooleanComparator imp
      * @param trueFirst when <code>true</code>, sort 
      *  <code>true</code> boolean values before <code>false</code>
      */
-    public BooleanComparator(boolean trueFirst) {
+    public BooleanComparator(final boolean trueFirst) {
         this.trueFirst = trueFirst;
     }
 
@@ -133,9 +133,9 @@ public final class BooleanComparator imp
      * @return negative if obj1 is less, positive if greater, zero if equal
      * @throws NullPointerException when either argument <code>null</code>
      */
-    public int compare(Boolean b1, Boolean b2) {
-        boolean v1 = b1.booleanValue();
-        boolean v2 = b2.booleanValue();
+    public int compare(final Boolean b1, final Boolean b2) {
+        final boolean v1 = b1.booleanValue();
+        final boolean v2 = b2.booleanValue();
 
         return (v1 ^ v2) ? ( (v1 ^ trueFirst) ? 1 : -1 ) : 0;
     }
@@ -149,7 +149,7 @@ public final class BooleanComparator imp
      */
     @Override
     public int hashCode() {
-        int hash = "BooleanComparator".hashCode();
+        final int hash = "BooleanComparator".hashCode();
         return trueFirst ? -1 * hash : hash;
     }
 
@@ -166,7 +166,7 @@ public final class BooleanComparator imp
      * @return true if equal
      */
     @Override
-    public boolean equals(Object object) {
+    public boolean equals(final Object object) {
         return (this == object) || 
                ((object instanceof BooleanComparator) && 
                 (this.trueFirst == ((BooleanComparator)object).trueFirst));

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparableComparator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparableComparator.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparableComparator.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparableComparator.java Mon Jan  7 17:15:14 2013
@@ -88,7 +88,7 @@ public class ComparableComparator<E exte
      * @throws ClassCastException if <i>obj1</i> is not a <code>Comparable</code>,
      *         or when <code>((Comparable)obj1).compareTo(obj2)</code> does
      */
-    public int compare(E obj1, E obj2) {
+    public int compare(final E obj1, final E obj2) {
         return obj1.compareTo(obj2);
     }
 
@@ -119,7 +119,7 @@ public class ComparableComparator<E exte
      * @since 3.0
      */
     @Override
-    public boolean equals(Object object) {
+    public boolean equals(final Object object) {
         return this == object || 
                null != object && object.getClass().equals(this.getClass());
     }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparatorChain.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparatorChain.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparatorChain.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ComparatorChain.java Mon Jan  7 17:15:14 2013
@@ -76,7 +76,7 @@ public class ComparatorChain<E> implemen
      *
      * @param comparator First comparator in the Comparator chain
      */
-    public ComparatorChain(Comparator<E> comparator) {
+    public ComparatorChain(final Comparator<E> comparator) {
         this(comparator, false);
     }
 
@@ -87,7 +87,7 @@ public class ComparatorChain<E> implemen
      * @param comparator First Comparator in the ComparatorChain
      * @param reverse    false = forward sort; true = reverse sort
      */
-    public ComparatorChain(Comparator<E> comparator, boolean reverse) {
+    public ComparatorChain(final Comparator<E> comparator, final boolean reverse) {
         comparatorChain = new ArrayList<Comparator<E>>(1);
         comparatorChain.add(comparator);
         orderingBits = new BitSet(1);
@@ -104,7 +104,7 @@ public class ComparatorChain<E> implemen
      * @param list   List of Comparators
      * @see #ComparatorChain(List,BitSet)
      */
-    public ComparatorChain(List<Comparator<E>> list) {
+    public ComparatorChain(final List<Comparator<E>> list) {
         this(list, new BitSet(list.size()));
     }
 
@@ -123,7 +123,7 @@ public class ComparatorChain<E> implemen
      * @param bits   Sort order for each Comparator.  Extra bits are ignored,
      *               unless extra Comparators are added by another method.
      */
-    public ComparatorChain(List<Comparator<E>> list, BitSet bits) {
+    public ComparatorChain(final List<Comparator<E>> list, final BitSet bits) {
         comparatorChain = list;
         orderingBits = bits;
     }
@@ -135,7 +135,7 @@ public class ComparatorChain<E> implemen
      *
      * @param comparator Comparator with the forward sort order
      */
-    public void addComparator(Comparator<E> comparator) {
+    public void addComparator(final Comparator<E> comparator) {
         addComparator(comparator, false);
     }
 
@@ -146,7 +146,7 @@ public class ComparatorChain<E> implemen
      * @param comparator Comparator to add to the end of the chain
      * @param reverse    false = forward sort order; true = reverse sort order
      */
-    public void addComparator(Comparator<E> comparator, boolean reverse) {
+    public void addComparator(final Comparator<E> comparator, final boolean reverse) {
         checkLocked();
 
         comparatorChain.add(comparator);
@@ -164,7 +164,7 @@ public class ComparatorChain<E> implemen
      * @exception IndexOutOfBoundsException
      *                   if index &lt; 0 or index &gt;= size()
      */
-    public void setComparator(int index, Comparator<E> comparator) throws IndexOutOfBoundsException {
+    public void setComparator(final int index, final Comparator<E> comparator) throws IndexOutOfBoundsException {
         setComparator(index, comparator, false);
     }
 
@@ -176,7 +176,7 @@ public class ComparatorChain<E> implemen
      * @param comparator Comparator to set
      * @param reverse    false = forward sort order; true = reverse sort order
      */
-    public void setComparator(int index, Comparator<E> comparator, boolean reverse) {
+    public void setComparator(final int index, final Comparator<E> comparator, final boolean reverse) {
         checkLocked();
 
         comparatorChain.set(index,comparator);
@@ -193,7 +193,7 @@ public class ComparatorChain<E> implemen
      *
      * @param index  Index of the ComparatorChain
      */
-    public void setForwardSort(int index) {
+    public void setForwardSort(final int index) {
         checkLocked();
         orderingBits.clear(index);
     }
@@ -204,7 +204,7 @@ public class ComparatorChain<E> implemen
      *
      * @param index  Index of the ComparatorChain
      */
-    public void setReverseSort(int index) {
+    public void setReverseSort(final int index) {
         checkLocked();
         orderingBits.set(index);
     }
@@ -265,17 +265,17 @@ public class ComparatorChain<E> implemen
      *                   if the ComparatorChain does not contain at least one
      *                   Comparator
      */
-    public int compare(E o1, E o2) throws UnsupportedOperationException {
+    public int compare(final E o1, final E o2) throws UnsupportedOperationException {
         if (isLocked == false) {
             checkChainIntegrity();
             isLocked = true;
         }
 
         // iterate over all comparators in the chain
-        Iterator<Comparator<E>> comparators = comparatorChain.iterator();
+        final Iterator<Comparator<E>> comparators = comparatorChain.iterator();
         for (int comparatorIndex = 0; comparators.hasNext(); ++comparatorIndex) {
 
-            Comparator<E> comparator = comparators.next();
+            final Comparator<E> comparator = comparators.next();
             int retval = comparator.compare(o1,o2);
             if (retval != 0) {
                 // invert the order if it is a reverse sort
@@ -331,7 +331,7 @@ public class ComparatorChain<E> implemen
      * @since 3.0
      */
     @Override
-    public boolean equals(Object object) {
+    public boolean equals(final Object object) {
         if (this == object) {
             return true;
         }
@@ -339,7 +339,7 @@ public class ComparatorChain<E> implemen
             return false;
         }
         if (object.getClass().equals(this.getClass())) {
-            ComparatorChain<?> chain = (ComparatorChain<?>) object;
+            final ComparatorChain<?> chain = (ComparatorChain<?>) object;
             return (null == orderingBits ? null == chain.orderingBits : orderingBits
                     .equals(chain.orderingBits)) && (null == comparatorChain ? null == chain.comparatorChain
                     : comparatorChain.equals(chain.comparatorChain));

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/FixedOrderComparator.java Mon Jan  7 17:15:14 2013
@@ -89,12 +89,12 @@ public class FixedOrderComparator<T> imp
      * @param items  the items that the comparator can compare in order
      * @throws IllegalArgumentException if the array is null
      */
-    public FixedOrderComparator(T[] items) {
+    public FixedOrderComparator(final T[] items) {
         super();
         if (items == null) {
             throw new IllegalArgumentException("The list of items must not be null");
         }
-        for (T item : items) {
+        for (final T item : items) {
             add(item);
         }
     }
@@ -108,12 +108,12 @@ public class FixedOrderComparator<T> imp
      * @param items  the items that the comparator can compare in order
      * @throws IllegalArgumentException if the list is null
      */
-    public FixedOrderComparator(List<T> items) {
+    public FixedOrderComparator(final List<T> items) {
         super();
         if (items == null) {
             throw new IllegalArgumentException("The list of items must not be null");
         }
-        for (T t : items) {
+        for (final T t : items) {
             add(t);
         }
     }
@@ -159,7 +159,7 @@ public class FixedOrderComparator<T> imp
      * @throws UnsupportedOperationException if a comparison has been performed
      * @throws IllegalArgumentException if the unknown flag is not valid
      */
-    public void setUnknownObjectBehavior(UnknownObjectBehavior unknownObjectBehavior) {
+    public void setUnknownObjectBehavior(final UnknownObjectBehavior unknownObjectBehavior) {
         checkLocked();
         if (unknownObjectBehavior == null) {
             throw new IllegalArgumentException("Unknown object behavior must not be null");
@@ -179,9 +179,9 @@ public class FixedOrderComparator<T> imp
      *  it was already known to the Comparator.
      * @throws UnsupportedOperationException if a comparison has already been made
      */
-    public boolean add(T obj) {
+    public boolean add(final T obj) {
         checkLocked();
-        Integer position = map.put(obj, new Integer(counter++));
+        final Integer position = map.put(obj, new Integer(counter++));
         return position == null;
     }
 
@@ -198,13 +198,13 @@ public class FixedOrderComparator<T> imp
      *  Comparator's set of known objects.
      * @throws UnsupportedOperationException if a comparison has already been made
      */
-    public boolean addAsEqual(T existingObj, T newObj) {
+    public boolean addAsEqual(final T existingObj, final T newObj) {
         checkLocked();
-        Integer position = map.get(existingObj);
+        final Integer position = map.get(existingObj);
         if (position == null) {
             throw new IllegalArgumentException(existingObj + " not known to " + this);
         }
-        Integer result = map.put(newObj, position);
+        final Integer result = map.put(newObj, position);
         return result == null;
     }
 
@@ -224,10 +224,10 @@ public class FixedOrderComparator<T> imp
      *  to this Comparator and an alternative behavior has not been set
      *  via {@link #setUnknownObjectBehavior(UnknownObjectBehavior)}.
      */
-    public int compare(T obj1, T obj2) {
+    public int compare(final T obj1, final T obj2) {
         isLocked = true;
-        Integer position1 = map.get(obj1);
-        Integer position2 = map.get(obj2);
+        final Integer position1 = map.get(obj1);
+        final Integer position2 = map.get(obj2);
         if (position1 == null || position2 == null) {
             switch (unknownObjectBehavior) {
             case BEFORE:
@@ -235,7 +235,7 @@ public class FixedOrderComparator<T> imp
             case AFTER:
                 return position1 == null ? position2 == null ? 0 : 1 : -1;
             case EXCEPTION:
-                Object unknownObj = position1 == null ? obj1 : obj2;
+                final Object unknownObj = position1 == null ? obj1 : obj2;
                 throw new IllegalArgumentException("Attempting to compare unknown object "
                         + unknownObj);
             default: //could be null
@@ -276,7 +276,7 @@ public class FixedOrderComparator<T> imp
      * @return true if equal
      */
     @Override
-    public boolean equals(Object object) {
+    public boolean equals(final Object object) {
         if (this == object) {
             return true;
         }
@@ -284,7 +284,7 @@ public class FixedOrderComparator<T> imp
             return false;
         }
         if (object.getClass().equals(this.getClass())) {
-            FixedOrderComparator<?> comp = (FixedOrderComparator<?>) object;
+            final FixedOrderComparator<?> comp = (FixedOrderComparator<?>) object;
             return null == map ? null == comp.map : map.equals(comp.map) &&
                     null == unknownObjectBehavior ? null == comp.unknownObjectBehavior :
                         unknownObjectBehavior == comp.unknownObjectBehavior &&

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/NullComparator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/NullComparator.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/NullComparator.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/NullComparator.java Mon Jan  7 17:15:14 2013
@@ -69,7 +69,7 @@ public class NullComparator<E> implement
      *  @exception NullPointerException if <code>nonNullComparator</code> is
      *  <code>null</code>
      **/
-    public NullComparator(Comparator<E> nonNullComparator) {
+    public NullComparator(final Comparator<E> nonNullComparator) {
         this(nonNullComparator, true);
     }
 
@@ -86,7 +86,7 @@ public class NullComparator<E> implement
      *  non-<code>null</code> object.
      **/
     @SuppressWarnings("unchecked")
-    public NullComparator(boolean nullsAreHigh) {
+    public NullComparator(final boolean nullsAreHigh) {
         this(ComparatorUtils.NATURAL_COMPARATOR, nullsAreHigh);
     }
     
@@ -109,7 +109,7 @@ public class NullComparator<E> implement
      *  @exception NullPointerException if <code>nonNullComparator</code> is
      *  <code>null</code>
      **/
-    public NullComparator(Comparator<E> nonNullComparator, boolean nullsAreHigh) {
+    public NullComparator(final Comparator<E> nonNullComparator, final boolean nullsAreHigh) {
         this.nonNullComparator = nonNullComparator;
         this.nullsAreHigh = nullsAreHigh;
         
@@ -135,7 +135,7 @@ public class NullComparator<E> implement
      *  "higher" than (greater than, after, etc.) <code>o2</code>; or
      *  <code>0</code> if <code>o1</code> and <code>o2</code> are equal.
      **/
-    public int compare(E o1, E o2) {
+    public int compare(final E o1, final E o2) {
         if(o1 == o2) { return 0; }
         if(o1 == null) { return this.nullsAreHigh ? 1 : -1; }
         if(o2 == null) { return this.nullsAreHigh ? -1 : 1; }
@@ -166,12 +166,12 @@ public class NullComparator<E> implement
      *  non-<code>null</code> object comparators.
      **/
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if(obj == null) { return false; }
         if(obj == this) { return true; }
         if(!obj.getClass().equals(this.getClass())) { return false; }
 
-        NullComparator<?> other = (NullComparator<?>) obj;
+        final NullComparator<?> other = (NullComparator<?>) obj;
 
         return this.nullsAreHigh == other.nullsAreHigh &&
                 this.nonNullComparator.equals(other.nonNullComparator);

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ReverseComparator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ReverseComparator.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ReverseComparator.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/ReverseComparator.java Mon Jan  7 17:15:14 2013
@@ -61,7 +61,7 @@ public class ReverseComparator<E> implem
      * @param comparator Comparator to reverse
      */
     @SuppressWarnings("unchecked")
-    public ReverseComparator(Comparator<E> comparator) {
+    public ReverseComparator(final Comparator<E> comparator) {
         this.comparator = comparator == null ? ComparatorUtils.NATURAL_COMPARATOR : comparator;
     }
 
@@ -73,7 +73,7 @@ public class ReverseComparator<E> implem
      * @param obj2  the second object to compare
      * @return negative if obj1 is less, positive if greater, zero if equal
      */
-    public int compare(E obj1, E obj2) {
+    public int compare(final E obj1, final E obj2) {
         return comparator.compare(obj2, obj1);
     }
 
@@ -107,7 +107,7 @@ public class ReverseComparator<E> implem
      * @since 3.0
      */
     @Override
-    public boolean equals(Object object) {
+    public boolean equals(final Object object) {
         if (this == object) {
             return true;
         }
@@ -115,7 +115,7 @@ public class ReverseComparator<E> implem
             return false;
         }
         if (object.getClass().equals(this.getClass())) {
-            ReverseComparator<?> thatrc = (ReverseComparator<?>) object;
+            final ReverseComparator<?> thatrc = (ReverseComparator<?>) object;
             return comparator.equals(thatrc.comparator);
         }
         return false;

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/TransformingComparator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/TransformingComparator.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/TransformingComparator.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/TransformingComparator.java Mon Jan  7 17:15:14 2013
@@ -53,7 +53,7 @@ public class TransformingComparator<E> i
      * @param transformer what will transform the arguments to <code>compare</code>
      */
     @SuppressWarnings("unchecked")
-    public TransformingComparator(Transformer<? super E, ? extends E> transformer) {
+    public TransformingComparator(final Transformer<? super E, ? extends E> transformer) {
         this(transformer, ComparatorUtils.NATURAL_COMPARATOR);
     }
 
@@ -63,7 +63,7 @@ public class TransformingComparator<E> i
      * @param transformer  what will transform the arguments to <code>compare</code>
      * @param decorated  the decorated Comparator
      */
-    public TransformingComparator(Transformer<? super E, ? extends E> transformer, Comparator<E> decorated) {
+    public TransformingComparator(final Transformer<? super E, ? extends E> transformer, final Comparator<E> decorated) {
         this.decorated = decorated;
         this.transformer = transformer;
     }
@@ -76,9 +76,9 @@ public class TransformingComparator<E> i
      * @param obj2  the second object to transform then compare
      * @return negative if obj1 is less, positive if greater, zero if equal
      */
-    public int compare(E obj1, E obj2) {
-        E value1 = this.transformer.transform(obj1);
-        E value2 = this.transformer.transform(obj2);
+    public int compare(final E obj1, final E obj2) {
+        final E value1 = this.transformer.transform(obj1);
+        final E value2 = this.transformer.transform(obj2);
         return this.decorated.compare(value1, value2);
     }
 
@@ -110,7 +110,7 @@ public class TransformingComparator<E> i
      * @return true if equal
      */
     @Override
-    public boolean equals(Object object) {
+    public boolean equals(final Object object) {
         if (this == object) {
             return true;
         }
@@ -118,7 +118,7 @@ public class TransformingComparator<E> i
             return false;
         }
         if (object.getClass().equals(this.getClass())) {
-            TransformingComparator<?> comp = (TransformingComparator<?>) object;
+            final TransformingComparator<?> comp = (TransformingComparator<?>) object;
             return null == decorated ? null == comp.decorated : decorated.equals(comp.decorated) &&
                     null == transformer ? null == comp.transformer : transformer.equals(comp.transformer);
         }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/DeleteCommand.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/DeleteCommand.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/DeleteCommand.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/DeleteCommand.java Mon Jan  7 17:15:14 2013
@@ -38,7 +38,7 @@ public class DeleteCommand<T> extends Ed
      *
      * @param object  the object of the first sequence that should be deleted
      */
-    public DeleteCommand(T object) {
+    public DeleteCommand(final T object) {
         super(object);
     }
 
@@ -49,7 +49,7 @@ public class DeleteCommand<T> extends Ed
      * @param visitor  the visitor to be accepted
      */    
     @Override
-    public void accept(CommandVisitor<T> visitor) {
+    public void accept(final CommandVisitor<T> visitor) {
         visitor.visitDeleteCommand(object);
     }    
 }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditCommand.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditCommand.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditCommand.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditCommand.java Mon Jan  7 17:15:14 2013
@@ -53,7 +53,7 @@ public abstract class EditCommand<T> {
      * @param object  reference to the object associated with this command, this
      *   refers to an element of one of the sequences being compared
      */
-    protected EditCommand(T object) {
+    protected EditCommand(final T object) {
         this.object = object;
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditScript.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditScript.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditScript.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/EditScript.java Mon Jan  7 17:15:14 2013
@@ -46,7 +46,7 @@ import java.util.List;
 public class EditScript<T> {
 
     /** Container for the commands. */
-    private List<EditCommand<T>> commands;
+    private final List<EditCommand<T>> commands;
 
     /** Length of the longest common subsequence. */
     private int lcsLength;
@@ -68,7 +68,7 @@ public class EditScript<T> {
      * 
      * @param command  command to add
      */
-    public void append(KeepCommand<T> command) {
+    public void append(final KeepCommand<T> command) {
         commands.add(command);
         ++lcsLength;
     }
@@ -78,7 +78,7 @@ public class EditScript<T> {
      * 
      * @param command  command to add
      */
-    public void append(InsertCommand<T> command) {
+    public void append(final InsertCommand<T> command) {
         commands.add(command);
         ++modifications;
     }
@@ -88,7 +88,7 @@ public class EditScript<T> {
      * 
      * @param command  command to add
      */
-    public void append(DeleteCommand<T> command) {
+    public void append(final DeleteCommand<T> command) {
         commands.add(command);
         ++modifications;
     }
@@ -102,8 +102,8 @@ public class EditScript<T> {
      * 
      * @param visitor  the visitor that will visit all commands in turn
      */
-    public void visit(CommandVisitor<T> visitor) {
-        for (EditCommand<T> command : commands) {
+    public void visit(final CommandVisitor<T> visitor) {
+        for (final EditCommand<T> command : commands) {
             command.accept(visitor);
         }
     }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/InsertCommand.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/InsertCommand.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/InsertCommand.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/InsertCommand.java Mon Jan  7 17:15:14 2013
@@ -38,7 +38,7 @@ public class InsertCommand<T> extends Ed
      * 
      * @param object  the object of the second sequence that should be inserted
      */
-    public InsertCommand(T object) {
+    public InsertCommand(final T object) {
         super(object);
     }
 
@@ -50,7 +50,7 @@ public class InsertCommand<T> extends Ed
      * @param visitor  the visitor to be accepted
      */
     @Override
-    public void accept(CommandVisitor<T> visitor) {
+    public void accept(final CommandVisitor<T> visitor) {
         visitor.visitInsertCommand(object);
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/KeepCommand.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/KeepCommand.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/KeepCommand.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/KeepCommand.java Mon Jan  7 17:15:14 2013
@@ -40,7 +40,7 @@ public class KeepCommand<T> extends Edit
      *   reference to the instance in the first sequence which is known
      *   to be equal to an instance in the second sequence)
      */
-    public KeepCommand(T object) {
+    public KeepCommand(final T object) {
         super(object);
     }
 
@@ -51,7 +51,7 @@ public class KeepCommand<T> extends Edit
      * @param visitor  the visitor to be accepted
      */
     @Override
-    public void accept(CommandVisitor<T> visitor) {
+    public void accept(final CommandVisitor<T> visitor) {
         visitor.visitKeepCommand(object);
     }
 }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/ReplacementsFinder.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/ReplacementsFinder.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/ReplacementsFinder.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/ReplacementsFinder.java Mon Jan  7 17:15:14 2013
@@ -50,19 +50,19 @@ import java.util.List;
  */
 public class ReplacementsFinder<T> implements CommandVisitor<T> {
 
-    private List<T> pendingInsertions;
-    private List<T> pendingDeletions;
+    private final List<T> pendingInsertions;
+    private final List<T> pendingDeletions;
     private int     skipped;
 
     /** Handler to call when synchronized sequences are found. */
-    private ReplacementsHandler<T> handler;
+    private final ReplacementsHandler<T> handler;
 
     /**
      * Simple constructor. Creates a new instance of {@link ReplacementsFinder}.
      *
      * @param handler  handler to call when synchronized sequences are found
      */
-    public ReplacementsFinder(ReplacementsHandler<T> handler) {
+    public ReplacementsFinder(final ReplacementsHandler<T> handler) {
         pendingInsertions = new ArrayList<T>();
         pendingDeletions  = new ArrayList<T>();
         skipped           = 0;
@@ -74,7 +74,7 @@ public class ReplacementsFinder<T> imple
      *
      * @param object  object to insert
      */
-    public void visitInsertCommand(T object) {
+    public void visitInsertCommand(final T object) {
         pendingInsertions.add(object);
     }
 
@@ -86,7 +86,7 @@ public class ReplacementsFinder<T> imple
      *
      * @param object  synchronization object detected
      */
-    public void visitKeepCommand(T object) {
+    public void visitKeepCommand(final T object) {
         if (pendingDeletions.isEmpty() && pendingInsertions.isEmpty()) {
             ++skipped;
         } else {
@@ -102,7 +102,7 @@ public class ReplacementsFinder<T> imple
      *
      * @param object  object to delete
      */
-    public void visitDeleteCommand(T object) {
+    public void visitDeleteCommand(final T object) {
         pendingDeletions.add(object);
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/SequencesComparator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/SequencesComparator.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/SequencesComparator.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/SequencesComparator.java Mon Jan  7 17:15:14 2013
@@ -56,14 +56,14 @@ import java.util.List;
 public class SequencesComparator<T> {
 
     /** First sequence. */
-    private List<T> sequence1;
+    private final List<T> sequence1;
 
     /** Second sequence. */
-    private List<T> sequence2;
+    private final List<T> sequence2;
 
     /** Temporary variables. */
-    private int[] vDown;
-    private int[] vUp;
+    private final int[] vDown;
+    private final int[] vUp;
 
     /**
      * Simple constructor.
@@ -81,11 +81,11 @@ public class SequencesComparator<T> {
      * @param sequence2
      *            second sequence to be compared
      */
-    public SequencesComparator(List<T> sequence1, List<T> sequence2) {
+    public SequencesComparator(final List<T> sequence1, final List<T> sequence2) {
         this.sequence1 = sequence1;
         this.sequence2 = sequence2;
 
-        int size = sequence1.size() + sequence2.size() + 2;
+        final int size = sequence1.size() + sequence2.size() + 2;
         vDown = new int[size];
         vUp   = new int[size];
     }
@@ -99,7 +99,7 @@ public class SequencesComparator<T> {
      * @param end2  the value of the end of the second sequence to be compared
      * @return the snake built
      */
-    private Snake buildSnake(int start, int diag, int end1, int end2) {
+    private Snake buildSnake(final int start, final int diag, final int end1, final int end2) {
         int end = start;
         while (end - diag < end2
                 && end < end1
@@ -125,18 +125,18 @@ public class SequencesComparator<T> {
      * @param end2  the end of the second sequence to be compared
      * @return the middle snake
      */
-    private Snake getMiddleSnake(int start1, int end1, int start2, int end2) {
+    private Snake getMiddleSnake(final int start1, final int end1, final int start2, final int end2) {
         // Myers Algorithm
         // Initialisations
-        int m = end1 - start1;
-        int n = end2 - start2;
+        final int m = end1 - start1;
+        final int n = end2 - start2;
         if (m == 0 || n == 0) {
             return null;
         }
 
-        int delta  = m - n;
-        int sum    = n + m;
-        int offset = (sum % 2 == 0 ? sum : sum + 1) / 2;
+        final int delta  = m - n;
+        final int sum    = n + m;
+        final int offset = (sum % 2 == 0 ? sum : sum + 1) / 2;
         vDown[1+offset] = start1;
         vUp[1+offset]   = end1 + 1;
 
@@ -145,7 +145,7 @@ public class SequencesComparator<T> {
             for (int k = -d; k <= d; k += 2) {
                 // First step
 
-                int i = k + offset;
+                final int i = k + offset;
                 if (k == -d || k != d && vDown[i-1] < vDown[i+1]) {
                     vDown[i] = vDown[i+1];
                 } else {
@@ -170,7 +170,7 @@ public class SequencesComparator<T> {
             // Up
             for (int k = delta - d; k <= delta + d; k += 2) {
                 // First step
-                int i = k + offset - delta;
+                final int i = k + offset - delta;
                 if (k == delta - d
                         || k != delta + d && vUp[i+1] <= vUp[i-1]) {
                     vUp[i] = vUp[i+1] - 1;
@@ -208,10 +208,10 @@ public class SequencesComparator<T> {
      * @param end2  the end of the second sequence to be compared
      * @param script the edited script
      */
-    private void buildScript(int start1, int end1, int start2, int end2,
-                             EditScript<T> script) {
+    private void buildScript(final int start1, final int end1, final int start2, final int end2,
+                             final EditScript<T> script) {
 
-        Snake middle = getMiddleSnake(start1, end1, start2, end2);
+        final Snake middle = getMiddleSnake(start1, end1, start2, end2);
 
         if (middle == null
                 || middle.getStart() == end1 && middle.getDiag() == end1 - end2
@@ -263,7 +263,7 @@ public class SequencesComparator<T> {
      *         sequences
      */
     public EditScript<T> getScript() {
-        EditScript<T> script = new EditScript<T>();
+        final EditScript<T> script = new EditScript<T>();
         buildScript(0, sequence1.size(), 0, sequence2.size(), script);
         return script;
     }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/Snake.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/Snake.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/Snake.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/comparators/sequence/Snake.java Mon Jan  7 17:15:14 2013
@@ -30,13 +30,13 @@ package org.apache.commons.collections.c
 public class Snake {
 
     /** Start index. */
-    private int start;
+    private final int start;
 
     /** End index. */
-    private int end;
+    private final int end;
 
     /** Diagonal number. */
-    private int diag;
+    private final int diag;
 
     /**
      * Simple constructor. Creates a new instance of Snake with default indices.
@@ -54,7 +54,7 @@ public class Snake {
      * @param end  end index of the snake
      * @param diag  diagonal number
      */ 
-    public Snake(int start, int end, int diag) {
+    public Snake(final int start, final int end, final int diag) {
         this.start = start;
         this.end   = end;
         this.diag  = diag;

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AllPredicate.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AllPredicate.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AllPredicate.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AllPredicate.java Mon Jan  7 17:15:14 2013
@@ -56,7 +56,7 @@ public final class AllPredicate<T> imple
      * @throws IllegalArgumentException if the predicates array is null
      * @throws IllegalArgumentException if any predicate in the array is null
      */
-    public static <T> Predicate<T> allPredicate(Predicate<? super T> ... predicates) {
+    public static <T> Predicate<T> allPredicate(final Predicate<? super T> ... predicates) {
         FunctorUtils.validate(predicates);
         if (predicates.length == 0) {
             return truePredicate();
@@ -80,7 +80,7 @@ public final class AllPredicate<T> imple
      * @throws IllegalArgumentException if the predicates array is null
      * @throws IllegalArgumentException if any predicate in the array is null
      */
-    public static <T> Predicate<T> allPredicate(Collection<? extends Predicate<T>> predicates) {
+    public static <T> Predicate<T> allPredicate(final Collection<? extends Predicate<T>> predicates) {
         final Predicate<T>[] preds = validate(predicates);
         if (preds.length == 0) {
             return truePredicate();
@@ -97,7 +97,7 @@ public final class AllPredicate<T> imple
      *
      * @param predicates  the predicates to check, not cloned, not null
      */
-    public AllPredicate(Predicate<? super T> ... predicates) {
+    public AllPredicate(final Predicate<? super T> ... predicates) {
         super();
         iPredicates = predicates;
     }
@@ -108,8 +108,8 @@ public final class AllPredicate<T> imple
      * @param object  the input object
      * @return true if all decorated predicates return true
      */
-    public boolean evaluate(T object) {
-        for (Predicate<? super T> iPredicate : iPredicates) {
+    public boolean evaluate(final T object) {
+        for (final Predicate<? super T> iPredicate : iPredicates) {
             if (!iPredicate.evaluate(object)) {
                 return false;
             }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AndPredicate.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AndPredicate.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AndPredicate.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AndPredicate.java Mon Jan  7 17:15:14 2013
@@ -45,7 +45,7 @@ public final class AndPredicate<T> imple
      * @return the <code>and</code> predicate
      * @throws IllegalArgumentException if either predicate is null
      */
-    public static <T> Predicate<T> andPredicate(Predicate<? super T> predicate1, Predicate<? super T> predicate2) {
+    public static <T> Predicate<T> andPredicate(final Predicate<? super T> predicate1, final Predicate<? super T> predicate2) {
         if (predicate1 == null || predicate2 == null) {
             throw new IllegalArgumentException("Predicate must not be null");
         }
@@ -59,7 +59,7 @@ public final class AndPredicate<T> imple
      * @param predicate1  the first predicate to check, not null
      * @param predicate2  the second predicate to check, not null
      */
-    public AndPredicate(Predicate<? super T> predicate1, Predicate<? super T> predicate2) {
+    public AndPredicate(final Predicate<? super T> predicate1, final Predicate<? super T> predicate2) {
         super();
         iPredicate1 = predicate1;
         iPredicate2 = predicate2;
@@ -71,7 +71,7 @@ public final class AndPredicate<T> imple
      * @param object  the input object
      * @return true if both decorated predicates return true
      */
-    public boolean evaluate(T object) {
+    public boolean evaluate(final T object) {
        return iPredicate1.evaluate(object) && iPredicate2.evaluate(object);
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AnyPredicate.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AnyPredicate.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AnyPredicate.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/AnyPredicate.java Mon Jan  7 17:15:14 2013
@@ -53,7 +53,7 @@ public final class AnyPredicate<T> imple
      * @throws IllegalArgumentException if any predicate in the array is null
      */
     @SuppressWarnings("unchecked")
-    public static <T> Predicate<T> anyPredicate(Predicate<? super T>... predicates) {
+    public static <T> Predicate<T> anyPredicate(final Predicate<? super T>... predicates) {
         FunctorUtils.validate(predicates);
         if (predicates.length == 0) {
             return FalsePredicate.<T>falsePredicate();
@@ -77,8 +77,8 @@ public final class AnyPredicate<T> imple
      * @throws IllegalArgumentException if any predicate in the array is null
      */
     @SuppressWarnings("unchecked")
-    public static <T> Predicate<T> anyPredicate(Collection<? extends Predicate<T>> predicates) {
-        Predicate<? super T>[] preds = FunctorUtils.validate(predicates);
+    public static <T> Predicate<T> anyPredicate(final Collection<? extends Predicate<T>> predicates) {
+        final Predicate<? super T>[] preds = FunctorUtils.validate(predicates);
         if (preds.length == 0) {
             return FalsePredicate.<T>falsePredicate();
         }
@@ -94,7 +94,7 @@ public final class AnyPredicate<T> imple
      *
      * @param predicates  the predicates to check, not cloned, not null
      */
-    public AnyPredicate(Predicate<? super T>[] predicates) {
+    public AnyPredicate(final Predicate<? super T>[] predicates) {
         super();
         iPredicates = predicates;
     }
@@ -105,8 +105,8 @@ public final class AnyPredicate<T> imple
      * @param object  the input object
      * @return true if any decorated predicate return true
      */
-    public boolean evaluate(T object) {
-        for (Predicate<? super T> iPredicate : iPredicates) {
+    public boolean evaluate(final T object) {
+        for (final Predicate<? super T> iPredicate : iPredicates) {
             if (iPredicate.evaluate(object)) {
                 return true;
             }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CatchAndRethrowClosure.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CatchAndRethrowClosure.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CatchAndRethrowClosure.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CatchAndRethrowClosure.java Mon Jan  7 17:15:14 2013
@@ -55,12 +55,12 @@ public abstract class CatchAndRethrowClo
      * @throws FunctorException (runtime) if the closure execution resulted in a
      *             checked exception.
      */
-    public void execute(E input) {
+    public void execute(final E input) {
         try {
             executeAndThrow(input);
-        } catch (RuntimeException ex) {
+        } catch (final RuntimeException ex) {
             throw ex;
-        } catch (Throwable t) {
+        } catch (final Throwable t) {
             throw new FunctorException(t);
         }
     }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedClosure.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedClosure.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedClosure.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedClosure.java Mon Jan  7 17:15:14 2013
@@ -44,7 +44,7 @@ public class ChainedClosure<E> implement
      * @throws IllegalArgumentException if the closures array is null
      * @throws IllegalArgumentException if any closure in the array is null
      */
-    public static <E> Closure<E> chainedClosure(Closure<? super E>... closures) {
+    public static <E> Closure<E> chainedClosure(final Closure<? super E>... closures) {
         FunctorUtils.validate(closures);
         if (closures.length == 0) {
             return NOPClosure.<E>nopClosure();
@@ -64,7 +64,7 @@ public class ChainedClosure<E> implement
      * @throws IllegalArgumentException if any closure in the collection is null
      */
     @SuppressWarnings("unchecked")
-    public static <E> Closure<E> chainedClosure(Collection<Closure<E>> closures) {
+    public static <E> Closure<E> chainedClosure(final Collection<Closure<E>> closures) {
         if (closures == null) {
             throw new IllegalArgumentException("Closure collection must not be null");
         }
@@ -72,9 +72,9 @@ public class ChainedClosure<E> implement
             return NOPClosure.<E>nopClosure();
         }
         // convert to array like this to guarantee iterator() ordering
-        Closure<? super E>[] cmds = new Closure[closures.size()];
+        final Closure<? super E>[] cmds = new Closure[closures.size()];
         int i = 0;
-        for (Closure<? super E> closure : closures) {
+        for (final Closure<? super E> closure : closures) {
             cmds[i++] = closure;
         }
         FunctorUtils.validate(cmds);
@@ -87,7 +87,7 @@ public class ChainedClosure<E> implement
      * 
      * @param closures  the closures to chain, not copied, no nulls
      */
-    public ChainedClosure(Closure<? super E>[] closures) {
+    public ChainedClosure(final Closure<? super E>[] closures) {
         super();
         iClosures = closures;
     }
@@ -97,8 +97,8 @@ public class ChainedClosure<E> implement
      * 
      * @param input  the input object passed to each closure
      */
-    public void execute(E input) {
-        for (Closure<? super E> iClosure : iClosures) {
+    public void execute(final E input) {
+        for (final Closure<? super E> iClosure : iClosures) {
             iClosure.execute(input);
         }
     }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedTransformer.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedTransformer.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedTransformer.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ChainedTransformer.java Mon Jan  7 17:15:14 2013
@@ -46,7 +46,7 @@ public class ChainedTransformer<T> imple
      * @throws IllegalArgumentException if the transformers array is null
      * @throws IllegalArgumentException if any transformer in the array is null
      */
-    public static <T> Transformer<T, T> chainedTransformer(Transformer<? super T, ? extends T>... transformers) {
+    public static <T> Transformer<T, T> chainedTransformer(final Transformer<? super T, ? extends T>... transformers) {
         FunctorUtils.validate(transformers);
         if (transformers.length == 0) {
             return NOPTransformer.<T>nopTransformer();
@@ -65,7 +65,7 @@ public class ChainedTransformer<T> imple
      * @throws IllegalArgumentException if any transformer in the collection is null
      */
     @SuppressWarnings("unchecked")
-    public static <T> Transformer<T, T> chainedTransformer(Collection<? extends Transformer<T, T>> transformers) {
+    public static <T> Transformer<T, T> chainedTransformer(final Collection<? extends Transformer<T, T>> transformers) {
         if (transformers == null) {
             throw new IllegalArgumentException("Transformer collection must not be null");
         }
@@ -73,7 +73,7 @@ public class ChainedTransformer<T> imple
             return NOPTransformer.<T>nopTransformer();
         }
         // convert to array like this to guarantee iterator() ordering
-        Transformer<T, T>[] cmds = transformers.toArray(new Transformer[transformers.size()]);
+        final Transformer<T, T>[] cmds = transformers.toArray(new Transformer[transformers.size()]);
         FunctorUtils.validate(cmds);
         return new ChainedTransformer<T>(cmds);
     }
@@ -84,7 +84,7 @@ public class ChainedTransformer<T> imple
      * 
      * @param transformers  the transformers to chain, not copied, no nulls
      */
-    public ChainedTransformer(Transformer<? super T, ? extends T>[] transformers) {
+    public ChainedTransformer(final Transformer<? super T, ? extends T>[] transformers) {
         super();
         iTransformers = transformers;
     }
@@ -96,7 +96,7 @@ public class ChainedTransformer<T> imple
      * @return the transformed result
      */
     public T transform(T object) {
-        for (Transformer<? super T, ? extends T> iTransformer : iTransformers) {
+        for (final Transformer<? super T, ? extends T> iTransformer : iTransformers) {
             object = iTransformer.transform(object);
         }
         return object;

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CloneTransformer.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CloneTransformer.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CloneTransformer.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/CloneTransformer.java Mon Jan  7 17:15:14 2013
@@ -60,7 +60,7 @@ public class CloneTransformer<T> impleme
      * @param input  the input object to transform
      * @return the transformed result
      */
-    public T transform(T input) {
+    public T transform(final T input) {
         if (input == null) {
             return null;
         }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ClosureTransformer.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ClosureTransformer.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ClosureTransformer.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ClosureTransformer.java Mon Jan  7 17:15:14 2013
@@ -43,7 +43,7 @@ public class ClosureTransformer<T> imple
      * @return the <code>closure</code> transformer
      * @throws IllegalArgumentException if the closure is null
      */
-    public static <T> Transformer<T, T> closureTransformer(Closure<? super T> closure) {
+    public static <T> Transformer<T, T> closureTransformer(final Closure<? super T> closure) {
         if (closure == null) {
             throw new IllegalArgumentException("Closure must not be null");
         }
@@ -56,7 +56,7 @@ public class ClosureTransformer<T> imple
      * 
      * @param closure  the closure to call, not null
      */
-    public ClosureTransformer(Closure<? super T> closure) {
+    public ClosureTransformer(final Closure<? super T> closure) {
         super();
         iClosure = closure;
     }
@@ -67,7 +67,7 @@ public class ClosureTransformer<T> imple
      * @param input  the input object to transform
      * @return the transformed result
      */
-    public T transform(T input) {
+    public T transform(final T input) {
         iClosure.execute(input);
         return input;
     }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ComparatorPredicate.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ComparatorPredicate.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ComparatorPredicate.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ComparatorPredicate.java Mon Jan  7 17:15:14 2013
@@ -104,7 +104,7 @@ public class ComparatorPredicate<T> impl
      * @return the predicate
      * @throws IllegalArgumentException if comparator is null
      */
-    public static <T> Predicate<T> comparatorPredicate(T object, Comparator<T> comparator) {
+    public static <T> Predicate<T> comparatorPredicate(final T object, final Comparator<T> comparator) {
         return comparatorPredicate(object, comparator, Criterion.EQUAL);
     }
 
@@ -118,7 +118,7 @@ public class ComparatorPredicate<T> impl
      * @return the predicate
      * @throws IllegalArgumentException if comparator is null of criterion is invalid
      */
-    public static <T> Predicate<T> comparatorPredicate(T object, Comparator<T> comparator, Criterion criterion) {
+    public static <T> Predicate<T> comparatorPredicate(final T object, final Comparator<T> comparator, final Criterion criterion) {
         if (comparator == null) {
             throw new IllegalArgumentException("Comparator must not be null.");
         }
@@ -136,7 +136,7 @@ public class ComparatorPredicate<T> impl
      * @param comparator  the comparator to use for comparison
      * @param criterion  the criterion to use to evaluate comparison
      */
-    public ComparatorPredicate(T object, Comparator<T> comparator, Criterion criterion) {
+    public ComparatorPredicate(final T object, final Comparator<T> comparator, final Criterion criterion) {
         super();
         this.object = object;
         this.comparator = comparator;
@@ -159,10 +159,10 @@ public class ComparatorPredicate<T> impl
      * 
      * @throws IllegalStateException if the criterion is invalid (really not possible)
      */
-    public boolean evaluate(T target) {
+    public boolean evaluate(final T target) {
 
         boolean result = false;
-        int comparison = comparator.compare(object, target);
+        final int comparison = comparator.compare(object, target);
         switch (criterion) {
         case EQUAL:
             result = comparison == 0;

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantFactory.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantFactory.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantFactory.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantFactory.java Mon Jan  7 17:15:14 2013
@@ -48,7 +48,7 @@ public class ConstantFactory<T> implemen
      * @return the <code>constant</code> factory.
      */
     @SuppressWarnings("unchecked")
-    public static <T> Factory<T> constantFactory(T constantToReturn) {
+    public static <T> Factory<T> constantFactory(final T constantToReturn) {
         if (constantToReturn == null) {
             return (Factory<T>) NULL_INSTANCE;
         }
@@ -61,7 +61,7 @@ public class ConstantFactory<T> implemen
      * 
      * @param constantToReturn  the constant to return each time
      */
-    public ConstantFactory(T constantToReturn) {
+    public ConstantFactory(final T constantToReturn) {
         super();
         iConstant = constantToReturn;
     }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantTransformer.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantTransformer.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantTransformer.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ConstantTransformer.java Mon Jan  7 17:15:14 2013
@@ -58,7 +58,7 @@ public class ConstantTransformer<I, O> i
      * @param constantToReturn  the constant object to return each time in the factory
      * @return the <code>constant</code> factory.
      */
-    public static <I, O> Transformer<I, O> constantTransformer(O constantToReturn) {
+    public static <I, O> Transformer<I, O> constantTransformer(final O constantToReturn) {
         if (constantToReturn == null) {
             return nullTransformer();
         }
@@ -71,7 +71,7 @@ public class ConstantTransformer<I, O> i
      * 
      * @param constantToReturn  the constant to return each time
      */
-    public ConstantTransformer(O constantToReturn) {
+    public ConstantTransformer(final O constantToReturn) {
         super();
         iConstant = constantToReturn;
     }
@@ -82,7 +82,7 @@ public class ConstantTransformer<I, O> i
      * @param input  the input object which is ignored
      * @return the stored constant
      */
-    public O transform(I input) {
+    public O transform(final I input) {
         return iConstant;
     }
 
@@ -100,14 +100,14 @@ public class ConstantTransformer<I, O> i
      * {@inheritDoc}
      */
     @Override
-    public boolean equals(Object obj) {
+    public boolean equals(final Object obj) {
         if (obj == this) {
             return true;
         }
         if (obj instanceof ConstantTransformer == false) {
             return false;
         }
-        Object otherConstant = ((ConstantTransformer<?, ?>) obj).getConstant();
+        final Object otherConstant = ((ConstantTransformer<?, ?>) obj).getConstant();
         return otherConstant == getConstant() || otherConstant != null && otherConstant.equals(getConstant());
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/DefaultEquator.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/DefaultEquator.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/DefaultEquator.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/DefaultEquator.java Mon Jan  7 17:15:14 2013
@@ -35,7 +35,7 @@ public class DefaultEquator<T> implement
     /**
      * {@inheritDoc} Delegates to {@link Object#equals(Object)}.
      */
-    public boolean equate(T o1, T o2) {
+    public boolean equate(final T o1, final T o2) {
         return o1 == o2 || o1 != null && o1.equals(o2);
     }
 
@@ -45,7 +45,7 @@ public class DefaultEquator<T> implement
      * @return <code>o.hashCode()</code> if <code>o</code> is non-
      *         <code>null</code>, else {@link #HASHCODE_NULL}.
      */
-    public int hash(T o) {
+    public int hash(final T o) {
         return o == null ? HASHCODE_NULL : o.hashCode();
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/EqualPredicate.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/EqualPredicate.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/EqualPredicate.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/EqualPredicate.java Mon Jan  7 17:15:14 2013
@@ -48,7 +48,7 @@ public final class EqualPredicate<T> imp
      * @return the predicate
      * @throws IllegalArgumentException if the predicate is null
      */
-    public static <T> Predicate<T> equalPredicate(T object) {
+    public static <T> Predicate<T> equalPredicate(final T object) {
         if (object == null) {
             return nullPredicate();
         }
@@ -65,7 +65,7 @@ public final class EqualPredicate<T> imp
      * @throws IllegalArgumentException if the predicate is null
      * @since 4.0
      */
-    public static <T> Predicate<T> equalPredicate(T object, Equator<T> equator) {
+    public static <T> Predicate<T> equalPredicate(final T object, final Equator<T> equator) {
         if (object == null) {
             return nullPredicate();
         }
@@ -78,7 +78,7 @@ public final class EqualPredicate<T> imp
      * 
      * @param object  the object to compare to
      */
-    public EqualPredicate(T object) {
+    public EqualPredicate(final T object) {
         // do not use the DefaultEquator to keep backwards compatibility
         // the DefaultEquator returns also true if the two object references are equal
         this(object, null);
@@ -92,7 +92,7 @@ public final class EqualPredicate<T> imp
      * @param equator  the equator to use for comparison
      * @since 4.0
      */
-    public EqualPredicate(T object, Equator<T> equator) {
+    public EqualPredicate(final T object, final Equator<T> equator) {
         super();
         iValue = object;
         this.equator = equator;
@@ -104,7 +104,7 @@ public final class EqualPredicate<T> imp
      * @param object  the input object
      * @return true if input object equals stored value
      */
-    public boolean evaluate(T object) {
+    public boolean evaluate(final T object) {
         if (equator != null) {
             return equator.equate(iValue, object);
         } else {

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionClosure.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionClosure.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionClosure.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionClosure.java Mon Jan  7 17:15:14 2013
@@ -60,7 +60,7 @@ public final class ExceptionClosure<E> i
      * @param input  the input object
      * @throws FunctorException always
      */
-    public void execute(E input) {
+    public void execute(final E input) {
         throw new FunctorException("ExceptionClosure invoked");
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionPredicate.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionPredicate.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionPredicate.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionPredicate.java Mon Jan  7 17:15:14 2013
@@ -60,7 +60,7 @@ public final class ExceptionPredicate<T>
      * @return never
      * @throws FunctorException always
      */
-    public boolean evaluate(T object) {
+    public boolean evaluate(final T object) {
         throw new FunctorException("ExceptionPredicate invoked");
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionTransformer.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionTransformer.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionTransformer.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ExceptionTransformer.java Mon Jan  7 17:15:14 2013
@@ -60,7 +60,7 @@ public final class ExceptionTransformer<
      * @return never
      * @throws FunctorException always
      */
-    public O transform(I input) {
+    public O transform(final I input) {
         throw new FunctorException("ExceptionTransformer invoked");
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FactoryTransformer.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FactoryTransformer.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FactoryTransformer.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FactoryTransformer.java Mon Jan  7 17:15:14 2013
@@ -42,7 +42,7 @@ public class FactoryTransformer<I, O> im
      * @return the <code>factory</code> transformer
      * @throws IllegalArgumentException if the factory is null
      */
-    public static <I, O> Transformer<I, O> factoryTransformer(Factory<? extends O> factory) {
+    public static <I, O> Transformer<I, O> factoryTransformer(final Factory<? extends O> factory) {
         if (factory == null) {
             throw new IllegalArgumentException("Factory must not be null");
         }
@@ -55,7 +55,7 @@ public class FactoryTransformer<I, O> im
      * 
      * @param factory  the factory to call, not null
      */
-    public FactoryTransformer(Factory<? extends O> factory) {
+    public FactoryTransformer(final Factory<? extends O> factory) {
         super();
         iFactory = factory;
     }
@@ -67,7 +67,7 @@ public class FactoryTransformer<I, O> im
      * @param input  the input object to transform
      * @return the transformed result
      */
-    public O transform(I input) {
+    public O transform(final I input) {
         return iFactory.create();
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FalsePredicate.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FalsePredicate.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FalsePredicate.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/FalsePredicate.java Mon Jan  7 17:15:14 2013
@@ -59,7 +59,7 @@ public final class FalsePredicate<T> imp
      * @param object  the input object
      * @return false always
      */
-    public boolean evaluate(T object) {
+    public boolean evaluate(final T object) {
         return false;
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ForClosure.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ForClosure.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ForClosure.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/functors/ForClosure.java Mon Jan  7 17:15:14 2013
@@ -48,7 +48,7 @@ public class ForClosure<E> implements Cl
      * @return the <code>for</code> closure
      */
     @SuppressWarnings("unchecked")
-    public static <E> Closure<E> forClosure(int count, Closure<? super E> closure) {
+    public static <E> Closure<E> forClosure(final int count, final Closure<? super E> closure) {
         if (count <= 0 || closure == null) {
             return NOPClosure.<E>nopClosure();
         }
@@ -65,7 +65,7 @@ public class ForClosure<E> implements Cl
      * @param count  the number of times to execute the closure
      * @param closure  the closure to execute, not null
      */
-    public ForClosure(int count, Closure<? super E> closure) {
+    public ForClosure(final int count, final Closure<? super E> closure) {
         super();
         iCount = count;
         iClosure = closure;
@@ -76,7 +76,7 @@ public class ForClosure<E> implements Cl
      * 
      * @param input  the input object
      */
-    public void execute(E input) {
+    public void execute(final E input) {
         for (int i = 0; i < iCount; i++) {
             iClosure.execute(input);
         }



Mime
View raw message