commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1429905 [2/26] - in /commons/proper/collections/trunk/src: main/java/org/apache/commons/collections/ main/java/org/apache/commons/collections/bag/ main/java/org/apache/commons/collections/bidimap/ main/java/org/apache/commons/collections/b...
Date Mon, 07 Jan 2013 17:15:24 GMT
Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/CollectionUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/CollectionUtils.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/CollectionUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/CollectionUtils.java Mon Jan  7 17:15:14 2013
@@ -50,29 +50,29 @@ public class CollectionUtils {
     private static class CardinalityHelper<O> {
         final Map<O, Integer> cardinalityA, cardinalityB;
 
-        public CardinalityHelper(Iterable<? extends O> a, Iterable<? extends O> b) {
+        public CardinalityHelper(final Iterable<? extends O> a, final Iterable<? extends O> b) {
             cardinalityA = CollectionUtils.<O>getCardinalityMap(a);
             cardinalityB = CollectionUtils.<O>getCardinalityMap(b);
         }
 
-        public final int max(Object obj) {
+        public final int max(final Object obj) {
             return Math.max(freqA(obj), freqB(obj));
         }
 
-        public final int min(Object obj) {
+        public final int min(final Object obj) {
             return Math.min(freqA(obj), freqB(obj));
         }
 
-        public int freqA(Object obj) {
+        public int freqA(final Object obj) {
             return getFreq(obj, cardinalityA);
         }
 
-        public int freqB(Object obj) {
+        public int freqB(final Object obj) {
             return getFreq(obj, cardinalityB);
         }
 
         private final int getFreq(final Object obj, final Map<?, Integer> freqMap) {
-            Integer count = freqMap.get(obj);
+            final Integer count = freqMap.get(obj);
             if (count != null) {
                 return count.intValue();
             }
@@ -84,7 +84,7 @@ public class CollectionUtils {
         private final Set<O> elements;
         private final List<O> newList;
 
-        public SetOperationCardinalityHelper(Iterable<? extends O> a, Iterable<? extends O> b) {
+        public SetOperationCardinalityHelper(final Iterable<? extends O> a, final Iterable<? extends O> b) {
             super(a, b);
             elements = new HashSet<O>();
             addAll(elements, a);
@@ -96,7 +96,7 @@ public class CollectionUtils {
             return elements.iterator();
         }
 
-        public void setCardinality(O obj, int count) {
+        public void setCardinality(final O obj, final int count) {
             for (int i = 0; i < count; i++) {
                 newList.add(obj);
             }
@@ -146,7 +146,7 @@ public class CollectionUtils {
      * @return an empty collection if the argument is <code>null</code>
      */
     @SuppressWarnings("unchecked")
-    public static <T> Collection<T> emptyIfNull(Collection<T> collection) {
+    public static <T> Collection<T> emptyIfNull(final Collection<T> collection) {
         return collection == null ? EMPTY_COLLECTION : collection;
     }
 
@@ -166,8 +166,8 @@ public class CollectionUtils {
      * @see Collection#addAll
      */
     public static <O> Collection<O> union(final Iterable<? extends O> a, final Iterable<? extends O> b) {
-        SetOperationCardinalityHelper<O> helper = new SetOperationCardinalityHelper<O>(a, b);
-        for (O obj : helper) {
+        final SetOperationCardinalityHelper<O> helper = new SetOperationCardinalityHelper<O>(a, b);
+        for (final O obj : helper) {
             helper.setCardinality(obj, helper.max(obj));
         }
         return helper.list();
@@ -190,8 +190,8 @@ public class CollectionUtils {
      * @see #containsAny
      */
     public static <O> Collection<O> intersection(final Iterable<? extends O> a, final Iterable<? extends O> b) {
-        SetOperationCardinalityHelper<O> helper = new SetOperationCardinalityHelper<O>(a, b);
-        for (O obj : helper) {
+        final SetOperationCardinalityHelper<O> helper = new SetOperationCardinalityHelper<O>(a, b);
+        for (final O obj : helper) {
             helper.setCardinality(obj, helper.min(obj));
         }
         return helper.list();
@@ -218,8 +218,8 @@ public class CollectionUtils {
      * @return the symmetric difference of the two collections
      */
     public static <O> Collection<O> disjunction(final Iterable<? extends O> a, final Iterable<? extends O> b) {
-        SetOperationCardinalityHelper<O> helper = new SetOperationCardinalityHelper<O>(a, b);
-        for (O obj : helper) {
+        final SetOperationCardinalityHelper<O> helper = new SetOperationCardinalityHelper<O>(a, b);
+        for (final O obj : helper) {
             helper.setCardinality(obj, helper.max(obj) - helper.min(obj));
         }
         return helper.list();
@@ -239,7 +239,7 @@ public class CollectionUtils {
      * @see Collection#removeAll
      */
     public static <O> Collection<O> subtract(final Iterable<? extends O> a, final Iterable<? extends O> b) {
-        Predicate<O> p = TruePredicate.truePredicate();
+        final Predicate<O> p = TruePredicate.truePredicate();
         return subtract(a, b, p);
     }
 
@@ -269,12 +269,12 @@ public class CollectionUtils {
                                              final Predicate<O> p) {
         final ArrayList<O> list = new ArrayList<O>();
         final HashBag<O> bag = new HashBag<O>();
-        for (O element : b) {
+        for (final O element : b) {
             if (p.evaluate(element)) {
                 bag.add(element);
             }
         }
-        for (O element : a) {
+        for (final O element : a) {
             if (!bag.remove(element, 1)) {
                 list.add(element);
             }
@@ -296,13 +296,13 @@ public class CollectionUtils {
      */
     public static boolean containsAny(final Collection<?> coll1, final Collection<?> coll2) {
         if (coll1.size() < coll2.size()) {
-            for (Object aColl1 : coll1) {
+            for (final Object aColl1 : coll1) {
                 if (coll2.contains(aColl1)) {
                     return true;
                 }
             }
         } else {
-            for (Object aColl2 : coll2) {
+            for (final Object aColl2 : coll2) {
                 if (coll1.contains(aColl2)) {
                     return true;
                 }
@@ -328,9 +328,9 @@ public class CollectionUtils {
      * @return the populated cardinality map
      */
     public static <O> Map<O, Integer> getCardinalityMap(final Iterable<? extends O> coll) {
-        Map<O, Integer> count = new HashMap<O, Integer>();
-        for (O obj : coll) {
-            Integer c = count.get(obj);
+        final Map<O, Integer> count = new HashMap<O, Integer>();
+        for (final O obj : coll) {
+            final Integer c = count.get(obj);
             if (c == null) {
                 count.put(obj, Integer.valueOf(1));
             } else {
@@ -353,8 +353,8 @@ public class CollectionUtils {
      * @see Collection#containsAll
      */
     public static boolean isSubCollection(final Collection<?> a, final Collection<?> b) {
-        CardinalityHelper<Object> helper = new CardinalityHelper<Object>(a, b);
-        for (Object obj : a) {
+        final CardinalityHelper<Object> helper = new CardinalityHelper<Object>(a, b);
+        for (final Object obj : a) {
             if (helper.freqA(obj) > helper.freqB(obj)) {
                 return false;
             }
@@ -407,7 +407,7 @@ public class CollectionUtils {
         if(helper.cardinalityA.size() != helper.cardinalityB.size()) {
             return false;
         }
-        for( Object obj : helper.cardinalityA.keySet()) {
+        for( final Object obj : helper.cardinalityA.keySet()) {
             if(helper.freqA(obj) != helper.freqB(obj)) {
                 return false;
             }
@@ -423,7 +423,7 @@ public class CollectionUtils {
      * @param <O> the type of object that the {@link Iterable} may contain.
      * @return the the number of occurrences of obj in coll
      */
-    public static <O> int cardinality(O obj, final Iterable<? super O> coll) {
+    public static <O> int cardinality(final O obj, final Iterable<? super O> coll) {
         if (coll instanceof Set<?>) {
             return ((Set<? super O>) coll).contains(obj) ? 1 : 0;
         }
@@ -432,13 +432,13 @@ public class CollectionUtils {
         }
         int count = 0;
         if (obj == null) {
-            for (Object element : coll) {
+            for (final Object element : coll) {
                 if (element == null) {
                     count++;
                 }
             }
         } else {
-            for (Object element : coll) {
+            for (final Object element : coll) {
                 if (obj.equals(element)) {
                     count++;
                 }
@@ -457,9 +457,9 @@ public class CollectionUtils {
      * @param predicate  the predicate to use, may be null
      * @return the first element of the collection which matches the predicate or null if none could be found
      */
-    public static <T> T find(Collection<T> collection, Predicate<? super T> predicate) {
+    public static <T> T find(final Collection<T> collection, final Predicate<? super T> predicate) {
         if (collection != null && predicate != null) {
-            for (T item : collection) {
+            for (final T item : collection) {
                 if (predicate.evaluate(item)) {
                     return item;
                 }
@@ -479,9 +479,9 @@ public class CollectionUtils {
      *            the closure to perform, may be null
      * @return closure
      */
-    public static <T, C extends Closure<? super T>> C forAllDo(Collection<T> collection, C closure) {
+    public static <T, C extends Closure<? super T>> C forAllDo(final Collection<T> collection, final C closure) {
         if (collection != null && closure != null) {
-            for (T element : collection) {
+            for (final T element : collection) {
                 closure.execute(element);
             }
         }
@@ -500,7 +500,7 @@ public class CollectionUtils {
      * @return closure
      * @since 4.0
      */
-    public static <T, C extends Closure<? super T>> C forAllDo(Iterator<T> iterator, C closure) {
+    public static <T, C extends Closure<? super T>> C forAllDo(final Iterator<T> iterator, final C closure) {
         if (iterator != null && closure != null) {
             while (iterator.hasNext()) {
                 closure.execute(iterator.next());
@@ -521,10 +521,10 @@ public class CollectionUtils {
      *            the predicate to use as a filter, may be null
      * @return true if the collection is modified by this call, false otherwise.
      */
-    public static <T> boolean filter(Iterable<T> collection, Predicate<? super T> predicate) {
+    public static <T> boolean filter(final Iterable<T> collection, final Predicate<? super T> predicate) {
         boolean result = false;
         if (collection != null && predicate != null) {
-            for (Iterator<T> it = collection.iterator(); it.hasNext();) {
+            for (final Iterator<T> it = collection.iterator(); it.hasNext();) {
                 if (!predicate.evaluate(it.next())) {
                     it.remove();
                     result = true;
@@ -552,16 +552,16 @@ public class CollectionUtils {
      * @param transformer
      *            the transformer to perform, may be null
      */
-    public static <C> void transform(Collection<C> collection,
-            Transformer<? super C, ? extends C> transformer) {
+    public static <C> void transform(final Collection<C> collection,
+            final Transformer<? super C, ? extends C> transformer) {
         if (collection != null && transformer != null) {
             if (collection instanceof List<?>) {
-                List<C> list = (List<C>) collection;
-                for (ListIterator<C> it = list.listIterator(); it.hasNext();) {
+                final List<C> list = (List<C>) collection;
+                for (final ListIterator<C> it = list.listIterator(); it.hasNext();) {
                     it.set(transformer.transform(it.next()));
                 }
             } else {
-                Collection<C> resultCollection = collect(collection, transformer);
+                final Collection<C> resultCollection = collect(collection, transformer);
                 collection.clear();
                 collection.addAll(resultCollection);
             }
@@ -580,10 +580,10 @@ public class CollectionUtils {
      *            the predicate to use, may be null
      * @return the number of matches for the predicate in the collection
      */
-    public static <C> int countMatches(Iterable<C> input, Predicate<? super C> predicate) {
+    public static <C> int countMatches(final Iterable<C> input, final Predicate<? super C> predicate) {
         int count = 0;
         if (input != null && predicate != null) {
-            for (C o : input) {
+            for (final C o : input) {
                 if (predicate.evaluate(o)) {
                     count++;
                 }
@@ -605,9 +605,9 @@ public class CollectionUtils {
      * @return true if at least one element of the collection matches the
      *         predicate
      */
-    public static <C> boolean exists(Iterable<C> input, Predicate<? super C> predicate) {
+    public static <C> boolean exists(final Iterable<C> input, final Predicate<? super C> predicate) {
         if (input != null && predicate != null) {
-            for (C o : input) {
+            for (final C o : input) {
                 if (predicate.evaluate(o)) {
                     return true;
                 }
@@ -630,8 +630,8 @@ public class CollectionUtils {
      * @throws NullPointerException
      *             if the input collection is null
      */
-    public static <O> Collection<O> select(Collection<? extends O> inputCollection,
-            Predicate<? super O> predicate) {
+    public static <O> Collection<O> select(final Collection<? extends O> inputCollection,
+            final Predicate<? super O> predicate) {
         return select(inputCollection, predicate, new ArrayList<O>(inputCollection.size()));
     }
 
@@ -651,10 +651,10 @@ public class CollectionUtils {
      *            and predicate or not null
      * @return the outputCollection
      */
-    public static <O, R extends Collection<? super O>> R select(Collection<? extends O> inputCollection,
-            Predicate<? super O> predicate, R outputCollection) {
+    public static <O, R extends Collection<? super O>> R select(final Collection<? extends O> inputCollection,
+            final Predicate<? super O> predicate, final R outputCollection) {
         if (inputCollection != null && predicate != null) {
-            for (O item : inputCollection) {
+            for (final O item : inputCollection) {
                 if (predicate.evaluate(item)) {
                     outputCollection.add(item);
                 }
@@ -678,8 +678,8 @@ public class CollectionUtils {
      * @throws NullPointerException
      *             if the input collection is null
      */
-    public static <O> Collection<O> selectRejected(Collection<? extends O> inputCollection,
-            Predicate<? super O> predicate) {
+    public static <O> Collection<O> selectRejected(final Collection<? extends O> inputCollection,
+            final Predicate<? super O> predicate) {
         return selectRejected(inputCollection, predicate, new ArrayList<O>(inputCollection.size()));
     }
 
@@ -700,9 +700,9 @@ public class CollectionUtils {
      * @return outputCollection
      */
     public static <O, R extends Collection<? super O>> R selectRejected(
-            Collection<? extends O> inputCollection, Predicate<? super O> predicate, R outputCollection) {
+            final Collection<? extends O> inputCollection, final Predicate<? super O> predicate, final R outputCollection) {
         if (inputCollection != null && predicate != null) {
-            for (O item : inputCollection) {
+            for (final O item : inputCollection) {
                 if (!predicate.evaluate(item)) {
                     outputCollection.add(item);
                 }
@@ -727,9 +727,9 @@ public class CollectionUtils {
      * @throws NullPointerException
      *             if the input collection is null
      */
-    public static <I, O> Collection<O> collect(Iterable<I> inputCollection,
-            Transformer<? super I, ? extends O> transformer) {
-        ArrayList<O> answer = new ArrayList<O>();
+    public static <I, O> Collection<O> collect(final Iterable<I> inputCollection,
+            final Transformer<? super I, ? extends O> transformer) {
+        final ArrayList<O> answer = new ArrayList<O>();
         collect(inputCollection, transformer, answer);
         return answer;
     }
@@ -749,9 +749,9 @@ public class CollectionUtils {
      * @param <O> the type of object in the output collection
      * @return the transformed result (new list)
      */
-    public static <I, O> Collection<O> collect(Iterator<I> inputIterator,
-            Transformer<? super I, ? extends O> transformer) {
-        ArrayList<O> answer = new ArrayList<O>();
+    public static <I, O> Collection<O> collect(final Iterator<I> inputIterator,
+            final Transformer<? super I, ? extends O> transformer) {
+        final ArrayList<O> answer = new ArrayList<O>();
         collect(inputIterator, transformer, answer);
         return answer;
     }
@@ -774,7 +774,7 @@ public class CollectionUtils {
      * @throws NullPointerException if the output collection is null and both, inputCollection and
      *   transformer are not null
      */
-    public static <I, O, R extends Collection<? super O>> R collect(Iterable<? extends I> inputCollection,
+    public static <I, O, R extends Collection<? super O>> R collect(final Iterable<? extends I> inputCollection,
             final Transformer<? super I, ? extends O> transformer, final R outputCollection) {
         if (inputCollection != null) {
             return collect(inputCollection.iterator(), transformer, outputCollection);
@@ -801,12 +801,12 @@ public class CollectionUtils {
      *   transformer are not null
      */
     //TODO - deprecate and replace with IteratorIterable
-    public static <I, O, R extends Collection<? super O>> R collect(Iterator<? extends I> inputIterator,
+    public static <I, O, R extends Collection<? super O>> R collect(final Iterator<? extends I> inputIterator,
             final Transformer<? super I, ? extends O> transformer, final R outputCollection) {
         if (inputIterator != null && transformer != null) {
             while (inputIterator.hasNext()) {
-                I item = inputIterator.next();
-                O value = transformer.transform(item);
+                final I item = inputIterator.next();
+                final O value = transformer.transform(item);
                 outputCollection.add(value);
             }
         }
@@ -823,7 +823,7 @@ public class CollectionUtils {
      * @throws NullPointerException if the collection is null
      * @since 3.2
      */
-    public static <T> boolean addIgnoreNull(Collection<T> collection, T object) {
+    public static <T> boolean addIgnoreNull(final Collection<T> collection, final T object) {
         if (collection == null) {
             throw new NullPointerException("The collection must not be null");
         }
@@ -843,7 +843,7 @@ public class CollectionUtils {
      * @throws NullPointerException
      *             if the collection or iterator is null
      */
-    public static <C> boolean addAll(Collection<C> collection, Iterable<? extends C> iterable) {
+    public static <C> boolean addAll(final Collection<C> collection, final Iterable<? extends C> iterable) {
         if (iterable instanceof Collection<?>) {
             return collection.addAll((Collection<? extends C>) iterable);
         }
@@ -861,7 +861,7 @@ public class CollectionUtils {
      * @throws NullPointerException
      *             if the collection or iterator is null
      */
-    public static <C> boolean addAll(Collection<C> collection, Iterator<? extends C> iterator) {
+    public static <C> boolean addAll(final Collection<C> collection, final Iterator<? extends C> iterator) {
         boolean changed = false;
         while (iterator.hasNext()) {
             changed |= collection.add(iterator.next());
@@ -876,7 +876,7 @@ public class CollectionUtils {
      * @param enumeration  the enumeration of elements to add, must not be null
      * @throws NullPointerException if the collection or enumeration is null
      */
-    public static <C> boolean addAll(Collection<C> collection, Enumeration<? extends C> enumeration) {
+    public static <C> boolean addAll(final Collection<C> collection, final Enumeration<? extends C> enumeration) {
         boolean changed = false;
         while (enumeration.hasMoreElements()) {
             changed |= collection.add(enumeration.nextElement());
@@ -894,9 +894,9 @@ public class CollectionUtils {
      * @throws NullPointerException
      *             if the collection or array is null
      */
-    public static <C> boolean addAll(Collection<C> collection, C[] elements) {
+    public static <C> boolean addAll(final Collection<C> collection, final C[] elements) {
         boolean changed = false;
-        for (C element : elements) {
+        for (final C element : elements) {
             changed |= collection.add(element);
         }
         return changed;
@@ -916,7 +916,7 @@ public class CollectionUtils {
      * @throws IndexOutOfBoundsException if the index is invalid
      * @throws IllegalArgumentException if the object type is invalid
      */
-    public static <T> T get(Iterator<T> iterator, int index) {
+    public static <T> T get(final Iterator<T> iterator, final int index) {
         int i = index;
         checkIndexBounds(i);
             while (iterator.hasNext()) {
@@ -934,7 +934,7 @@ public class CollectionUtils {
      * @param index the index to check.
      * @throws IndexOutOfBoundsException if the index is negative.
      */
-    private static void checkIndexBounds(int index) {
+    private static void checkIndexBounds(final int index) {
         if (index < 0) {
             throw new IndexOutOfBoundsException("Index cannot be negative: " + index);
         }
@@ -952,7 +952,7 @@ public class CollectionUtils {
      * @return the object at the specified index
      * @throws IndexOutOfBoundsException if the index is invalid
      */
-    public static <T> T get(Iterable<T> iterable, int index) {
+    public static <T> T get(final Iterable<T> iterable, final int index) {
         checkIndexBounds(index);
         if (iterable instanceof List<?>) {
             return ((List<T>) iterable).get(index);
@@ -990,19 +990,19 @@ public class CollectionUtils {
      * @throws IndexOutOfBoundsException if the index is invalid
      * @throws IllegalArgumentException if the object type is invalid
      */
-    public static Object get(Object object, int index) {
+    public static Object get(final Object object, final int index) {
         int i = index;
         if (i < 0) {
             throw new IndexOutOfBoundsException("Index cannot be negative: " + i);
         }
         if (object instanceof Map<?,?>) {
-            Map<?, ?> map = (Map<?, ?>) object;
-            Iterator<?> iterator = map.entrySet().iterator();
+            final Map<?, ?> map = (Map<?, ?>) object;
+            final Iterator<?> iterator = map.entrySet().iterator();
             return get(iterator, i);
         } else if (object instanceof Object[]) {
             return ((Object[]) object)[i];
         } else if (object instanceof Iterator<?>) {
-            Iterator<?> it = (Iterator<?>) object;
+            final Iterator<?> it = (Iterator<?>) object;
             while (it.hasNext()) {
                 i--;
                 if (i == -1) {
@@ -1012,10 +1012,10 @@ public class CollectionUtils {
             }
             throw new IndexOutOfBoundsException("Entry does not exist: " + i);
         } else if (object instanceof Collection<?>) {
-            Iterator<?> iterator = ((Collection<?>) object).iterator();
+            final Iterator<?> iterator = ((Collection<?>) object).iterator();
             return get(iterator, i);
         } else if (object instanceof Enumeration<?>) {
-            Enumeration<?> it = (Enumeration<?>) object;
+            final Enumeration<?> it = (Enumeration<?>) object;
             while (it.hasMoreElements()) {
                 i--;
                 if (i == -1) {
@@ -1030,7 +1030,7 @@ public class CollectionUtils {
         } else {
             try {
                 return Array.get(object, i);
-            } catch (IllegalArgumentException ex) {
+            } catch (final IllegalArgumentException ex) {
                 throw new IllegalArgumentException("Unsupported object type: " + object.getClass().getName());
             }
         }
@@ -1045,7 +1045,7 @@ public class CollectionUtils {
      * @return the object at the specified index
      * @throws IndexOutOfBoundsException if the index is invalid
      */
-    public static <K,V> Map.Entry<K, V> get(Map<K,V> map, int index) {
+    public static <K,V> Map.Entry<K, V> get(final Map<K,V> map, final int index) {
         checkIndexBounds(index);
         return get(map.entrySet(), index);
     }
@@ -1067,7 +1067,7 @@ public class CollectionUtils {
      * @throws IllegalArgumentException thrown if object is not recognised
      * @since 3.1
      */
-    public static int size(Object object) {
+    public static int size(final Object object) {
         if (object == null) {
             return 0;
         }
@@ -1079,13 +1079,13 @@ public class CollectionUtils {
         } else if (object instanceof Object[]) {
             total = ((Object[]) object).length;
         } else if (object instanceof Iterator<?>) {
-            Iterator<?> it = (Iterator<?>) object;
+            final Iterator<?> it = (Iterator<?>) object;
             while (it.hasNext()) {
                 total++;
                 it.next();
             }
         } else if (object instanceof Enumeration<?>) {
-            Enumeration<?> it = (Enumeration<?>) object;
+            final Enumeration<?> it = (Enumeration<?>) object;
             while (it.hasMoreElements()) {
                 total++;
                 it.nextElement();
@@ -1093,7 +1093,7 @@ public class CollectionUtils {
         } else {
             try {
                 total = Array.getLength(object);
-            } catch (IllegalArgumentException ex) {
+            } catch (final IllegalArgumentException ex) {
                 throw new IllegalArgumentException("Unsupported object type: " + object.getClass().getName());
             }
         }
@@ -1120,7 +1120,7 @@ public class CollectionUtils {
      * @throws IllegalArgumentException thrown if object is not recognised
      * @since 3.2
      */
-    public static boolean sizeIsEmpty(Object object) {
+    public static boolean sizeIsEmpty(final Object object) {
         if (object == null) {
             return true;
         } else if (object instanceof Collection<?>) {
@@ -1136,7 +1136,7 @@ public class CollectionUtils {
         } else {
             try {
                 return Array.getLength(object) == 0;
-            } catch (IllegalArgumentException ex) {
+            } catch (final IllegalArgumentException ex) {
                 throw new IllegalArgumentException("Unsupported object type: " + object.getClass().getName());
             }
         }
@@ -1152,7 +1152,7 @@ public class CollectionUtils {
      * @return true if empty or null
      * @since 3.2
      */
-    public static boolean isEmpty(Collection<?> coll) {
+    public static boolean isEmpty(final Collection<?> coll) {
         return coll == null || coll.isEmpty();
     }
 
@@ -1165,7 +1165,7 @@ public class CollectionUtils {
      * @return true if non-null and non-empty
      * @since 3.2
      */
-    public static boolean isNotEmpty(Collection<?> coll) {
+    public static boolean isNotEmpty(final Collection<?> coll) {
         return !isEmpty(coll);
     }
 
@@ -1175,7 +1175,7 @@ public class CollectionUtils {
      *
      * @param array  the array to reverse
      */
-    public static void reverseArray(Object[] array) {
+    public static void reverseArray(final Object[] array) {
         int i = 0;
         int j = array.length - 1;
         Object tmp;
@@ -1205,7 +1205,7 @@ public class CollectionUtils {
      * @throws NullPointerException if the collection is null
      */
     @SuppressWarnings("unchecked")
-    public static boolean isFull(Collection<?> coll) {
+    public static boolean isFull(final Collection<?> coll) {
         if (coll == null) {
             throw new NullPointerException("The collection must not be null");
         }
@@ -1213,9 +1213,9 @@ public class CollectionUtils {
             return ((BoundedCollection<?>) coll).isFull();
         }
         try {
-            BoundedCollection<?> bcoll = UnmodifiableBoundedCollection.unmodifiableBoundedCollection((Collection<Object>) coll);
+            final BoundedCollection<?> bcoll = UnmodifiableBoundedCollection.unmodifiableBoundedCollection((Collection<Object>) coll);
             return bcoll.isFull();
-        } catch (IllegalArgumentException ex) {
+        } catch (final IllegalArgumentException ex) {
             return false;
         }
     }
@@ -1236,7 +1236,7 @@ public class CollectionUtils {
      * @throws NullPointerException if the collection is null
      */
     @SuppressWarnings("unchecked")
-    public static int maxSize(Collection<?> coll) {
+    public static int maxSize(final Collection<?> coll) {
         if (coll == null) {
             throw new NullPointerException("The collection must not be null");
         }
@@ -1244,9 +1244,9 @@ public class CollectionUtils {
             return ((BoundedCollection<?>) coll).maxSize();
         }
         try {
-            BoundedCollection<?> bcoll = UnmodifiableBoundedCollection.unmodifiableBoundedCollection((Collection<Object>) coll);
+            final BoundedCollection<?> bcoll = UnmodifiableBoundedCollection.unmodifiableBoundedCollection((Collection<Object>) coll);
             return bcoll.maxSize();
-        } catch (IllegalArgumentException ex) {
+        } catch (final IllegalArgumentException ex) {
             return -1;
         }
     }
@@ -1267,7 +1267,7 @@ public class CollectionUtils {
      * @throws NullPointerException if either parameter is null
      * @since 3.2
      */
-    public static <C> Collection<C> retainAll(Collection<C> collection, Collection<?> retain) {
+    public static <C> Collection<C> retainAll(final Collection<C> collection, final Collection<?> retain) {
         return ListUtils.retainAll(collection, retain);
     }
 
@@ -1287,7 +1287,7 @@ public class CollectionUtils {
      * @throws NullPointerException if either parameter is null
      * @since 3.3 (method existed in 3.2 but was completely broken)
      */
-    public static <E> Collection<E> removeAll(Collection<E> collection, Collection<?> remove) {
+    public static <E> Collection<E> removeAll(final Collection<E> collection, final Collection<?> remove) {
         return ListUtils.removeAll(collection, remove);
     }
 
@@ -1314,7 +1314,7 @@ public class CollectionUtils {
      * @return a synchronized collection backed by the given collection
      * @throws IllegalArgumentException  if the collection is null
      */
-    public static <C> Collection<C> synchronizedCollection(Collection<C> collection) {
+    public static <C> Collection<C> synchronizedCollection(final Collection<C> collection) {
         return SynchronizedCollection.synchronizedCollection(collection);
     }
 
@@ -1327,7 +1327,7 @@ public class CollectionUtils {
      * @return an unmodifiable collection backed by the given collection
      * @throws IllegalArgumentException  if the collection is null
      */
-    public static <C> Collection<C> unmodifiableCollection(Collection<C> collection) {
+    public static <C> Collection<C> unmodifiableCollection(final Collection<C> collection) {
         return UnmodifiableCollection.unmodifiableCollection(collection);
     }
 
@@ -1345,7 +1345,7 @@ public class CollectionUtils {
      * @return a predicated collection backed by the given collection
      * @throws IllegalArgumentException  if the Collection is null
      */
-    public static <C> Collection<C> predicatedCollection(Collection<C> collection, Predicate<? super C> predicate) {
+    public static <C> Collection<C> predicatedCollection(final Collection<C> collection, final Predicate<? super C> predicate) {
         return PredicatedCollection.predicatedCollection(collection, predicate);
     }
 
@@ -1364,7 +1364,7 @@ public class CollectionUtils {
      * @return a transformed collection backed by the given collection
      * @throws IllegalArgumentException  if the Collection or Transformer is null
      */
-    public static <E> Collection<E> transformingCollection(Collection<E> collection, Transformer<? super E, ? extends E> transformer) {
+    public static <E> Collection<E> transformingCollection(final Collection<E> collection, final Transformer<? super E, ? extends E> transformer) {
         return TransformedCollection.transformingCollection(collection, transformer);
     }
 
@@ -1375,7 +1375,7 @@ public class CollectionUtils {
      * @return sole member of collection
      * @throws IllegalArgumentException if collection is null/empty or contains more than one element
      */
-    public static <E> E extractSingleton(Collection<E> collection) {
+    public static <E> E extractSingleton(final Collection<E> collection) {
         if (collection == null || collection.size() != 1) {
             throw new IllegalArgumentException("Can extract singleton only when collection size == 1");
         }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ComparatorUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ComparatorUtils.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ComparatorUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ComparatorUtils.java Mon Jan  7 17:15:14 2013
@@ -76,8 +76,8 @@ public class ComparatorUtils {
      * @see ComparatorChain
      */
     @SuppressWarnings("unchecked")
-    public static <E extends Comparable<? super E>> Comparator<E> chainedComparator(Comparator<E> comparator1,
-                                                                                    Comparator<E> comparator2) {
+    public static <E extends Comparable<? super E>> Comparator<E> chainedComparator(final Comparator<E> comparator1,
+                                                                                    final Comparator<E> comparator2) {
         return chainedComparator(new Comparator[] {comparator1, comparator2});
     }
 
@@ -90,9 +90,9 @@ public class ComparatorUtils {
      * @throws NullPointerException if comparators array is null or contains a null
      * @see ComparatorChain
      */
-    public static <E extends Comparable<? super E>> Comparator<E> chainedComparator(Comparator<E>[] comparators) {
-        ComparatorChain<E> chain = new ComparatorChain<E>();
-        for (Comparator<E> comparator : comparators) {
+    public static <E extends Comparable<? super E>> Comparator<E> chainedComparator(final Comparator<E>[] comparators) {
+        final ComparatorChain<E> chain = new ComparatorChain<E>();
+        for (final Comparator<E> comparator : comparators) {
             if (comparator == null) {
                 throw new NullPointerException("Comparator cannot be null");
             }
@@ -113,7 +113,7 @@ public class ComparatorUtils {
      * @see ComparatorChain
      */
     @SuppressWarnings("unchecked")
-    public static <E extends Comparable<? super E>> Comparator<E> chainedComparator(Collection<Comparator<E>> comparators) {
+    public static <E extends Comparable<? super E>> Comparator<E> chainedComparator(final Collection<Comparator<E>> comparators) {
         return chainedComparator(
             (Comparator<E>[]) comparators.toArray(new Comparator[comparators.size()])
         );
@@ -126,7 +126,7 @@ public class ComparatorUtils {
      * @return  a comparator that reverses the order of the input comparator
      * @see ReverseComparator
      */
-    public static <E> Comparator<E> reversedComparator(Comparator<E> comparator) {
+    public static <E> Comparator<E> reversedComparator(final Comparator<E> comparator) {
         return new ReverseComparator<E>(comparator);
     }
 
@@ -142,7 +142,7 @@ public class ComparatorUtils {
      *        <code>false</code> {@link Boolean}s.
      * @return  a comparator that sorts booleans
      */
-    public static Comparator<Boolean> booleanComparator(boolean trueFirst) {
+    public static Comparator<Boolean> booleanComparator(final boolean trueFirst) {
         return BooleanComparator.booleanComparator(trueFirst);
     }
     
@@ -197,7 +197,7 @@ public class ComparatorUtils {
      * @see  TransformingComparator
      */
     @SuppressWarnings("unchecked")
-    public static <E> Comparator<E> transformedComparator(Comparator<E> comparator, Transformer<? super E, ? extends E> transformer) {
+    public static <E> Comparator<E> transformedComparator(Comparator<E> comparator, final Transformer<? super E, ? extends E> transformer) {
         if (comparator == null) {
             comparator = NATURAL_COMPARATOR;
         }
@@ -215,11 +215,11 @@ public class ComparatorUtils {
      *  @return  the smaller of the two objects
      */
     @SuppressWarnings("unchecked")
-    public static <E> E min(E o1, E o2, Comparator<E> comparator) {
+    public static <E> E min(final E o1, final E o2, Comparator<E> comparator) {
         if (comparator == null) {
             comparator = NATURAL_COMPARATOR;
         }
-        int c = comparator.compare(o1, o2);
+        final int c = comparator.compare(o1, o2);
         return c < 0 ? o1 : o2;
     }
 
@@ -234,11 +234,11 @@ public class ComparatorUtils {
      *  @return  the larger of the two objects
      */
     @SuppressWarnings("unchecked")
-    public static <E> E max(E o1, E o2, Comparator<E> comparator) {
+    public static <E> E max(final E o1, final E o2, Comparator<E> comparator) {
         if (comparator == null) {
             comparator = NATURAL_COMPARATOR;
         }
-        int c = comparator.compare(o1, o2);
+        final int c = comparator.compare(o1, o2);
         return c > 0 ? o1 : o2;
     }
     

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/EnumerationUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/EnumerationUtils.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/EnumerationUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/EnumerationUtils.java Mon Jan  7 17:15:14 2013
@@ -49,7 +49,7 @@ public class EnumerationUtils {
      * @return a list containing all elements of the given enumeration
      * @throws NullPointerException if the enumeration parameter is <code>null</code>.
      */
-    public static <E> List<E> toList(Enumeration<E> enumeration) {
+    public static <E> List<E> toList(final Enumeration<E> enumeration) {
         return IteratorUtils.toList(new EnumerationIterator<E>(enumeration));
     }
 
@@ -60,8 +60,8 @@ public class EnumerationUtils {
      * @param stringTokenizer  the tokenizer to convert to a {@link List(String)}
      * @return List<String>
      */
-    public static List<String> toList(StringTokenizer stringTokenizer) {
-        List<String> result = new ArrayList<String>(stringTokenizer.countTokens());
+    public static List<String> toList(final StringTokenizer stringTokenizer) {
+        final List<String> result = new ArrayList<String>(stringTokenizer.countTokens());
         while (stringTokenizer.hasMoreTokens()) {
             result.add(stringTokenizer.nextToken());
         }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/ExtendedProperties.java Mon Jan  7 17:15:14 2013
@@ -188,7 +188,7 @@ public class ExtendedProperties extends 
      * @param base string to interpolate
      * @return returns the key name with the ${key} substituted
      */
-    protected String interpolate(String base) {
+    protected String interpolate(final String base) {
         // COPIED from [configuration] 2003-12-29
         return interpolateHelper(base, null);
     }
@@ -207,7 +207,7 @@ public class ExtendedProperties extends 
      *
      * @return the string with the interpolation taken care of
      */
-    protected String interpolateHelper(String base, List<String> priorVariables) {
+    protected String interpolateHelper(final String base, List<String> priorVariables) {
         // COPIED from [configuration] 2003-12-29
         if (base == null) {
             return null;
@@ -224,7 +224,7 @@ public class ExtendedProperties extends 
         int end = -1;
         int prec = 0 - END_TOKEN.length();
         String variable = null;
-        StringBuilder result = new StringBuilder();
+        final StringBuilder result = new StringBuilder();
 
         // FIXME: we should probably allow the escaping of the start token
         while ((begin = base.indexOf(START_TOKEN, prec + END_TOKEN.length())) > -1
@@ -234,13 +234,13 @@ public class ExtendedProperties extends 
 
             // if we've got a loop, create a useful exception message and throw
             if (priorVariables.contains(variable)) {
-                String initialBase = priorVariables.remove(0).toString();
+                final String initialBase = priorVariables.remove(0).toString();
                 priorVariables.add(variable);
-                StringBuilder priorVariableSb = new StringBuilder();
+                final StringBuilder priorVariableSb = new StringBuilder();
 
                 // create a nice trace of interpolated variables like so:
                 // var1->var2->var3
-                for (Iterator<?> it = priorVariables.iterator(); it.hasNext();) {
+                for (final Iterator<?> it = priorVariables.iterator(); it.hasNext();) {
                     priorVariableSb.append(it.next());
                     if (it.hasNext()) {
                         priorVariableSb.append("->");
@@ -256,7 +256,7 @@ public class ExtendedProperties extends 
             }
 
             //QUESTION: getProperty or getPropertyDirect
-            Object value = getProperty(variable);
+            final Object value = getProperty(variable);
             if (value != null) {
                 result.append(interpolateHelper(value.toString(), priorVariables));
 
@@ -281,10 +281,10 @@ public class ExtendedProperties extends 
     /**
      * Inserts a backslash before every comma and backslash. 
      */
-    private static String escape(String s) {
-        StringBuilder buf = new StringBuilder(s);
+    private static String escape(final String s) {
+        final StringBuilder buf = new StringBuilder(s);
         for (int i = 0; i < buf.length(); i++) {
-            char c = buf.charAt(i);
+            final char c = buf.charAt(i);
             if (c == ',' || c == '\\') {
                 buf.insert(i, '\\');
                 i++;
@@ -296,11 +296,11 @@ public class ExtendedProperties extends 
     /**
      * Removes a backslash from every pair of backslashes. 
      */
-    private static String unescape(String s) {
-        StringBuilder buf = new StringBuilder(s);
+    private static String unescape(final String s) {
+        final StringBuilder buf = new StringBuilder(s);
         for (int i = 0; i < buf.length() - 1; i++) {
-            char c1 = buf.charAt(i);
-            char c2 = buf.charAt(i + 1);
+            final char c1 = buf.charAt(i);
+            final char c2 = buf.charAt(i + 1);
             if (c1 == '\\' && c2 == '\\') {
                 buf.deleteCharAt(i);
             }
@@ -312,7 +312,7 @@ public class ExtendedProperties extends 
      * Counts the number of successive times 'ch' appears in the
      * 'line' before the position indicated by the 'index'.
      */
-    private static int countPreceding(String line, int index, char ch) {
+    private static int countPreceding(final String line, final int index, final char ch) {
         int i;
         for (i = index - 1; i >= 0; i--) {
             if (line.charAt(i) != ch) {
@@ -325,7 +325,7 @@ public class ExtendedProperties extends 
     /**
      * Checks if the line ends with odd number of backslashes 
      */
-    private static boolean endsWithSlash(String line) {
+    private static boolean endsWithSlash(final String line) {
         if (!line.endsWith("\\")) {
             return false;
         }
@@ -344,7 +344,7 @@ public class ExtendedProperties extends 
          *
          * @param reader A Reader.
          */
-        public PropertiesReader(Reader reader) {
+        public PropertiesReader(final Reader reader) {
             super(reader);
         }
 
@@ -355,7 +355,7 @@ public class ExtendedProperties extends 
          * @throws IOException if there is difficulty reading the source.
          */
         public String readProperty() throws IOException {
-            StringBuilder buffer = new StringBuilder();
+            final StringBuilder buffer = new StringBuilder();
             String line = readLine();
             while (line != null) {
                 line = line.trim();
@@ -390,7 +390,7 @@ public class ExtendedProperties extends 
          *
          * @param string A String.
          */
-        public PropertiesTokenizer(String string) {
+        public PropertiesTokenizer(final String string) {
             super(string, DELIMITER);
         }
 
@@ -411,10 +411,10 @@ public class ExtendedProperties extends 
          */
         @Override
         public String nextToken() {
-            StringBuilder buffer = new StringBuilder();
+            final StringBuilder buffer = new StringBuilder();
 
             while (hasMoreTokens()) {
-                String token = super.nextToken();
+                final String token = super.nextToken();
                 if (endsWithSlash(token)) {
                     buffer.append(token.substring(0, token.length() - 1));
                     buffer.append(DELIMITER);
@@ -441,7 +441,7 @@ public class ExtendedProperties extends 
      * @param file  the filename to load
      * @throws IOException if a file error occurs
      */
-    public ExtendedProperties(String file) throws IOException {
+    public ExtendedProperties(final String file) throws IOException {
         this(file, null);
     }
 
@@ -452,7 +452,7 @@ public class ExtendedProperties extends 
      * @param defaultFile  a second filename to load default values from
      * @throws IOException if a file error occurs
      */
-    public ExtendedProperties(String file, String defaultFile) throws IOException {
+    public ExtendedProperties(final String file, final String defaultFile) throws IOException {
         this.file = file;
 
         basePath = new File(file).getAbsolutePath();
@@ -467,7 +467,7 @@ public class ExtendedProperties extends 
                 if (in != null) {
                     in.close();
                 }
-            } catch (IOException ex) {}
+            } catch (final IOException ex) {}
         }
 
         if (defaultFile != null) {
@@ -499,7 +499,7 @@ public class ExtendedProperties extends 
      *
      * @param inc  the property name which includes another property, empty converted to null
      */
-    public void setInclude(String inc) {
+    public void setInclude(final String inc) {
         includePropertyName = inc;
     }
 
@@ -509,7 +509,7 @@ public class ExtendedProperties extends 
      * @param input  the InputStream to load from
      * @throws IOException if an IO error occurs
      */
-    public void load(InputStream input) throws IOException {
+    public void load(final InputStream input) throws IOException {
         load(input, null);
     }
 
@@ -521,13 +521,13 @@ public class ExtendedProperties extends 
      * @param enc  the encoding to use
      * @throws IOException if an IO error occurs
      */
-    public synchronized void load(InputStream input, String enc) throws IOException {
+    public synchronized void load(final InputStream input, final String enc) throws IOException {
         PropertiesReader reader = null;
         if (enc != null) {
             try {
                 reader = new PropertiesReader(new InputStreamReader(input, enc));
                 
-            } catch (UnsupportedEncodingException ex) {
+            } catch (final UnsupportedEncodingException ex) {
                 // Another try coming up....
             }
         }
@@ -536,7 +536,7 @@ public class ExtendedProperties extends 
             try {
                 reader = new PropertiesReader(new InputStreamReader(input, "8859_1"));
                 
-            } catch (UnsupportedEncodingException ex) {
+            } catch (final UnsupportedEncodingException ex) {
                 // ISO8859-1 support is required on java platforms but....
                 // If it's not supported, use the system default encoding
                 reader = new PropertiesReader(new InputStreamReader(input));
@@ -544,16 +544,16 @@ public class ExtendedProperties extends 
         }
 
         try {
-            String includeProperty = getInclude();
+            final String includeProperty = getInclude();
             while (true) {
-                String line = reader.readProperty();
+                final String line = reader.readProperty();
                 if (line == null) {
                     return;  // EOF
                 }
-                int equalSign = line.indexOf('=');
+                final int equalSign = line.indexOf('=');
 
                 if (equalSign > 0) {
-                    String key = line.substring(0, equalSign).trim();
+                    final String key = line.substring(0, equalSign).trim();
                     String value = line.substring(equalSign + 1).trim();
 
                     /* COLLECTIONS-238 allows empty properties to exist by commenting this out
@@ -603,7 +603,7 @@ public class ExtendedProperties extends 
      * @return value as object. Will return user value if exists,
      *        if not then default value if exists, otherwise null
      */
-    public Object getProperty(String key) {
+    public Object getProperty(final String key) {
         // first, try to get from the 'user value' store
         Object obj = super.get(key);
 
@@ -637,14 +637,14 @@ public class ExtendedProperties extends 
      * @param key  the key to add
      * @param value  the value to add
      */
-    public void addProperty(String key, Object value) {
+    public void addProperty(final String key, final Object value) {
         if (value instanceof String) {
-            String str = (String) value;
+            final String str = (String) value;
             if (str.indexOf(PropertiesTokenizer.DELIMITER) > 0) {
                 // token contains commas, so must be split apart then added
-                PropertiesTokenizer tokenizer = new PropertiesTokenizer(str);
+                final PropertiesTokenizer tokenizer = new PropertiesTokenizer(str);
                 while (tokenizer.hasMoreTokens()) {
-                    String token = tokenizer.nextToken();
+                    final String token = tokenizer.nextToken();
                     addPropertyInternal(key, unescape(token));
                 }
             } else {
@@ -666,7 +666,7 @@ public class ExtendedProperties extends 
      * @param key  the key to store at
      * @param value  the decoded object to store
      */
-    private void addPropertyDirect(String key, Object value) {
+    private void addPropertyDirect(final String key, final Object value) {
         // safety check
         if (!containsKey(key)) {
             keysAsListed.add(key);
@@ -685,12 +685,12 @@ public class ExtendedProperties extends 
      * @param key  the key to store at
      * @param value  the decoded object to store
      */
-    private void addPropertyInternal(String key, Object value) {
-        Object current = this.get(key);
+    private void addPropertyInternal(final String key, final Object value) {
+        final Object current = this.get(key);
 
         if (current instanceof String) {
             // one object already in map - convert it to a vector
-            List<Object> values = new Vector<Object>(2);
+            final List<Object> values = new Vector<Object>(2);
             values.add(current);
             values.add(value);
             super.put(key, values);
@@ -698,6 +698,7 @@ public class ExtendedProperties extends 
         } else if (current instanceof List) {
             // already a list - just add the new token
             @SuppressWarnings("unchecked") // OK to cast to Object
+            final
             List<Object> list = (List<Object>) current;
             list.add(value);
             
@@ -718,7 +719,7 @@ public class ExtendedProperties extends 
      * @param key  the key to set
      * @param value  the value to set
      */
-    public void setProperty(String key, Object value) {
+    public void setProperty(final String key, final Object value) {
         clearProperty(key);
         addProperty(key, value);
     }
@@ -732,22 +733,22 @@ public class ExtendedProperties extends 
      * @param header  a textual comment to act as a file header
      * @throws IOException if an IO error occurs
      */
-    public synchronized void save(OutputStream output, String header) throws IOException {
+    public synchronized void save(final OutputStream output, final String header) throws IOException {
         if (output == null) {
             return;
         }
-        PrintWriter theWrtr = new PrintWriter(output);
+        final PrintWriter theWrtr = new PrintWriter(output);
         if (header != null) {
             theWrtr.println(header);
         }
         
-        Enumeration<String> theKeys = keys();
+        final Enumeration<String> theKeys = keys();
         while (theKeys.hasMoreElements()) {
-            String key = theKeys.nextElement();
-            Object value = get(key);
+            final String key = theKeys.nextElement();
+            final Object value = get(key);
             if (value != null) {
                 if (value instanceof String) {
-                    StringBuilder currentOutput = new StringBuilder();
+                    final StringBuilder currentOutput = new StringBuilder();
                     currentOutput.append(key);
                     currentOutput.append("=");
                     currentOutput.append(escape((String) value));
@@ -755,9 +756,10 @@ public class ExtendedProperties extends 
                     
                 } else if (value instanceof List) {
                     @SuppressWarnings("unchecked") // we only add Strings to the Lists
+                    final
                     List<String> values = (List<String>) value;
-                    for (String currentElement : values) {
-                        StringBuilder currentOutput = new StringBuilder();
+                    for (final String currentElement : values) {
+                        final StringBuilder currentOutput = new StringBuilder();
                         currentOutput.append(key);
                         currentOutput.append("=");
                         currentOutput.append(escape(currentElement));
@@ -777,9 +779,9 @@ public class ExtendedProperties extends 
      *
      * @param props  the properties to combine
      */
-    public void combine(ExtendedProperties props) {
-        for (Iterator<String> it = props.getKeys(); it.hasNext();) {
-            String key = it.next();
+    public void combine(final ExtendedProperties props) {
+        for (final Iterator<String> it = props.getKeys(); it.hasNext();) {
+            final String key = it.next();
             clearProperty(key);
             addPropertyDirect(key, props.get(key));
         }
@@ -790,7 +792,7 @@ public class ExtendedProperties extends 
      *
      * @param key  the property key to remove along with corresponding value
      */
-    public void clearProperty(String key) {
+    public void clearProperty(final String key) {
         if (containsKey(key)) {
             // we also need to rebuild the keysAsListed or else
             // things get *very* confusing
@@ -821,12 +823,12 @@ public class ExtendedProperties extends 
      * @param prefix  the prefix to match
      * @return an Iterator of keys that match the prefix
      */
-    public Iterator<String> getKeys(String prefix) {
-        Iterator<String> keys = getKeys();
-        ArrayList<String> matchingKeys = new ArrayList<String>();
+    public Iterator<String> getKeys(final String prefix) {
+        final Iterator<String> keys = getKeys();
+        final ArrayList<String> matchingKeys = new ArrayList<String>();
 
         while (keys.hasNext()) {
-            String key = keys.next();
+            final String key = keys.next();
             if (key.startsWith(prefix)) {
                 matchingKeys.add(key);
             }
@@ -843,13 +845,13 @@ public class ExtendedProperties extends 
      * @return a new independent ExtendedProperties
      * or {@code null} if no keys matched
      */
-    public ExtendedProperties subset(String prefix) {
-        ExtendedProperties c = new ExtendedProperties();
-        Iterator<String> keys = getKeys();
+    public ExtendedProperties subset(final String prefix) {
+        final ExtendedProperties c = new ExtendedProperties();
+        final Iterator<String> keys = getKeys();
         boolean validSubset = false;
 
         while (keys.hasNext()) {
-            String key = keys.next();
+            final String key = keys.next();
 
             if (key.startsWith(prefix)) {
                 if (!validSubset) {
@@ -889,11 +891,11 @@ public class ExtendedProperties extends 
      * Display the configuration for debugging purposes to System.out.
      */
     public void display() {
-        Iterator<String> i = getKeys();
+        final Iterator<String> i = getKeys();
 
         while (i.hasNext()) {
-            String key = i.next();
-            Object value = get(key);
+            final String key = i.next();
+            final Object value = get(key);
             System.out.println(key + " => " + value);
         }
     }
@@ -906,7 +908,7 @@ public class ExtendedProperties extends 
      * @throws ClassCastException is thrown if the key maps to an
      * object that is not a String.
      */
-    public String getString(String key) {
+    public String getString(final String key) {
         return getString(key, null);
     }
 
@@ -920,8 +922,8 @@ public class ExtendedProperties extends 
      * @throws ClassCastException is thrown if the key maps to an
      * object that is not a String.
      */
-    public String getString(String key, String defaultValue) {
-        Object value = get(key);
+    public String getString(final String key, final String defaultValue) {
+        final Object value = get(key);
 
         if (value instanceof String) {
             return interpolate((String) value);
@@ -934,6 +936,7 @@ public class ExtendedProperties extends 
             }
         } else if (value instanceof List) {
             @SuppressWarnings("unchecked") // Only expecting Strings here
+            final
             List<String> entry = (List<String>) value;
             return interpolate(entry.get(0)); // requires a String
         } else {
@@ -952,7 +955,7 @@ public class ExtendedProperties extends 
      * @throws IllegalArgumentException if one of the tokens is
      * malformed (does not contain an equals sign).
      */
-    public Properties getProperties(String key) {
+    public Properties getProperties(final String key) {
         return getProperties(key, new Properties());
     }
 
@@ -967,19 +970,19 @@ public class ExtendedProperties extends 
      * @throws IllegalArgumentException if one of the tokens is
      * malformed (does not contain an equals sign).
      */
-    public Properties getProperties(String key, Properties defaults) {
+    public Properties getProperties(final String key, final Properties defaults) {
         /*
          * Grab an array of the tokens for this key.
          */
-        String[] tokens = getStringArray(key);
+        final String[] tokens = getStringArray(key);
 
         // Each token is of the form 'key=value'.
-        Properties props = new Properties(defaults);
-        for (String token : tokens) {
-            int equalSign = token.indexOf('=');
+        final Properties props = new Properties(defaults);
+        for (final String token : tokens) {
+            final int equalSign = token.indexOf('=');
             if (equalSign > 0) {
-                String pkey = token.substring(0, equalSign).trim();
-                String pvalue = token.substring(equalSign + 1).trim();
+                final String pkey = token.substring(0, equalSign).trim();
+                final String pvalue = token.substring(equalSign + 1).trim();
                 props.setProperty(pkey, pvalue);
             } else {
                 throw new IllegalArgumentException('\'' + token + "' does not contain " + "an equals sign");
@@ -997,8 +1000,8 @@ public class ExtendedProperties extends 
      * @throws ClassCastException is thrown if the key maps to an
      * object that is not a String/List.
      */
-    public String[] getStringArray(String key) {
-        Object value = get(key);
+    public String[] getStringArray(final String key) {
+        final Object value = get(key);
 
         List<String> values;
         if (value instanceof String) {
@@ -1007,6 +1010,7 @@ public class ExtendedProperties extends 
             
         } else if (value instanceof List) {
             @SuppressWarnings("unchecked") // We only add Strings to the Lists
+            final
             List<String> list = (List<String>) value;
             values = list;
             
@@ -1020,7 +1024,7 @@ public class ExtendedProperties extends 
             throw new ClassCastException('\'' + key + "' doesn't map to a String/List object");
         }
 
-        String[] tokens = new String[values.size()];
+        final String[] tokens = new String[values.size()];
         for (int i = 0; i < tokens.length; i++) {
             tokens[i] = values.get(i);
         }
@@ -1037,7 +1041,7 @@ public class ExtendedProperties extends 
      * @throws ClassCastException is thrown if the key maps to an
      * object that is not a Vector.
      */
-    public Vector<String> getVector(String key) {
+    public Vector<String> getVector(final String key) {
         return getVector(key, null);
     }
 
@@ -1053,16 +1057,17 @@ public class ExtendedProperties extends 
      * @throws ClassCastException is thrown if the key maps to an
      * object that is not a Vector.
      */
-    public Vector<String> getVector(String key, Vector<String> defaultValue) {
-        Object value = get(key);
+    public Vector<String> getVector(final String key, final Vector<String> defaultValue) {
+        final Object value = get(key);
 
         if (value instanceof List) {
             @SuppressWarnings("unchecked") // our lists only contain Strings
+            final
             List<String> list = (List<String>) value;
             return new Vector<String>(list);
             
         } else if (value instanceof String) {
-            Vector<String> values = new Vector<String>(1);
+            final Vector<String> values = new Vector<String>(1);
             values.add((String) value);
             super.put(key, values);
             return values;
@@ -1090,7 +1095,7 @@ public class ExtendedProperties extends 
      * object that is not a List.
      * @since 3.2
      */
-    public List<String> getList(String key) {
+    public List<String> getList(final String key) {
         return getList(key, null);
     }
 
@@ -1107,16 +1112,17 @@ public class ExtendedProperties extends 
      * object that is not a List.
      * @since 3.2
      */
-    public List<String> getList(String key, List<String> defaultValue) {
-        Object value = get(key);
+    public List<String> getList(final String key, final List<String> defaultValue) {
+        final Object value = get(key);
 
         if (value instanceof List) {
             @SuppressWarnings("unchecked") // our lists only contain strings
+            final
             List<String> list = (List<String>) value;
             return new ArrayList<String>(list);
             
         } else if (value instanceof String) {
-            List<String> values = new ArrayList<String>(1);
+            final List<String> values = new ArrayList<String>(1);
             values.add((String) value);
             super.put(key, values);
             return values;
@@ -1142,8 +1148,8 @@ public class ExtendedProperties extends 
      * @throws ClassCastException is thrown if the key maps to an
      * object that is not a Boolean.
      */
-    public boolean getBoolean(String key) {
-        Boolean b = getBoolean(key, null);
+    public boolean getBoolean(final String key) {
+        final Boolean b = getBoolean(key, null);
         if (b != null) {
             return b.booleanValue();
         } else {
@@ -1160,7 +1166,7 @@ public class ExtendedProperties extends 
      * @throws ClassCastException is thrown if the key maps to an
      * object that is not a Boolean.
      */
-    public boolean getBoolean(String key, boolean defaultValue) {
+    public boolean getBoolean(final String key, final boolean defaultValue) {
         return getBoolean(key, Boolean.valueOf(defaultValue)).booleanValue();
     }
 
@@ -1174,16 +1180,16 @@ public class ExtendedProperties extends 
      * @throws ClassCastException is thrown if the key maps to an
      * object that is not a Boolean.
      */
-    public Boolean getBoolean(String key, Boolean defaultValue) {
+    public Boolean getBoolean(final String key, final Boolean defaultValue) {
 
-        Object value = get(key);
+        final Object value = get(key);
 
         if (value instanceof Boolean) {
             return (Boolean) value;
             
         } else if (value instanceof String) {
-            String s = testBoolean((String) value);
-            Boolean b = Boolean.valueOf(s);
+            final String s = testBoolean((String) value);
+            final Boolean b = Boolean.valueOf(s);
             super.put(key, b);
             return b;
             
@@ -1210,8 +1216,8 @@ public class ExtendedProperties extends 
      * @return <code>true</code> or <code>false</code> if the supplied
      * text maps to a boolean value, or <code>null</code> otherwise.
      */
-    public String testBoolean(String value) {
-        String s = value.toLowerCase(Locale.ENGLISH);
+    public String testBoolean(final String value) {
+        final String s = value.toLowerCase(Locale.ENGLISH);
 
         if (s.equals("true") || s.equals("on") || s.equals("yes")) {
             return "true";
@@ -1234,8 +1240,8 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public byte getByte(String key) {
-        Byte b = getByte(key, null);
+    public byte getByte(final String key) {
+        final Byte b = getByte(key, null);
         if (b != null) {
             return b.byteValue();
         } else {
@@ -1254,7 +1260,7 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public byte getByte(String key, byte defaultValue) {
+    public byte getByte(final String key, final byte defaultValue) {
         return getByte(key, Byte.valueOf(defaultValue)).byteValue();
     }
 
@@ -1270,14 +1276,14 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public Byte getByte(String key, Byte defaultValue) {
-        Object value = get(key);
+    public Byte getByte(final String key, final Byte defaultValue) {
+        final Object value = get(key);
 
         if (value instanceof Byte) {
             return (Byte) value;
             
         } else if (value instanceof String) {
-            Byte b = new Byte((String) value);
+            final Byte b = new Byte((String) value);
             super.put(key, b);
             return b;
             
@@ -1304,8 +1310,8 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public short getShort(String key) {
-        Short s = getShort(key, null);
+    public short getShort(final String key) {
+        final Short s = getShort(key, null);
         if (s != null) {
             return s.shortValue();
         } else {
@@ -1324,7 +1330,7 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public short getShort(String key, short defaultValue) {
+    public short getShort(final String key, final short defaultValue) {
         return getShort(key, Short.valueOf(defaultValue)).shortValue();
     }
 
@@ -1340,14 +1346,14 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public Short getShort(String key, Short defaultValue) {
-        Object value = get(key);
+    public Short getShort(final String key, final Short defaultValue) {
+        final Object value = get(key);
 
         if (value instanceof Short) {
             return (Short) value;
             
         } else if (value instanceof String) {
-            Short s = new Short((String) value);
+            final Short s = new Short((String) value);
             super.put(key, s);
             return s;
             
@@ -1369,7 +1375,7 @@ public class ExtendedProperties extends 
      * @param name The resource name.
      * @return The value of the resource as an integer.
      */
-    public int getInt(String name) {
+    public int getInt(final String name) {
         return getInteger(name);
     }
 
@@ -1381,7 +1387,7 @@ public class ExtendedProperties extends 
      * @param def The default value of the resource.
      * @return The value of the resource as an integer.
      */
-    public int getInt(String name, int def) {
+    public int getInt(final String name, final int def) {
         return getInteger(name, def);
     }
 
@@ -1397,8 +1403,8 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public int getInteger(String key) {
-        Integer i = getInteger(key, null);
+    public int getInteger(final String key) {
+        final Integer i = getInteger(key, null);
         if (i != null) {
             return i.intValue();
         } else {
@@ -1417,8 +1423,8 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public int getInteger(String key, int defaultValue) {
-        Integer i = getInteger(key, null);
+    public int getInteger(final String key, final int defaultValue) {
+        final Integer i = getInteger(key, null);
 
         if (i == null) {
             return defaultValue;
@@ -1438,14 +1444,14 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public Integer getInteger(String key, Integer defaultValue) {
-        Object value = get(key);
+    public Integer getInteger(final String key, final Integer defaultValue) {
+        final Object value = get(key);
 
         if (value instanceof Integer) {
             return (Integer) value;
             
         } else if (value instanceof String) {
-            Integer i = new Integer((String) value);
+            final Integer i = new Integer((String) value);
             super.put(key, i);
             return i;
             
@@ -1472,8 +1478,8 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public long getLong(String key) {
-        Long l = getLong(key, null);
+    public long getLong(final String key) {
+        final Long l = getLong(key, null);
         if (l != null) {
             return l.longValue();
         } else {
@@ -1492,7 +1498,7 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public long getLong(String key, long defaultValue) {
+    public long getLong(final String key, final long defaultValue) {
         return getLong(key, new Long(defaultValue)).longValue();
     }
 
@@ -1508,14 +1514,14 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public Long getLong(String key, Long defaultValue) {
-        Object value = get(key);
+    public Long getLong(final String key, final Long defaultValue) {
+        final Object value = get(key);
 
         if (value instanceof Long) {
             return (Long) value;
             
         } else if (value instanceof String) {
-            Long l = new Long((String) value);
+            final Long l = new Long((String) value);
             super.put(key, l);
             return l;
             
@@ -1542,8 +1548,8 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public float getFloat(String key) {
-        Float f = getFloat(key, null);
+    public float getFloat(final String key) {
+        final Float f = getFloat(key, null);
         if (f != null) {
             return f.floatValue();
         } else {
@@ -1562,7 +1568,7 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public float getFloat(String key, float defaultValue) {
+    public float getFloat(final String key, final float defaultValue) {
         return getFloat(key, new Float(defaultValue)).floatValue();
     }
 
@@ -1578,14 +1584,14 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public Float getFloat(String key, Float defaultValue) {
-        Object value = get(key);
+    public Float getFloat(final String key, final Float defaultValue) {
+        final Object value = get(key);
 
         if (value instanceof Float) {
             return (Float) value;
             
         } else if (value instanceof String) {
-            Float f = new Float((String) value);
+            final Float f = new Float((String) value);
             super.put(key, f);
             return f;
             
@@ -1612,8 +1618,8 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public double getDouble(String key) {
-        Double d = getDouble(key, null);
+    public double getDouble(final String key) {
+        final Double d = getDouble(key, null);
         if (d != null) {
             return d.doubleValue();
         } else {
@@ -1632,7 +1638,7 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public double getDouble(String key, double defaultValue) {
+    public double getDouble(final String key, final double defaultValue) {
         return getDouble(key, new Double(defaultValue)).doubleValue();
     }
 
@@ -1648,14 +1654,14 @@ public class ExtendedProperties extends 
      * @throws NumberFormatException is thrown if the value mapped
      * by the key has not a valid number format.
      */
-    public Double getDouble(String key, Double defaultValue) {
-        Object value = get(key);
+    public Double getDouble(final String key, final Double defaultValue) {
+        final Object value = get(key);
 
         if (value instanceof Double) {
             return (Double) value;
             
         } else if (value instanceof String) {
-            Double d = new Double((String) value);
+            final Double d = new Double((String) value);
             super.put(key, d);
             return d;
             
@@ -1683,10 +1689,11 @@ public class ExtendedProperties extends 
      * @param props  the properties object to convert
      * @return new ExtendedProperties created from props
      */
-    public static ExtendedProperties convertProperties(Properties props) {
-        ExtendedProperties c = new ExtendedProperties();
+    public static ExtendedProperties convertProperties(final Properties props) {
+        final ExtendedProperties c = new ExtendedProperties();
 
         @SuppressWarnings("unchecked") // Properties are supposed to have string keys ...
+        final
         Enumeration<String> e = (Enumeration<String>) props.propertyNames();
         // Unfortunately PMD 4.3 cannot handle the original code where the @Suppress
         // was in the for loop:
@@ -1694,8 +1701,8 @@ public class ExtendedProperties extends 
         //    Enumeration<String> e = (Enumeration<String>) props.propertyNames(); e.hasMoreElements();) {
         //        String s = e.nextElement(); // ... if props does not, this line would fail anyway ...
         while (e.hasMoreElements()) {
-            String s = e.nextElement(); // ... if props does not, this line would fail anyway ...
-            String value = props.getProperty(s);
+            final String s = e.nextElement(); // ... if props does not, this line would fail anyway ...
+            final String value = props.getProperty(s);
             if(value != null) {
                 c.setProperty(s, value);
             }
@@ -1713,8 +1720,8 @@ public class ExtendedProperties extends 
      * @return old value of the property
      */
     @Override
-    public Object put(String key, Object value) {
-        Object ret = getProperty(key);
+    public Object put(final String key, final Object value) {
+        final Object ret = getProperty(key);
         addProperty(key, value);
         return ret;
     }
@@ -1727,16 +1734,17 @@ public class ExtendedProperties extends 
      * @param map full of key/value pair data
      */
     @Override
-    public void putAll(Map<? extends String, ? extends Object> map) {
+    public void putAll(final Map<? extends String, ? extends Object> map) {
         if (map instanceof ExtendedProperties) {
-            for (Iterator<String> it = ((ExtendedProperties) map).getKeys(); it.hasNext(); ) {
-                String key = it.next();
+            for (final Iterator<String> it = ((ExtendedProperties) map).getKeys(); it.hasNext(); ) {
+                final String key = it.next();
                 put(key, map.get(key));
             }
         } else {
             @SuppressWarnings("unchecked") // OK to downcast here
+            final
             Map<String, Object> mapso = (Map<String,Object>) map;
-            for (java.util.Map.Entry<String, Object> entry : mapso.entrySet()) {
+            for (final java.util.Map.Entry<String, Object> entry : mapso.entrySet()) {
                 put(entry.getKey(), entry.getValue());
             }
         }
@@ -1751,9 +1759,9 @@ public class ExtendedProperties extends 
      * @return old value of the property
      */
     @Override
-    public Object remove(Object key) {
-        String strKey = String.valueOf(key);
-        Object ret = getProperty(strKey);
+    public Object remove(final Object key) {
+        final String strKey = String.valueOf(key);
+        final Object ret = getProperty(strKey);
         clearProperty(strKey);
         return ret;
     }

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FactoryUtils.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FactoryUtils.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FactoryUtils.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FactoryUtils.java Mon Jan  7 17:15:14 2013
@@ -82,7 +82,7 @@ public class FactoryUtils {
      * @param constantToReturn  the constant object to return each time in the factory
      * @return the <code>constant</code> factory.
      */
-    public static <T> Factory<T> constantFactory(T constantToReturn) {
+    public static <T> Factory<T> constantFactory(final T constantToReturn) {
         return ConstantFactory.constantFactory(constantToReturn);
     }
 
@@ -104,7 +104,7 @@ public class FactoryUtils {
      * the {@code prototype} is {@code null}
      * @throws IllegalArgumentException if the prototype cannot be cloned
      */
-    public static <T> Factory<T> prototypeFactory(T prototype) {
+    public static <T> Factory<T> prototypeFactory(final T prototype) {
         return PrototypeFactory.<T>prototypeFactory(prototype);
     }
 
@@ -119,7 +119,7 @@ public class FactoryUtils {
      * @return the <code>reflection</code> factory
      * @throws IllegalArgumentException if the classToInstantiate is null
      */
-    public static <T> Factory<T> instantiateFactory(Class<T> classToInstantiate) {
+    public static <T> Factory<T> instantiateFactory(final Class<T> classToInstantiate) {
         return InstantiateFactory.instantiateFactory(classToInstantiate, null, null);
     }
 
@@ -138,7 +138,7 @@ public class FactoryUtils {
      * @throws IllegalArgumentException if the paramTypes and args don't match
      * @throws IllegalArgumentException if the constructor doesn't exist
      */
-    public static <T> Factory<T> instantiateFactory(Class<T> classToInstantiate, Class<?>[] paramTypes, Object[] args) {
+    public static <T> Factory<T> instantiateFactory(final Class<T> classToInstantiate, final Class<?>[] paramTypes, final Object[] args) {
         return InstantiateFactory.instantiateFactory(classToInstantiate, paramTypes, args);
     }
 

Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FunctorException.java
URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FunctorException.java?rev=1429905&r1=1429904&r2=1429905&view=diff
==============================================================================
--- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FunctorException.java (original)
+++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/FunctorException.java Mon Jan  7 17:15:14 2013
@@ -42,7 +42,7 @@ public class FunctorException extends Ru
      *
      * @param msg  the error message.
      */
-    public FunctorException(String msg) {
+    public FunctorException(final String msg) {
         super(msg);
     }
 
@@ -53,7 +53,7 @@ public class FunctorException extends Ru
      * @param rootCause  the exception or error that caused this exception
      *                   to be thrown.
      */
-    public FunctorException(Throwable rootCause) {
+    public FunctorException(final Throwable rootCause) {
         super(rootCause);
     }
 
@@ -65,7 +65,7 @@ public class FunctorException extends Ru
      * @param rootCause  the exception or error that caused this exception
      *                   to be thrown.
      */
-    public FunctorException(String msg, Throwable rootCause) {
+    public FunctorException(final String msg, final Throwable rootCause) {
         super(msg, rootCause);
     }
 



Mime
View raw message