commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t.@apache.org
Subject svn commit: r1420402 - in /commons/proper/email/trunk/src/main/java/org/apache/commons/mail: HtmlEmail.java MultiPartEmail.java
Date Tue, 11 Dec 2012 20:59:18 GMT
Author: tn
Date: Tue Dec 11 20:59:15 2012
New Revision: 1420402

URL: http://svn.apache.org/viewvc?rev=1420402&view=rev
Log:
Add PMD suppress comments, minor formatting.

Modified:
    commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java
    commons/proper/email/trunk/src/main/java/org/apache/commons/mail/MultiPartEmail.java

Modified: commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java?rev=1420402&r1=1420401&r2=1420402&view=diff
==============================================================================
--- commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java (original)
+++ commons/proper/email/trunk/src/main/java/org/apache/commons/mail/HtmlEmail.java Tue Dec
11 20:59:15 2012
@@ -304,7 +304,7 @@ public class HtmlEmail extends MultiPart
                     is.close();
                 }
             }
-            catch (IOException ioe)
+            catch (IOException ioe) // NOPMD
             { /* sigh */ }
         }
 

Modified: commons/proper/email/trunk/src/main/java/org/apache/commons/mail/MultiPartEmail.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/main/java/org/apache/commons/mail/MultiPartEmail.java?rev=1420402&r1=1420401&r2=1420402&view=diff
==============================================================================
--- commons/proper/email/trunk/src/main/java/org/apache/commons/mail/MultiPartEmail.java (original)
+++ commons/proper/email/trunk/src/main/java/org/apache/commons/mail/MultiPartEmail.java Tue
Dec 11 20:59:15 2012
@@ -241,10 +241,10 @@ public class MultiPartEmail extends Emai
                 {
                     body.getContent();
                 }
-                catch (IOException e)
+                catch (IOException e) // NOPMD
                 {
-                    // do nothing here.  content will be set to an empty string
-                    // as a result.
+                    // do nothing here.
+                    // content will be set to an empty string as a result.
                     // (Should this really be rethrown as an email exception?)
                     // throw new EmailException(e);
                 }
@@ -290,9 +290,7 @@ public class MultiPartEmail extends Emai
         }
         catch (IOException e)
         {
-            throw new EmailException(
-                "Cannot attach file \"" + fileName + "\"",
-                e);
+            throw new EmailException("Cannot attach file \"" + fileName + "\"", e);
         }
     }
 
@@ -326,8 +324,7 @@ public class MultiPartEmail extends Emai
                 File file = new File(fileName);
                 if (!file.exists())
                 {
-                    throw new IOException(
-                        "\"" + fileName + "\" does not exist");
+                    throw new IOException("\"" + fileName + "\" does not exist");
                 }
                 result =
                     attach(
@@ -338,9 +335,7 @@ public class MultiPartEmail extends Emai
             }
             catch (IOException e)
             {
-                throw new EmailException(
-                    "Cannot attach file \"" + fileName + "\"",
-                    e);
+                throw new EmailException("Cannot attach file \"" + fileName + "\"", e);
             }
         }
         else



Mime
View raw message