Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C1112D940 for ; Tue, 6 Nov 2012 13:12:35 +0000 (UTC) Received: (qmail 35380 invoked by uid 500); 6 Nov 2012 13:12:35 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 35139 invoked by uid 500); 6 Nov 2012 13:12:34 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 35006 invoked by uid 99); 6 Nov 2012 13:12:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Nov 2012 13:12:34 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Nov 2012 13:12:33 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 47BD923888E4 for ; Tue, 6 Nov 2012 13:12:13 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1406122 - /commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java Date: Tue, 06 Nov 2012 13:12:13 -0000 To: commits@commons.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20121106131213.47BD923888E4@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ggregory Date: Tue Nov 6 13:12:12 2012 New Revision: 1406122 URL: http://svn.apache.org/viewvc?rev=1406122&view=rev Log: Refactor some duplicate code. Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java Modified: commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java?rev=1406122&r1=1406121&r2=1406122&view=diff ============================================================================== --- commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java (original) +++ commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/time/FastDatePrinter.java Tue Nov 6 13:12:12 2012 @@ -394,19 +394,28 @@ public class FastDatePrinter implements */ @Override public String format(long millis) { - Calendar c = new GregorianCalendar(mTimeZone, mLocale); // hard code GregorianCalendar + Calendar c = newCalendar(); // hard code GregorianCalendar c.setTimeInMillis(millis); + return applyRulesToString(c); + } + + private String applyRulesToString(Calendar c) { return applyRules(c, new StringBuffer(mMaxLengthEstimate)).toString(); } + private GregorianCalendar newCalendar() { + // hard code GregorianCalendar + return new GregorianCalendar(mTimeZone, mLocale); + } + /* (non-Javadoc) * @see org.apache.commons.lang3.time.DatePrinter#format(java.util.Date) */ @Override public String format(Date date) { - Calendar c = new GregorianCalendar(mTimeZone, mLocale); // hard code GregorianCalendar + Calendar c = newCalendar(); // hard code GregorianCalendar c.setTime(date); - return applyRules(c, new StringBuffer(mMaxLengthEstimate)).toString(); + return applyRulesToString(c); } /* (non-Javadoc) @@ -430,7 +439,7 @@ public class FastDatePrinter implements */ @Override public StringBuffer format(Date date, StringBuffer buf) { - Calendar c = new GregorianCalendar(mTimeZone, mLocale); // hard code GregorianCalendar + Calendar c = newCalendar(); // hard code GregorianCalendar c.setTime(date); return applyRules(c, buf); }