commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ggreg...@apache.org
Subject svn commit: r1379804 - in /commons/proper/codec/trunk/src: changes/changes.xml main/java/org/apache/commons/codec/digest/UnixCrypt.java
Date Sat, 01 Sep 2012 16:41:11 GMT
Author: ggregory
Date: Sat Sep  1 16:41:11 2012
New Revision: 1379804

URL: http://svn.apache.org/viewvc?rev=1379804&view=rev
Log:
[CODEC-151] Remove unnecessary attempt to fill up the salt variable in UnixCrypt

Modified:
    commons/proper/codec/trunk/src/changes/changes.xml
    commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java

Modified: commons/proper/codec/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/changes/changes.xml?rev=1379804&r1=1379803&r2=1379804&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/changes/changes.xml (original)
+++ commons/proper/codec/trunk/src/changes/changes.xml Sat Sep  1 16:41:11 2012
@@ -51,6 +51,9 @@ The <action> type attribute can be add,u
     </release>
     -->
     <release version="1.7" date="TBD" description="Feature and fix release.">
+      <action issue="CODEC-151" dev="ggregory" type="add" due-to="lathspell">
+        Remove unnecessary attempt to fill up the salt variable in UnixCrypt.
+      </action>
       <action issue="CODEC-153" dev="ggregory" type="add" due-to="ggregory">
         Create a class MessageDigestAlgorithms to define standard algorithm names.
       </action>

Modified: commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java?rev=1379804&r1=1379803&r2=1379804&view=diff
==============================================================================
--- commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
(original)
+++ commons/proper/codec/trunk/src/main/java/org/apache/commons/codec/digest/UnixCrypt.java
Sat Sep  1 16:41:11 2012
@@ -245,10 +245,6 @@ public class UnixCrypt {
             throw new IllegalArgumentException("Invalid salt value: " + salt);
         }
 
-        for (; salt.length() < 2; salt = salt + "A") {
-            // NOOP
-        }
-
         StringBuilder buffer = new StringBuilder("             ");
         char charZero = salt.charAt(0);
         char charOne = salt.charAt(1);



Mime
View raw message