commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ohe...@apache.org
Subject svn commit: r1366930 - in /commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration: DefaultConfigurationBuilder.java DefaultFileSystem.java
Date Sun, 29 Jul 2012 20:05:37 GMT
Author: oheger
Date: Sun Jul 29 20:05:36 2012
New Revision: 1366930

URL: http://svn.apache.org/viewvc?rev=1366930&view=rev
Log:
Checkstyle: Removed empty statements (replaced them by log statements which actually makes
sense in these cases).

Modified:
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java
    commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultFileSystem.java

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java?rev=1366930&r1=1366929&r2=1366930&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultConfigurationBuilder.java
Sun Jul 29 20:05:36 2012
@@ -1351,6 +1351,8 @@ public class DefaultConfigurationBuilder
                         catch (Exception ex2)
                         {
                             // Ignore exception, return null in this case
+                            logger.warn("Could not create instance of optional configuration
"
+                                    + tagName, ex2);
                         }
                     }
                     return null;

Modified: commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultFileSystem.java
URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultFileSystem.java?rev=1366930&r1=1366929&r2=1366930&view=diff
==============================================================================
--- commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultFileSystem.java
(original)
+++ commons/proper/configuration/trunk/src/main/java/org/apache/commons/configuration/DefaultFileSystem.java
Sun Jul 29 20:05:36 2012
@@ -16,19 +16,19 @@
  */
 package org.apache.commons.configuration;
 
-import org.apache.commons.logging.Log;
-import org.apache.commons.logging.LogFactory;
-
-import java.io.InputStream;
 import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.FileOutputStream;
 import java.io.IOException;
+import java.io.InputStream;
 import java.io.OutputStream;
-import java.io.FileOutputStream;
-import java.io.FileNotFoundException;
-import java.net.URL;
-import java.net.URLConnection;
 import java.net.HttpURLConnection;
 import java.net.MalformedURLException;
+import java.net.URL;
+import java.net.URLConnection;
+
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
 
 /**
  * FileSystem that uses java.io.File or HttpClient
@@ -170,6 +170,12 @@ public class DefaultFileSystem extends F
                 catch (Exception e)
                 {
                     // simply ignore it and return null
+                    if (log.isDebugEnabled())
+                    {
+                        log.debug(String.format("Could not determine URL for "
+                                + "basePath = %s, fileName = %s.", basePath,
+                                fileName), e);
+                    }
                 }
             }
         }



Mime
View raw message