commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1361735 - /commons/proper/pool/trunk/findbugs-exclude-filter.xml
Date Sun, 15 Jul 2012 17:18:36 GMT
Author: markt
Date: Sun Jul 15 17:18:36 2012
New Revision: 1361735

URL: http://svn.apache.org/viewvc?rev=1361735&view=rev
Log:
Clean-out filters required for Pool 1.x, ready to add those required for pool2

Modified:
    commons/proper/pool/trunk/findbugs-exclude-filter.xml

Modified: commons/proper/pool/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/findbugs-exclude-filter.xml?rev=1361735&r1=1361734&r2=1361735&view=diff
==============================================================================
--- commons/proper/pool/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/pool/trunk/findbugs-exclude-filter.xml Sun Jul 15 17:18:36 2012
@@ -22,27 +22,4 @@
   put here to instruct findbugs to ignore them.
 -->
 <FindBugsFilter>
-  <!-- findbugs thinks this is naked, but it is not -->
-  <Match>
-    <Class name="org.apache.commons.pool.impl.GenericKeyedObjectPool" />
-    <Method name="allocate"/>
-    <Bug pattern="NN_NAKED_NOTIFY" />
-  </Match>
-  <!-- Iteration has to be over keys here -->
-  <Match>
-    <Class name="org.apache.commons.pool.impl.GenericKeyedObjectPool" />
-    <Method name="destroy"/>
-    <Bug pattern="WMI_WRONG_MAP_ITERATOR" />
-  </Match>
-  <!-- compareTo is implemented consistently with object equals in this case -->
-  <Match>
-    <Class name="org.apache.commons.pool.impl.GenericKeyedObjectPool$ObjectTimestampPair"
/>
-    <Bug pattern="EQ_COMPARETO_USE_OBJECT_EQUALS" />
-  </Match>
-  <!-- findbugs thinks this is naked, but it is not -->
-  <Match>
-    <Class name="org.apache.commons.pool.impl.GenericObjectPool" />
-    <Method name="allocate"/>
-    <Bug pattern="NN_NAKED_NOTIFY" />
-  </Match>
 </FindBugsFilter>



Mime
View raw message