Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37E2CC188 for ; Fri, 11 May 2012 00:38:54 +0000 (UTC) Received: (qmail 32046 invoked by uid 500); 11 May 2012 00:38:54 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 31985 invoked by uid 500); 11 May 2012 00:38:53 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 31978 invoked by uid 99); 11 May 2012 00:38:53 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 May 2012 00:38:53 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 May 2012 00:38:51 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 8EC152388865 for ; Fri, 11 May 2012 00:38:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1336983 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math3/linear/ArrayRealVector.java main/java/org/apache/commons/math3/util/DefaultTransformer.java test/java/org/apache/commons/math3/util/PairTest.java Date: Fri, 11 May 2012 00:38:30 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120511003830.8EC152388865@eris.apache.org> Author: sebb Date: Fri May 11 00:38:29 2012 New Revision: 1336983 URL: http://svn.apache.org/viewvc?rev=1336983&view=rev Log: Redundant check for null; null is not an instanceof any Object Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/ArrayRealVector.java commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/DefaultTransformer.java commons/proper/math/trunk/src/test/java/org/apache/commons/math3/util/PairTest.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/ArrayRealVector.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/ArrayRealVector.java?rev=1336983&r1=1336982&r2=1336983&view=diff ============================================================================== --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/ArrayRealVector.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/linear/ArrayRealVector.java Fri May 11 00:38:29 2012 @@ -823,7 +823,7 @@ public class ArrayRealVector extends Rea return true; } - if (other == null || !(other instanceof RealVector)) { + if (!(other instanceof RealVector)) { return false; } Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/DefaultTransformer.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/DefaultTransformer.java?rev=1336983&r1=1336982&r2=1336983&view=diff ============================================================================== --- commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/DefaultTransformer.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math3/util/DefaultTransformer.java Fri May 11 00:38:29 2012 @@ -69,9 +69,6 @@ public class DefaultTransformer implemen if (this == other) { return true; } - if (other == null) { - return false; - } return other instanceof DefaultTransformer; } Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math3/util/PairTest.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math3/util/PairTest.java?rev=1336983&r1=1336982&r2=1336983&view=diff ============================================================================== --- commons/proper/math/trunk/src/test/java/org/apache/commons/math3/util/PairTest.java (original) +++ commons/proper/math/trunk/src/test/java/org/apache/commons/math3/util/PairTest.java Fri May 11 00:38:29 2012 @@ -78,9 +78,6 @@ public class PairTest { @Override public boolean equals(Object o) { - if (o == null) { - return false; - } if (!(o instanceof MyInteger)) { return false; } else {