Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D093A995F for ; Tue, 27 Mar 2012 01:07:54 +0000 (UTC) Received: (qmail 62120 invoked by uid 500); 27 Mar 2012 01:07:54 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 62040 invoked by uid 500); 27 Mar 2012 01:07:54 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 62032 invoked by uid 99); 27 Mar 2012 01:07:54 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2012 01:07:54 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Mar 2012 01:07:51 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 076DE23889FD for ; Tue, 27 Mar 2012 01:07:31 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1305700 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java Date: Tue, 27 Mar 2012 01:07:30 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120327010731.076DE23889FD@eris.apache.org> Author: sebb Date: Tue Mar 27 01:07:30 2012 New Revision: 1305700 URL: http://svn.apache.org/viewvc?rev=1305700&view=rev Log: Calculate the booleans once; prepares for CSV-78 Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java?rev=1305700&r1=1305699&r2=1305700&view=diff ============================================================================== --- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java (original) +++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java Tue Mar 27 01:07:30 2012 @@ -41,6 +41,9 @@ public class CSVFormat implements Serial private final String lineSeparator; // for outputs private final String[] header; + private final boolean isEscaping; + private final boolean isCommentingEnabled; + private final boolean isEncapsulating; /** * Constant char to be used for disabling comments, escapes and encapsulation. @@ -156,6 +159,9 @@ public class CSVFormat implements Serial this.emptyLinesIgnored = emptyLinesIgnored; this.lineSeparator = lineSeparator; this.header = header; + this.isEncapsulating = encapsulator != DISABLED; + this.isCommentingEnabled = commentStart != DISABLED; + this.isEscaping = escape != DISABLED; } /** @@ -243,7 +249,7 @@ public class CSVFormat implements Serial } boolean isEncapsulating() { - return this.encapsulator != DISABLED; + return isEncapsulating; } /** @@ -276,7 +282,7 @@ public class CSVFormat implements Serial * @return true is comments are supported, false otherwise */ public boolean isCommentingEnabled() { - return this.commentStart != DISABLED; + return isCommentingEnabled; } /** @@ -304,7 +310,7 @@ public class CSVFormat implements Serial } boolean isEscaping() { - return this.escape != DISABLED; + return isEscaping; } /**