Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5043F995E for ; Mon, 19 Mar 2012 21:55:32 +0000 (UTC) Received: (qmail 14111 invoked by uid 500); 19 Mar 2012 21:55:32 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 14046 invoked by uid 500); 19 Mar 2012 21:55:32 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 14037 invoked by uid 99); 19 Mar 2012 21:55:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2012 21:55:31 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Mar 2012 21:55:30 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 8A60D2388CBA for ; Mon, 19 Mar 2012 21:55:10 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1302675 - in /commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export: DefaultNamedExportSelector.java DotExporter.java GraphMLExporter.java Date: Mon, 19 Mar 2012 21:55:10 -0000 To: commits@commons.apache.org From: simonetripodi@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20120319215510.8A60D2388CBA@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: simonetripodi Date: Mon Mar 19 21:55:10 2012 New Revision: 1302675 URL: http://svn.apache.org/viewvc?rev=1302675&view=rev Log: shortcut constructors not needed reduced concrete exporters constructors visibility - they can be instantiated only in the package Modified: commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java Modified: commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java URL: http://svn.apache.org/viewvc/commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java?rev=1302675&r1=1302674&r2=1302675&view=diff ============================================================================== --- commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java (original) +++ commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java Mon Mar 19 21:55:10 2012 @@ -26,7 +26,7 @@ public final class DefaultNamedExportSel { private final Graph graph; - + public DefaultNamedExportSelector(Graph graph) { this.graph = graph; } @@ -34,11 +34,11 @@ public final class DefaultNamedExportSel public DotExporter usingDotNotation() throws GraphExportException { - return new DotExporter( graph ); + return new DotExporter( graph, null ); } - + public DotExporter usingDotNotation(String name) - throws GraphExportException + throws GraphExportException { return new DotExporter( graph, name ); } @@ -46,11 +46,11 @@ public final class DefaultNamedExportSel public GraphMLExporter usingGraphMLFormat() throws GraphExportException { - return new GraphMLExporter( graph ); + return new GraphMLExporter( graph, null ); } - + public GraphMLExporter usingGraphMLFormat(String name) - throws GraphExportException + throws GraphExportException { return new GraphMLExporter( graph, name ); } Modified: commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java URL: http://svn.apache.org/viewvc/commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java?rev=1302675&r1=1302674&r2=1302675&view=diff ============================================================================== --- commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java (original) +++ commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java Mon Mar 19 21:55:10 2012 @@ -45,12 +45,7 @@ final class DotExporter private static final String DICONNECTOR = "->"; - public DotExporter( Graph graph ) - { - super( graph ); - } - - public DotExporter( Graph graph, String name ) + DotExporter( Graph graph, String name ) { super( graph, name ); } Modified: commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java URL: http://svn.apache.org/viewvc/commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java?rev=1302675&r1=1302674&r2=1302675&view=diff ============================================================================== --- commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java (original) +++ commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java Mon Mar 19 21:55:10 2012 @@ -76,12 +76,7 @@ final class GraphMLExporter private static final String WEIGHT = "weight"; - public GraphMLExporter( Graph graph ) - { - super( graph ); - } - - public GraphMLExporter( Graph graph, String name ) + GraphMLExporter( Graph graph, String name ) { super( graph, name ); }