commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simonetrip...@apache.org
Subject svn commit: r1302675 - in /commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export: DefaultNamedExportSelector.java DotExporter.java GraphMLExporter.java
Date Mon, 19 Mar 2012 21:55:10 GMT
Author: simonetripodi
Date: Mon Mar 19 21:55:10 2012
New Revision: 1302675

URL: http://svn.apache.org/viewvc?rev=1302675&view=rev
Log:
shortcut constructors not needed
reduced concrete exporters constructors visibility - they can be instantiated only in the
package

Modified:
    commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java
    commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java
    commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java

Modified: commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java
URL: http://svn.apache.org/viewvc/commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java?rev=1302675&r1=1302674&r2=1302675&view=diff
==============================================================================
--- commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java
(original)
+++ commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DefaultNamedExportSelector.java
Mon Mar 19 21:55:10 2012
@@ -26,7 +26,7 @@ public final class DefaultNamedExportSel
 {
 
     private final Graph<V, E> graph;
-    
+
     public DefaultNamedExportSelector(Graph<V, E> graph) {
     	this.graph = graph;
 	}
@@ -34,11 +34,11 @@ public final class DefaultNamedExportSel
 	public DotExporter<V, E> usingDotNotation()
         throws GraphExportException
     {
-        return new DotExporter<V, E>( graph );
+        return new DotExporter<V, E>( graph, null );
     }
-	
+
 	public DotExporter<V, E> usingDotNotation(String name)
-			throws GraphExportException 
+			throws GraphExportException
 	{
 		return new DotExporter<V, E>( graph, name );
 	}
@@ -46,11 +46,11 @@ public final class DefaultNamedExportSel
     public GraphMLExporter<V, E> usingGraphMLFormat()
         throws GraphExportException
     {
-        return new GraphMLExporter<V, E>( graph );
+        return new GraphMLExporter<V, E>( graph, null );
     }
-    
+
 	public GraphMLExporter<V, E> usingGraphMLFormat(String name)
-			throws GraphExportException 
+			throws GraphExportException
 	{
 		return new GraphMLExporter<V, E>( graph, name );
 	}

Modified: commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java
URL: http://svn.apache.org/viewvc/commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java?rev=1302675&r1=1302674&r2=1302675&view=diff
==============================================================================
--- commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java
(original)
+++ commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/DotExporter.java
Mon Mar 19 21:55:10 2012
@@ -45,12 +45,7 @@ final class DotExporter<V, E>
 
     private static final String DICONNECTOR = "->";
 
-    public DotExporter( Graph<V, E> graph )
-    {
-        super( graph );
-    }
-
-    public DotExporter( Graph<V, E> graph, String name )
+    DotExporter( Graph<V, E> graph, String name )
     {
         super( graph, name );
     }

Modified: commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java
URL: http://svn.apache.org/viewvc/commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java?rev=1302675&r1=1302674&r2=1302675&view=diff
==============================================================================
--- commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java
(original)
+++ commons/sandbox/graph/branches/exporters-with-mappers/src/main/java/org/apache/commons/graph/export/GraphMLExporter.java
Mon Mar 19 21:55:10 2012
@@ -76,12 +76,7 @@ final class GraphMLExporter<V, E>
 
     private static final String WEIGHT = "weight";
 
-    public GraphMLExporter( Graph<V, E> graph )
-    {
-        super( graph );
-    }
-
-    public GraphMLExporter( Graph<V, E> graph, String name )
+    GraphMLExporter( Graph<V, E> graph, String name )
     {
         super( graph, name );
     }



Mime
View raw message