commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1302520 - /commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Pass3bVerifier.java
Date Mon, 19 Mar 2012 15:59:58 GMT
Author: sebb
Date: Mon Mar 19 15:59:58 2012
New Revision: 1302520

URL: http://svn.apache.org/viewvc?rev=1302520&view=rev
Log:
Fix generics warnings

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Pass3bVerifier.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Pass3bVerifier.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Pass3bVerifier.java?rev=1302520&r1=1302519&r2=1302520&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Pass3bVerifier.java
(original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/bcel/verifier/structurals/Pass3bVerifier.java
Mon Mar 19 15:59:58 2012
@@ -153,11 +153,13 @@ public final class Pass3bVerifier extend
 				icq.remove(0);
 			}
 			
-			ArrayList<InstructionContext> oldchain = (ArrayList<InstructionContext>) (ec.clone());
-			ArrayList<InstructionContext> newchain = (ArrayList<InstructionContext>) (ec.clone());
+			@SuppressWarnings("unchecked") // ec is of type ArrayList<InstructionContext>
+            ArrayList<InstructionContext> oldchain = (ArrayList<InstructionContext>)
(ec.clone());
+			@SuppressWarnings("unchecked") // ec is of type ArrayList<InstructionContext>
+            ArrayList<InstructionContext> newchain = (ArrayList<InstructionContext>)
(ec.clone());
 			newchain.add(u);
 
-			if ((u.getInstruction().getInstruction()) instanceof RET){
+            if ((u.getInstruction().getInstruction()) instanceof RET){
 //System.err.println(u);
 				// We can only follow _one_ successor, the one after the
 				// JSR that was recently executed.
@@ -195,7 +197,9 @@ public final class Pass3bVerifier extend
 				}
 				
 				if (theSuccessor.execute(u.getOutFrame(oldchain), newchain, icv, ev)){
-					icq.add(theSuccessor, (ArrayList<InstructionContext>) newchain.clone());
+		            @SuppressWarnings("unchecked") // newchain is already of type ArrayList<InstructionContext>
+                    ArrayList<InstructionContext> newchainClone = (ArrayList<InstructionContext>)
newchain.clone();
+					icq.add(theSuccessor, newchainClone);
 				}
 			}
 			else{// "not a ret"
@@ -205,7 +209,9 @@ public final class Pass3bVerifier extend
 				for (int s=0; s<succs.length; s++){
 					InstructionContext v = succs[s];
 					if (v.execute(u.getOutFrame(oldchain), newchain, icv, ev)){
-						icq.add(v, (ArrayList<InstructionContext>) newchain.clone());
+	                    @SuppressWarnings("unchecked") // newchain is already of type ArrayList<InstructionContext>
+	                    ArrayList<InstructionContext> newchainClone = (ArrayList<InstructionContext>)
newchain.clone();
+						icq.add(v, newchainClone);
 					}
 				}
 			}// end "not a ret"



Mime
View raw message