Return-Path: 
 <commits-return-25251-apmail-commons-commits-archive=commons.apache.org@commons.apache.org>
X-Original-To: apmail-commons-commits-archive@minotaur.apache.org
Delivered-To: apmail-commons-commits-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 93B989DB2
	for <apmail-commons-commits-archive@minotaur.apache.org>;
 Mon, 13 Feb 2012 03:03:18 +0000 (UTC)
Received: (qmail 97213 invoked by uid 500); 13 Feb 2012 03:03:14 -0000
Delivered-To: apmail-commons-commits-archive@commons.apache.org
Received: (qmail 96702 invoked by uid 500); 13 Feb 2012 03:02:57 -0000
Mailing-List: contact commits-help@commons.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@commons.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@commons.apache.org>
List-Post: <mailto:commits@commons.apache.org>
List-Id: <commits.commons.apache.org>
Reply-To: dev@commons.apache.org
Delivered-To: mailing list commits@commons.apache.org
Received: (qmail 96684 invoked by uid 99); 13 Feb 2012 03:02:54 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2012 03:02:54 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=5.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Feb 2012 03:02:51 +0000
Received: from eris.apache.org (localhost [127.0.0.1])
	by eris.apache.org (Postfix) with ESMTP id 1F8E8238889B
	for <commits@commons.apache.org>; Mon, 13 Feb 2012 03:02:30 +0000 (UTC)
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: svn commit: r1243400 - in /commons/proper/net/trunk:
 findbugs-exclude-filter.xml
 src/main/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParser.java
 src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java
Date: Mon, 13 Feb 2012 03:02:29 -0000
To: commits@commons.apache.org
From: sebb@apache.org
X-Mailer: svnmailer-1.0.8-patched
Message-Id: <20120213030230.1F8E8238889B@eris.apache.org>
X-Virus-Checked: Checked by ClamAV on apache.org

Author: sebb
Date: Mon Feb 13 03:02:29 2012
New Revision: 1243400

URL: http://svn.apache.org/viewvc?rev=1243400&view=rev
Log:
Eliminate drop-thru cases

Modified:
    commons/proper/net/trunk/findbugs-exclude-filter.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParser.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java

Modified: commons/proper/net/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/findbugs-exclude-filter.xml?rev=1243400&r1=1243399&r2=1243400&view=diff
==============================================================================
--- commons/proper/net/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/net/trunk/findbugs-exclude-filter.xml Mon Feb 13 03:02:29 2012
@@ -49,13 +49,6 @@
     <Bug code="BC" />
   </Match>
 
-  <!-- Switch fallthrough is deliberate -->
-  <Match>
-    <Class name="org.apache.commons.net.ftp.parser.UnixFTPEntryParser" />
-    <Method name="parseFTPEntry" />
-    <Bug code="SF" />
-  </Match>
-
   <!-- False positive - missing default -->
   <Match>
     <Class name="org.apache.commons.net.io.DotTerminatedMessageWriter" />

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParser.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParser.java?rev=1243400&r1=1243399&r2=1243400&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParser.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParser.java Mon Feb 13 03:02:29 2012
@@ -169,8 +169,8 @@ public class MacOsPeterFTPEntryParser ex
             case 'b':
             case 'c':
                 isDevice = true;
-                // break; - fall through
-                //$FALL-THROUGH$ TODO change this if DEVICE_TYPE implemented
+                type = FTPFile.FILE_TYPE; // TODO change this if DEVICE_TYPE implemented
+                break;
             case 'f':
             case '-':
                 type = FTPFile.FILE_TYPE;

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java?rev=1243400&r1=1243399&r2=1243400&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java Mon Feb 13 03:02:29 2012
@@ -208,8 +208,8 @@ public class UnixFTPEntryParser extends 
             case 'b':
             case 'c':
                 isDevice = true;
-                // break; - fall through
-                //$FALL-THROUGH$ TODO change this if DEVICE_TYPE implemented
+                type = FTPFile.FILE_TYPE; // TODO change this if DEVICE_TYPE implemented
+                break;
             case 'f':
             case '-':
                 type = FTPFile.FILE_TYPE;