commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1238504 - in /commons/proper/net/trunk/src: changes/changes.xml main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java main/java/org/apache/commons/net/pop3/POP3Client.java
Date Tue, 31 Jan 2012 13:27:19 GMT
Author: sebb
Date: Tue Jan 31 13:27:18 2012
New Revision: 1238504

URL: http://svn.apache.org/viewvc?rev=1238504&view=rev
Log: (empty)

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java

Modified: commons/proper/net/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1238504&r1=1238503&r2=1238504&view=diff
==============================================================================
--- commons/proper/net/trunk/src/changes/changes.xml (original)
+++ commons/proper/net/trunk/src/changes/changes.xml Tue Jan 31 13:27:18 2012
@@ -59,11 +59,14 @@ The <action> type attribute can be add,u
         <release version="3.1-SNAPSHOT" date="TBA" description="
 TBA
         ">
+            <action issue="NET-438" dev="sebb" type="fix" due-to="Norman Maurer">
+            POP3Client.capa() should call POP3Client.getAdditionalReply()
+            </action>
             <action issue="NET-412" dev="sebb" type="fix" due-to="Chuck Wolber">
-            Apache Commons TFTP implementation subject to Sorcerer's Apprentice Syndrome
+            TFTP implementation subject to Sorcerer's Apprentice Syndrome
             </action>
             <action issue="NET-410" dev="sebb" type="fix" due-to="Chuck Wolber">
-            Apache Commons TFTP does not handle RFC 783 retransmits
+            TFTP does not handle RFC 783 retransmits
             </action>
             <action issue="NET-437" dev="sebb" type="fix" due-to="Gavin Camp">
             TelnetInputStream doesn't support non-blocking IO when reader thread is not enabled

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java?rev=1238504&r1=1238503&r2=1238504&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java
(original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/ExtendedPOP3Client.java
Tue Jan 31 13:27:18 2012
@@ -46,17 +46,6 @@ public class ExtendedPOP3Client extends 
     }
 
     /***
-     * Send a CAPA command to the POP3 server.
-     * @return True if the command was successful, false if not.
-     * @exception IOException If a network I/O error occurs in the process of
-     *        sending the NOOP command.
-     ***/
-    public boolean capa() throws IOException
-    {
-        return (sendCommand(POP3Command.CAPA) == POP3Reply.OK);
-    }
-
-    /***
      * Authenticate to the POP3 server by sending the AUTH command with the
      * selected mechanism, using the given username and the given password.
      * <p>

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java?rev=1238504&r1=1238503&r2=1238504&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/pop3/POP3Client.java Tue
Jan 31 13:27:18 2012
@@ -114,6 +114,22 @@ public class POP3Client extends POP3
     }
 
     /***
+     * Send a CAPA command to the POP3 server.
+     * @return True if the command was successful, false if not.
+     * @exception IOException If a network I/O error occurs in the process of
+     *        sending the CAPA command.
+     ***/
+    public boolean capa() throws IOException
+    {
+        if (sendCommand(POP3Command.CAPA) == POP3Reply.OK) {
+            getAdditionalReply();
+            return true;
+        }
+        return false;
+        
+    }
+    
+    /***
      * Login to the POP3 server with the given username and password.  You
      * must first connect to the server with
      * {@link org.apache.commons.net.SocketClient#connect  connect }



Mime
View raw message