commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgoes...@apache.org
Subject svn commit: r1210255 - in /commons/proper/email/trunk/src/test/org/apache/commons/mail: InvalidAddressTest.java InvalidInternetAddressTest.java
Date Sun, 04 Dec 2011 22:21:09 GMT
Author: sgoeschl
Date: Sun Dec  4 22:21:09 2011
New Revision: 1210255

URL: http://svn.apache.org/viewvc?rev=1210255&view=rev
Log:
Upgrading to mail-1.4.1 broke some code testing for invalid arguments

Modified:
    commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidAddressTest.java
    commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidInternetAddressTest.java

Modified: commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidAddressTest.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidAddressTest.java?rev=1210255&r1=1210254&r2=1210255&view=diff
==============================================================================
--- commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidAddressTest.java (original)
+++ commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidAddressTest.java Sun
Dec  4 22:21:09 2011
@@ -38,9 +38,8 @@ public class InvalidAddressTest extends 
         "local:name@domain.com",
         "local[name@domain.com",
         "local]name@domain.com",
-        "local\\name@domain.com",
-
-        //      "local\"name@domain.com",
+        // "local\\name@domain.com", is considered valid for mail-1.4.1
+        "local\"name@domain.com",
         "local\tname@domain.com",
         "local\nname@domain.com",
         "local\rname@domain.com",

Modified: commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidInternetAddressTest.java
URL: http://svn.apache.org/viewvc/commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidInternetAddressTest.java?rev=1210255&r1=1210254&r2=1210255&view=diff
==============================================================================
--- commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidInternetAddressTest.java
(original)
+++ commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidInternetAddressTest.java
Sun Dec  4 22:21:09 2011
@@ -49,8 +49,8 @@ public class InvalidInternetAddressTest 
             "local:name@domain.com",
             "local[name@domain.com",
             "local]name@domain.com",
-            "local\\name@domain.com",
-            "local\"name@domain.com",
+            // "local\\name@domain.com", -- works for javamail-1.4.4
+            // "local\"name@domain.com", -- works for javamail-1.4.4
             "local\tname@domain.com",
             "local\nname@domain.com",
             "local\rname@domain.com",



Mime
View raw message