commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1209050 - in /commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2: JexlEngine.java introspection/Sandbox.java
Date Thu, 01 Dec 2011 12:33:03 GMT
Author: sebb
Date: Thu Dec  1 12:33:02 2011
New Revision: 1209050

URL: http://svn.apache.org/viewvc?rev=1209050&view=rev
Log:
There does not seem to be any reason for these fields to be protected rather than private.
Can always increase access later; much more difficult to decrease access.

Modified:
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/JexlEngine.java
    commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/introspection/Sandbox.java

Modified: commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/JexlEngine.java
URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/JexlEngine.java?rev=1209050&r1=1209049&r2=1209050&view=diff
==============================================================================
--- commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/JexlEngine.java
(original)
+++ commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/JexlEngine.java
Thu Dec  1 12:33:02 2011
@@ -996,13 +996,13 @@ public class JexlEngine {
         /**
          * The number of parameters.
          */
-        protected final int parms;
+        private final int parms;
         /**
          * The map of named registers aka script parameters.
          * Each parameter is associated to a register and is materialized as an offset in
the registers array used
          * during evaluation.
          */
-        protected Map<String, Integer> namedRegisters = null;
+        private Map<String, Integer> namedRegisters = null;
 
         /**
          * Creates a new scope with a list of parameters.
@@ -1154,9 +1154,9 @@ public class JexlEngine {
      */
     public static final class Frame {
         /** Registers or arguments. */
-        protected Object[] registers = null;
+        private Object[] registers = null;
         /** Parameter and argument names if any. */
-        protected String[] parameters = null;
+        private String[] parameters = null;
         
         /**
          * Creates a new frame.

Modified: commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/introspection/Sandbox.java
URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/introspection/Sandbox.java?rev=1209050&r1=1209049&r2=1209050&view=diff
==============================================================================
--- commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/introspection/Sandbox.java
(original)
+++ commons/proper/jexl/branches/2.0/src/main/java/org/apache/commons/jexl2/introspection/Sandbox.java
Thu Dec  1 12:33:02 2011
@@ -197,7 +197,7 @@ public final class Sandbox {
      */
     public static final class WhiteSet extends Names {
         /** The map of controlled names and aliases. */
-        protected Map<String, String> names = null;
+        private Map<String, String> names = null;
 
         @Override
         public boolean add(String name) {
@@ -230,7 +230,7 @@ public final class Sandbox {
      */
     public static final class BlackSet extends Names {
         /** The set of controlled names. */
-        protected Set<String> names = null;
+        private Set<String> names = null;
 
         @Override
         public boolean add(String name) {



Mime
View raw message