Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D73157763 for ; Sun, 27 Nov 2011 11:06:20 +0000 (UTC) Received: (qmail 20830 invoked by uid 500); 27 Nov 2011 11:06:20 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 20724 invoked by uid 500); 27 Nov 2011 11:06:19 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 20717 invoked by uid 99); 27 Nov 2011 11:06:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Nov 2011 11:06:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Nov 2011 11:06:18 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 4697B2388978 for ; Sun, 27 Nov 2011 11:05:58 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1206697 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java Date: Sun, 27 Nov 2011 11:05:58 -0000 To: commits@commons.apache.org From: sebb@apache.org X-Mailer: svnmailer-1.0.8-patched Message-Id: <20111127110558.4697B2388978@eris.apache.org> Author: sebb Date: Sun Nov 27 11:05:57 2011 New Revision: 1206697 URL: http://svn.apache.org/viewvc?rev=1206697&view=rev Log: Suppress "already instanceof" warning because that is what we want to check Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java?rev=1206697&r1=1206696&r2=1206697&view=diff ============================================================================== --- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java (original) +++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java Sun Nov 27 11:05:57 2011 @@ -208,9 +208,11 @@ public class ObjectUtilsTest { assertEquals(Boolean.TRUE.toString(), ObjectUtils.toString(Boolean.TRUE, BAR) ); } + @SuppressWarnings("cast") // 1 OK, because we are checking for code change @Test public void testNull() { assertNotNull(ObjectUtils.NULL); + // 1 Check that NULL really is a Null i.e. the definition has not been changed assertTrue(ObjectUtils.NULL instanceof ObjectUtils.Null); assertSame(ObjectUtils.NULL, SerializationUtils.clone(ObjectUtils.NULL)); }