commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1206697 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
Date Sun, 27 Nov 2011 11:05:58 GMT
Author: sebb
Date: Sun Nov 27 11:05:57 2011
New Revision: 1206697

URL: http://svn.apache.org/viewvc?rev=1206697&view=rev
Log:
Suppress "already instanceof" warning because that is what we want to check

Modified:
    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java

Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java?rev=1206697&r1=1206696&r2=1206697&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
(original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/ObjectUtilsTest.java
Sun Nov 27 11:05:57 2011
@@ -208,9 +208,11 @@ public class ObjectUtilsTest {
         assertEquals(Boolean.TRUE.toString(), ObjectUtils.toString(Boolean.TRUE, BAR) );
     }
 
+    @SuppressWarnings("cast") // 1 OK, because we are checking for code change
     @Test
     public void testNull() {
         assertNotNull(ObjectUtils.NULL);
+        // 1 Check that NULL really is a Null i.e. the definition has not been changed
         assertTrue(ObjectUtils.NULL instanceof ObjectUtils.Null);
         assertSame(ObjectUtils.NULL, SerializationUtils.clone(ObjectUtils.NULL));
     }



Mime
View raw message