commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pste...@apache.org
Subject svn commit: r1206479 - /commons/proper/pool/branches/POOL_1_X/findbugs-exclude-filter.xml
Date Sat, 26 Nov 2011 16:28:44 GMT
Author: psteitz
Date: Sat Nov 26 16:28:43 2011
New Revision: 1206479

URL: http://svn.apache.org/viewvc?rev=1206479&view=rev
Log:
Findbugs thinks we are naked. We are not.

Modified:
    commons/proper/pool/branches/POOL_1_X/findbugs-exclude-filter.xml

Modified: commons/proper/pool/branches/POOL_1_X/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/pool/branches/POOL_1_X/findbugs-exclude-filter.xml?rev=1206479&r1=1206478&r2=1206479&view=diff
==============================================================================
--- commons/proper/pool/branches/POOL_1_X/findbugs-exclude-filter.xml (original)
+++ commons/proper/pool/branches/POOL_1_X/findbugs-exclude-filter.xml Sat Nov 26 16:28:43
2011
@@ -22,12 +22,22 @@
   put here to instruct findbugs to ignore them.
 -->
 <FindBugsFilter>
-  <!-- findbugs thinks this is naked, but it is not -->
+  <!-- findbugs thinks these is naked, but they are not -->
   <Match>
     <Class name="org.apache.commons.pool.impl.GenericKeyedObjectPool" />
     <Method name="allocate"/>
     <Bug pattern="NN_NAKED_NOTIFY" />
   </Match>
+  <Match>
+    <Class name="org.apache.commons.pool.impl.GenericKeyedObjectPool" />
+    <Method name="close"/>
+    <Bug pattern="NN_NAKED_NOTIFY" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.pool.impl.GenericObjectPool" />
+    <Method name="close"/>
+    <Bug pattern="NN_NAKED_NOTIFY" />
+  </Match>
   <!-- Iteration has to be over keys here -->
   <Match>
     <Class name="org.apache.commons.pool.impl.GenericKeyedObjectPool" />



Mime
View raw message