commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1205543 - /commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AsyncQueryRunner.java
Date Wed, 23 Nov 2011 19:41:08 GMT
Author: sebb
Date: Wed Nov 23 19:41:08 2011
New Revision: 1205543

URL: http://svn.apache.org/viewvc?rev=1205543&view=rev
Log:
Make private write-once variables final

Modified:
    commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AsyncQueryRunner.java

Modified: commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AsyncQueryRunner.java
URL: http://svn.apache.org/viewvc/commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AsyncQueryRunner.java?rev=1205543&r1=1205542&r2=1205543&view=diff
==============================================================================
--- commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AsyncQueryRunner.java
(original)
+++ commons/proper/dbutils/trunk/src/main/java/org/apache/commons/dbutils/AsyncQueryRunner.java
Wed Nov 23 19:41:08 2011
@@ -91,11 +91,11 @@ public class AsyncQueryRunner extends Ab
      * Class that encapsulates the continuation for batch calls.
      */
     protected class BatchCallableStatement implements Callable<int[]> {
-        private String sql;
-        private Object[][] params;
-        private Connection conn;
-        private boolean closeConn;
-        private PreparedStatement ps;
+        private final String sql;
+        private final Object[][] params;
+        private final Connection conn;
+        private final boolean closeConn;
+        private final PreparedStatement ps;
 
         /**
          * Creates a new BatchCallableStatement instance.
@@ -228,12 +228,12 @@ public class AsyncQueryRunner extends Ab
      * @param <T> The type of the result from the call to handle.
      */
     protected class QueryCallableStatement<T> implements Callable<T> {
-        private String sql;
-        private Object[] params;
-        private Connection conn;
-        private boolean closeConn;
-        private PreparedStatement ps;
-        private ResultSetHandler<T> rsh;
+        private final String sql;
+        private final Object[] params;
+        private final Connection conn;
+        private final boolean closeConn;
+        private final PreparedStatement ps;
+        private final ResultSetHandler<T> rsh;
 
         /**
          * Creates a new {@code QueryCallableStatement} instance.
@@ -406,11 +406,11 @@ public class AsyncQueryRunner extends Ab
      * Class that encapsulates the continuation for update calls.
      */
     protected class UpdateCallableStatement implements Callable<Integer> {
-        private String sql;
-        private Object[] params;
-        private Connection conn;
-        private boolean closeConn;
-        private PreparedStatement ps;
+        private final String sql;
+        private final Object[] params;
+        private final Connection conn;
+        private final boolean closeConn;
+        private final PreparedStatement ps;
 
         /**
          *



Mime
View raw message