commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dbros...@apache.org
Subject svn commit: r1200112 - /commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/writer/CSVConfig.java
Date Thu, 10 Nov 2011 03:37:47 GMT
Author: dbrosius
Date: Thu Nov 10 03:37:47 2011
New Revision: 1200112

URL: http://svn.apache.org/viewvc?rev=1200112&view=rev
Log:
bad logic, should use || rather than &&, but instanceof covers the null case anyway

Modified:
    commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/writer/CSVConfig.java

Modified: commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/writer/CSVConfig.java
URL: http://svn.apache.org/viewvc/commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/writer/CSVConfig.java?rev=1200112&r1=1200111&r2=1200112&view=diff
==============================================================================
--- commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/writer/CSVConfig.java (original)
+++ commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/writer/CSVConfig.java Thu
Nov 10 03:37:47 2011
@@ -283,7 +283,7 @@ public class CSVConfig {
      * @see java.lang.Object#equals(java.lang.Object)
      */
     public boolean equals(Object obj) {
-        if (obj == null && !(obj instanceof CSVConfig)) {
+        if (!(obj instanceof CSVConfig)) {
             return false;
         }
         return super.equals(obj);



Mime
View raw message