From commits-return-21733-apmail-commons-commits-archive=commons.apache.org@commons.apache.org Fri Sep 2 18:21:06 2011 Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EAD2B7E6A for ; Fri, 2 Sep 2011 18:21:05 +0000 (UTC) Received: (qmail 50733 invoked by uid 500); 2 Sep 2011 18:21:05 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 50537 invoked by uid 500); 2 Sep 2011 18:21:04 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 50530 invoked by uid 99); 2 Sep 2011 18:21:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2011 18:21:04 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Sep 2011 18:20:58 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 8B86523888FD for ; Fri, 2 Sep 2011 18:20:37 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1164662 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/general/GaussNewtonOptimizer.java Date: Fri, 02 Sep 2011 18:20:37 -0000 To: commits@commons.apache.org From: celestin@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110902182037.8B86523888FD@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: celestin Date: Fri Sep 2 18:20:37 2011 New Revision: 1164662 URL: http://svn.apache.org/viewvc?rev=1164662&view=rev Log: Simplification of the conversion from RealVector to double[]. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/general/GaussNewtonOptimizer.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/general/GaussNewtonOptimizer.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/general/GaussNewtonOptimizer.java?rev=1164662&r1=1164661&r2=1164662&view=diff ============================================================================== --- commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/general/GaussNewtonOptimizer.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/optimization/general/GaussNewtonOptimizer.java Fri Sep 2 18:20:37 2011 @@ -148,13 +148,7 @@ public class GaussNewtonOptimizer extend DecompositionSolver solver = useLU ? new LUDecompositionImpl(mA).getSolver() : new QRDecompositionImpl(mA).getSolver(); - final RealVector dummy = solver.solve(new ArrayRealVector(b, false)); - final double[] dX; - if (dummy instanceof ArrayRealVector){ - dX = ((ArrayRealVector) dummy).getDataRef(); - }else{ - dX = dummy.getData(); - } + final double[] dX = solver.solve(new ArrayRealVector(b, false)).toArray(); // update the estimated parameters for (int i = 0; i < cols; ++i) { point[i] += dX[i];