commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject svn commit: r1170674 - /commons/proper/compress/trunk/findbugs-exclude-filter.xml
Date Wed, 14 Sep 2011 15:13:16 GMT
Author: bodewig
Date: Wed Sep 14 15:13:14 2011
New Revision: 1170674

URL: http://svn.apache.org/viewvc?rev=1170674&view=rev
Log:
address FindBugs issues

Modified:
    commons/proper/compress/trunk/findbugs-exclude-filter.xml

Modified: commons/proper/compress/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/findbugs-exclude-filter.xml?rev=1170674&r1=1170673&r2=1170674&view=diff
==============================================================================
--- commons/proper/compress/trunk/findbugs-exclude-filter.xml (original)
+++ commons/proper/compress/trunk/findbugs-exclude-filter.xml Wed Sep 14 15:13:14 2011
@@ -81,4 +81,24 @@
     <Bug pattern="SR_NOT_CHECKED" />
   </Match>
 
+  <!-- Reason: trying to delete a temporary file that has deleteOnExit set
+       anyway -->
+  <Match>
+    <Class name="org.apache.commons.compress.compressors.pack200.Pack200Utils" />
+    <Method name="normalize" />
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
+  </Match>
+  <Match>
+    <Class name="org.apache.commons.compress.compressors.pack200.TempFileCachingStreamBridge$1"
/>
+    <Method name="close" />
+    <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" />
+  </Match>
+
+  <!-- Reason: It is the Pack200*Stream that's going to close it. -->
+  <Match>
+    <Class name="org.apache.commons.compress.compressors.pack200.TempFileCachingStreamBridge$1"
/>
+    <Method name="&lt;init&gt;" />
+    <Bug pattern="OBL_UNSATISFIED_OBLIGATION" />
+  </Match>
+
 </FindBugsFilter>



Mime
View raw message