commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simonetrip...@apache.org
Subject svn commit: r1166363 - /commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinarySequence.java
Date Wed, 07 Sep 2011 20:05:43 GMT
Author: simonetripodi
Date: Wed Sep  7 20:05:43 2011
New Revision: 1166363

URL: http://svn.apache.org/viewvc?rev=1166363&view=rev
Log:
fixed checkstyle violations: Method 'XXX' is not designed for extension - needs to be abstract,
final or empty.

Modified:
    commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinarySequence.java

Modified: commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinarySequence.java
URL: http://svn.apache.org/viewvc/commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinarySequence.java?rev=1166363&r1=1166362&r2=1166363&view=diff
==============================================================================
--- commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinarySequence.java
(original)
+++ commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinarySequence.java
Wed Sep  7 20:05:43 2011
@@ -93,7 +93,7 @@ public class BinarySequence<L, R> implem
      * @param p BinaryProcedure to add
      * @return this
      */
-    public BinarySequence<L, R> then(BinaryProcedure<? super L, ? super R> p)
{
+    public final BinarySequence<L, R> then(BinaryProcedure<? super L, ? super R>
p) {
         list.add(p);
         return this;
     }
@@ -103,7 +103,7 @@ public class BinarySequence<L, R> implem
     /**
      * {@inheritDoc}
      */
-    public void run(L left, R right) {
+    public final void run(L left, R right) {
         for (Iterator<BinaryProcedure<? super L, ? super R>> iter = list.iterator();
iter.hasNext();) {
             iter.next().run(left, right);
         }
@@ -112,7 +112,7 @@ public class BinarySequence<L, R> implem
     /**
      * {@inheritDoc}
      */
-    public boolean equals(Object that) {
+    public final boolean equals(Object that) {
         return that == this || (that instanceof BinarySequence<?, ?> && equals((BinarySequence<?,
?>) that));
     }
 
@@ -121,7 +121,7 @@ public class BinarySequence<L, R> implem
      * @param that BinarySequence to test
      * @return boolean
      */
-    public boolean equals(BinarySequence<?, ?> that) {
+    public final boolean equals(BinarySequence<?, ?> that) {
         // by construction, list is never null
         return null != that && list.equals(that.list);
     }
@@ -129,7 +129,7 @@ public class BinarySequence<L, R> implem
     /**
      * {@inheritDoc}
      */
-    public int hashCode() {
+    public final int hashCode() {
         // by construction, list is never null
         return "BinarySequence".hashCode() ^ list.hashCode();
     }
@@ -137,7 +137,7 @@ public class BinarySequence<L, R> implem
     /**
      * {@inheritDoc}
      */
-    public String toString() {
+    public final String toString() {
         return "BinarySequence<" + list + ">";
     }
 



Mime
View raw message