commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simonetrip...@apache.org
Subject svn commit: r1166360 - /commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinaryCompositeBinaryFunction.java
Date Wed, 07 Sep 2011 20:03:12 GMT
Author: simonetripodi
Date: Wed Sep  7 20:03:12 2011
New Revision: 1166360

URL: http://svn.apache.org/viewvc?rev=1166360&view=rev
Log:
fixed checkstyle violations: Method 'XXX' is not designed for extension - needs to be abstract,
final or empty.

Modified:
    commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinaryCompositeBinaryFunction.java

Modified: commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinaryCompositeBinaryFunction.java
URL: http://svn.apache.org/viewvc/commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinaryCompositeBinaryFunction.java?rev=1166360&r1=1166359&r2=1166360&view=diff
==============================================================================
--- commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinaryCompositeBinaryFunction.java
(original)
+++ commons/sandbox/functor/trunk/src/main/java/org/apache/commons/functor/core/composite/BinaryCompositeBinaryFunction.java
Wed Sep  7 20:03:12 2011
@@ -103,14 +103,14 @@ public class BinaryCompositeBinaryFuncti
     /**
      * {@inheritDoc}
      */
-    public T evaluate(L left, R right) {
+    public final T evaluate(L left, R right) {
         return helper.evaluate(left, right);
     }
 
     /**
      * {@inheritDoc}
      */
-    public boolean equals(Object that) {
+    public final boolean equals(Object that) {
         return that == this || (that instanceof BinaryCompositeBinaryFunction<?, ?, ?>
                                     && equals((BinaryCompositeBinaryFunction<?,
?, ?>) that));
     }
@@ -120,7 +120,7 @@ public class BinaryCompositeBinaryFuncti
      * @param that BinaryCompositeBinaryFunction to test
      * @return boolean
      */
-    public boolean equals(BinaryCompositeBinaryFunction<?, ?, ?> that) {
+    public final boolean equals(BinaryCompositeBinaryFunction<?, ?, ?> that) {
         return null != that
                 && helper.f.equals(that.helper.f)
                 && helper.g.equals(that.helper.g)
@@ -144,7 +144,7 @@ public class BinaryCompositeBinaryFuncti
     /**
      * {@inheritDoc}
      */
-    public String toString() {
+    public final String toString() {
         return "BinaryCompositeBinaryFunction<" + helper.f + ";" + helper.g + ";" + helper.h
+ ">";
     }
 



Mime
View raw message