commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1160647 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
Date Tue, 23 Aug 2011 12:17:26 GMT
Author: sebb
Date: Tue Aug 23 12:17:26 2011
New Revision: 1160647

URL: http://svn.apache.org/viewvc?rev=1160647&view=rev
Log:
Avoid boxing of both arguments

Modified:
    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java

Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java?rev=1160647&r1=1160646&r2=1160647&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
(original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
Tue Aug 23 12:17:26 2011
@@ -41,9 +41,9 @@ public class NumberUtilsTest {
         assertNotNull(new NumberUtils());
         Constructor<?>[] cons = NumberUtils.class.getDeclaredConstructors();
         assertEquals(1, cons.length);
-        assertEquals(true, Modifier.isPublic(cons[0].getModifiers()));
-        assertEquals(true, Modifier.isPublic(NumberUtils.class.getModifiers()));
-        assertEquals(false, Modifier.isFinal(NumberUtils.class.getModifiers()));
+        assertTrue(Modifier.isPublic(cons[0].getModifiers()));
+        assertTrue(Modifier.isPublic(NumberUtils.class.getModifiers()));
+        assertFalse(Modifier.isFinal(NumberUtils.class.getModifiers()));
     }
 
     //---------------------------------------------------------------------
@@ -1032,12 +1032,12 @@ public class NumberUtilsTest {
 
     @Test
     public void testIsDigits() {
-        assertEquals("isDigits(null) failed", false, NumberUtils.isDigits(null));
-        assertEquals("isDigits('') failed", false, NumberUtils.isDigits(""));
-        assertEquals("isDigits(String) failed", true, NumberUtils.isDigits("12345"));
-        assertEquals("isDigits(String) neg 1 failed", false, NumberUtils.isDigits("1234.5"));
-        assertEquals("isDigits(String) neg 3 failed", false, NumberUtils.isDigits("1ab"));
-        assertEquals("isDigits(String) neg 4 failed", false, NumberUtils.isDigits("abc"));
+        assertFalse("isDigits(null) failed", NumberUtils.isDigits(null));
+        assertFalse("isDigits('') failed", NumberUtils.isDigits(""));
+        assertTrue("isDigits(String) failed", NumberUtils.isDigits("12345"));
+        assertFalse("isDigits(String) neg 1 failed", NumberUtils.isDigits("1234.5"));
+        assertFalse("isDigits(String) neg 3 failed", NumberUtils.isDigits("1ab"));
+        assertFalse("isDigits(String) neg 4 failed", NumberUtils.isDigits("abc"));
     }
 
     /**



Mime
View raw message