commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1159984 - in /commons/proper/compress/trunk/src/test/java/org/apache/commons/compress: ArchiveReadTests.java archivers/LongPathTest.java archivers/zip/ZipFileTest.java
Date Sun, 21 Aug 2011 13:57:36 GMT
Author: sebb
Date: Sun Aug 21 13:57:36 2011
New Revision: 1159984

URL: http://svn.apache.org/viewvc?rev=1159984&view=rev
Log:
Remove unnecessary @SuppressWarnings; document necessary ones

Modified:
    commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTests.java
    commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java
    commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java

Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTests.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTests.java?rev=1159984&r1=1159983&r2=1159984&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTests.java
(original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/ArchiveReadTests.java
Sun Aug 21 13:57:36 2011
@@ -94,7 +94,7 @@ public class ArchiveReadTests extends Ab
     }
 
     public void testArchive() throws Exception{
-        @SuppressWarnings("unchecked")
+        @SuppressWarnings("unchecked") // fileList is correct type already
         ArrayList<String> expected= (ArrayList<String>) fileList.clone();
         try {
            checkArchiveContent(file, expected);

Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java?rev=1159984&r1=1159983&r2=1159984&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java
(original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/LongPathTest.java
Sun Aug 21 13:57:36 2011
@@ -93,7 +93,7 @@ public class LongPathTest extends Abstra
     }
     
     public void testArchive() throws Exception {
-        @SuppressWarnings("unchecked")
+        @SuppressWarnings("unchecked") // fileList is of correct type
         ArrayList<String> expected = (ArrayList<String>) fileList.clone();
         String name = file.getName();
         if ("minotaur.jar".equals(name) || "minotaur-0.jar".equals(name)){

Modified: commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java?rev=1159984&r1=1159983&r2=1159984&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
(original)
+++ commons/proper/compress/trunk/src/test/java/org/apache/commons/compress/archivers/zip/ZipFileTest.java
Sun Aug 21 13:57:36 2011
@@ -35,7 +35,6 @@ public class ZipFileTest extends TestCas
 
     public void testCDOrder() throws Exception {
         readOrderTest();
-        @SuppressWarnings("unchecked")
         ArrayList<ZipArchiveEntry> l = Collections.list(zf.getEntries());
         assertEntryName(l, 0, "AbstractUnicodeExtraField");
         assertEntryName(l, 1, "AsiExtraField");
@@ -64,7 +63,6 @@ public class ZipFileTest extends TestCas
 
     public void testPhysicalOrder() throws Exception {
         readOrderTest();
-        @SuppressWarnings("unchecked")
         ArrayList<ZipArchiveEntry> l = Collections.list(zf.getEntriesInPhysicalOrder());
         assertEntryName(l, 0, "AbstractUnicodeExtraField");
         assertEntryName(l, 1, "AsiExtraField");



Mime
View raw message