commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bode...@apache.org
Subject svn commit: r1158095 - in /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump: DumpArchiveInputStream.java TapeInputStream.java
Date Tue, 16 Aug 2011 03:17:23 GMT
Author: bodewig
Date: Tue Aug 16 03:17:17 2011
New Revision: 1158095

URL: http://svn.apache.org/viewvc?rev=1158095&view=rev
Log:
make PMD happier

Modified:
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
    commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java?rev=1158095&r1=1158094&r2=1158095&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
(original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
Tue Aug 16 03:17:17 2011
@@ -307,10 +307,12 @@ public class DumpArchiveInputStream exte
 
                 Dirent d = new Dirent(ino, entry.getIno(), type, name);
 
+                /*
                 if ((type == 4) && names.containsKey(ino)) {
-                    //System.out.println("we already have ino: " +
-                    //    names.get(ino));
+                    System.out.println("we already have ino: " +
+                                       names.get(ino));
                 }
+                */
 
                 names.put(ino, d);
 

Modified: commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java
URL: http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java?rev=1158095&r1=1158094&r2=1158095&view=diff
==============================================================================
--- commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java
(original)
+++ commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java
Tue Aug 16 03:17:17 2011
@@ -193,10 +193,8 @@ class TapeInputStream extends FilterInpu
      */
     @Override
     public void close() throws IOException {
-        if (in != null) {
-            if (in != System.in) {
-                in.close();
-            }
+        if (in != null && in != System.in) {
+            in.close();
         }
     }
 



Mime
View raw message