Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 175026A34 for ; Mon, 11 Jul 2011 01:13:03 +0000 (UTC) Received: (qmail 90745 invoked by uid 500); 11 Jul 2011 01:13:02 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 90672 invoked by uid 500); 11 Jul 2011 01:13:01 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 90664 invoked by uid 99); 11 Jul 2011 01:13:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jul 2011 01:13:01 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jul 2011 01:13:00 +0000 Received: from eris.apache.org (localhost [127.0.0.1]) by eris.apache.org (Postfix) with ESMTP id 39D6423888BD for ; Mon, 11 Jul 2011 01:12:40 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1145002 - in /commons/proper/codec/trunk/src: java/org/apache/commons/codec/language/DoubleMetaphone.java test/org/apache/commons/codec/binary/Base64Test.java test/org/apache/commons/codec/digest/DigestUtilsTest.java Date: Mon, 11 Jul 2011 01:12:40 -0000 To: commits@commons.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110711011240.39D6423888BD@eris.apache.org> Author: ggregory Date: Mon Jul 11 01:12:39 2011 New Revision: 1145002 URL: http://svn.apache.org/viewvc?rev=1145002&view=rev Log: Make fields final where possible. Modified: commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/DoubleMetaphone.java commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java commons/proper/codec/trunk/src/test/org/apache/commons/codec/digest/DigestUtilsTest.java Modified: commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/DoubleMetaphone.java URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/DoubleMetaphone.java?rev=1145002&r1=1145001&r2=1145002&view=diff ============================================================================== --- commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/DoubleMetaphone.java (original) +++ commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/DoubleMetaphone.java Mon Jul 11 01:12:39 2011 @@ -1031,9 +1031,9 @@ public class DoubleMetaphone implements */ public class DoubleMetaphoneResult { - private StringBuffer primary = new StringBuffer(getMaxCodeLen()); - private StringBuffer alternate = new StringBuffer(getMaxCodeLen()); - private int maxLength; + private final StringBuffer primary = new StringBuffer(getMaxCodeLen()); + private final StringBuffer alternate = new StringBuffer(getMaxCodeLen()); + private final int maxLength; public DoubleMetaphoneResult(int maxLength) { this.maxLength = maxLength; Modified: commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java?rev=1145002&r1=1145001&r2=1145002&view=diff ============================================================================== --- commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java (original) +++ commons/proper/codec/trunk/src/test/org/apache/commons/codec/binary/Base64Test.java Mon Jul 11 01:12:39 2011 @@ -41,7 +41,7 @@ import org.junit.Test; */ public class Base64Test { - private Random _random = new Random(); + private final Random _random = new Random(); /** * @return Returns the _random. Modified: commons/proper/codec/trunk/src/test/org/apache/commons/codec/digest/DigestUtilsTest.java URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/test/org/apache/commons/codec/digest/DigestUtilsTest.java?rev=1145002&r1=1145001&r2=1145002&view=diff ============================================================================== --- commons/proper/codec/trunk/src/test/org/apache/commons/codec/digest/DigestUtilsTest.java (original) +++ commons/proper/codec/trunk/src/test/org/apache/commons/codec/digest/DigestUtilsTest.java Mon Jul 11 01:12:39 2011 @@ -35,7 +35,7 @@ import org.junit.Test; */ public class DigestUtilsTest { - private byte[] testData = new byte[1024*1024]; + private final byte[] testData = new byte[1024*1024]; private byte[] getBytesUtf8(String hashMe) { return StringUtils.getBytesUtf8(hashMe);