commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From er...@apache.org
Subject svn commit: r1152462 - /commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/SingularValueDecompositionImpl.java
Date Sat, 30 Jul 2011 13:50:51 GMT
Author: erans
Date: Sat Jul 30 13:50:51 2011
New Revision: 1152462

URL: http://svn.apache.org/viewvc?rev=1152462&view=rev
Log:
MATH-638
Fixed Findbugs and CheckStyle warnings.

Modified:
    commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/SingularValueDecompositionImpl.java

Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/SingularValueDecompositionImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/SingularValueDecompositionImpl.java?rev=1152462&r1=1152461&r2=1152462&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/SingularValueDecompositionImpl.java
(original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/SingularValueDecompositionImpl.java
Sat Jul 30 13:50:51 2011
@@ -124,7 +124,7 @@ public class SingularValueDecompositionI
                 singularValues[k] = -singularValues[k];
             }
             for (int j = k + 1; j < n; j++) {
-                if ((k < nct) & (singularValues[k] != 0.0)) {
+                if ((k < nct) && (singularValues[k] != 0.0)) {
                     // Apply the transformation.
                     double t = 0;
                     for (int i = k; i < m; i++) {
@@ -139,7 +139,7 @@ public class SingularValueDecompositionI
                 // subsequent calculation of the row transformation.
                 e[j] = A[k][j];
             }
-            if (wantu & (k < nct)) {
+            if (wantu && (k < nct)) {
                 // Place the transformation in U for subsequent back
                 // multiplication.
                 for (int i = k; i < m; i++) {
@@ -164,7 +164,7 @@ public class SingularValueDecompositionI
                     e[k + 1] += 1.0;
                 }
                 e[k] = -e[k];
-                if ((k + 1 < m) & (e[k] != 0.0)) {
+                if ((k + 1 < m) && (e[k] != 0.0)) {
                     // Apply the transformation.
                     for (int i = k + 1; i < m; i++) {
                         work[i] = 0.0;
@@ -240,7 +240,7 @@ public class SingularValueDecompositionI
         // If required, generate V.
         if (wantv) {
             for (int k = n - 1; k >= 0; k--) {
-                if ((k < nrt) & (e[k] != 0.0)) {
+                if ((k < nrt) && (e[k] != 0.0)) {
                     for (int j = k + 1; j < nu; j++) {
                         double t = 0;
                         for (int i = k + 1; i < n; i++) {
@@ -262,7 +262,8 @@ public class SingularValueDecompositionI
         int pp = p - 1;
         int iter = 0;
         while (p > 0) {
-            int k, kase;
+            int k;
+            int kase;
             // Here is where a test for too many iterations would go.
             // This section of the program inspects for
             // negligible elements in the s and e arrays.  On



Mime
View raw message