commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From er...@apache.org
Subject svn commit: r1147081 - in /commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear: InvertibleRealLinearOperator.java RealLinearOperator.java
Date Fri, 15 Jul 2011 10:46:30 GMT
Author: erans
Date: Fri Jul 15 10:46:29 2011
New Revision: 1147081

URL: http://svn.apache.org/viewvc?rev=1147081&view=rev
Log:
MATH-581
Made accessors "abstract" (a per the conclusion of the thread
"RealLinearOperator and AbstractRealMatrix" on the dev ML).
Removed constructors.

Modified:
    commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/InvertibleRealLinearOperator.java
    commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealLinearOperator.java

Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/InvertibleRealLinearOperator.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/InvertibleRealLinearOperator.java?rev=1147081&r1=1147080&r2=1147081&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/InvertibleRealLinearOperator.java
(original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/InvertibleRealLinearOperator.java
Fri Jul 15 10:46:29 2011
@@ -27,15 +27,6 @@ import org.apache.commons.math.exception
  */
 public abstract class InvertibleRealLinearOperator extends RealLinearOperator {
     /**
-     * Creates a new instance of this class with the specified dimension.
-     *
-     * @param dim Common dimension of the domain and codomain.
-     */
-    public InvertibleRealLinearOperator(final int dim) {
-        super(dim, dim);
-    }
-
-    /**
      * Computes the matrix-vector product of the inverse of this instance
      * with {@code b} and returns the result.
      *

Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealLinearOperator.java
URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealLinearOperator.java?rev=1147081&r1=1147080&r2=1147081&view=diff
==============================================================================
--- commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealLinearOperator.java
(original)
+++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/linear/RealLinearOperator.java
Fri Jul 15 10:46:29 2011
@@ -41,49 +41,29 @@ import org.apache.commons.math.exception
  * <dl>
  *  <dt><a name="BARR1994">Barret et al. (1994)</a></dt>
  *  <dd>
- *   R. Barrett, M. Berry, T. F. Chan, J. Demmel, J. M. Donato, J. Dongarra, V.
- *   Eijkhout, R. Pozo, C. Romine and H. Van der Vorst,
+ *   R. Barrett, M. Berry, T. F. Chan, J. Demmel, J. M. Donato, J. Dongarra,
+ *   V. Eijkhout, R. Pozo, C. Romine and H. Van der Vorst,
  *   <em>Templates for the Solution of Linear Systems: Building Blocks for
- *   Iterative Methods</em>, SIAM</dd>
+ *   Iterative Methods</em>, SIAM
+ *  </dd>
  * </dl>
  *
  * @version $Id$
  */
 public abstract class RealLinearOperator {
-    /** The dimension of the codomain. */
-    private final int rowDimension;
-    /** The dimension of the domain. */
-    private final int columnDimension;
-
-    /**
-     * Creates a new instance of this class, with specified dimensions
-     * of the domain and codomain.
-     *
-     * @param rowDimension Dimension of the codomain (number of rows).
-     * @param columnDimension Dimension of the domain (number of columns).
-     */
-    public RealLinearOperator(final int rowDimension, final int columnDimension) {
-        this.columnDimension = columnDimension;
-        this.rowDimension = rowDimension;
-    }
-
     /**
      * Returns the dimension of the codomain of this operator.
      *
      * @return the number of rows of the underlying matrix.
      */
-    public final int getRowDimension() {
-        return rowDimension;
-    }
+    public abstract int getRowDimension();
 
     /**
      * Returns the dimension of the domain of this operator.
      *
      * @return the number of columns of the underlying matrix.
      */
-    public final int getColumnDimension() {
-        return columnDimension;
-    }
+    public abstract int getColumnDimension();
 
     /**
      * Returns the result of multiplying {@code this} by the vector {@code x}.



Mime
View raw message