commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simonetrip...@apache.org
Subject svn commit: r1140261 - /commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/xmlrules/BeanPropertySetterRule.java
Date Mon, 27 Jun 2011 18:43:13 GMT
Author: simonetripodi
Date: Mon Jun 27 18:43:13 2011
New Revision: 1140261

URL: http://svn.apache.org/viewvc?rev=1140261&view=rev
Log:
fixed checkstyle violation: Inner assignments should be avoided

Modified:
    commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/xmlrules/BeanPropertySetterRule.java

Modified: commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/xmlrules/BeanPropertySetterRule.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/xmlrules/BeanPropertySetterRule.java?rev=1140261&r1=1140260&r2=1140261&view=diff
==============================================================================
--- commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/xmlrules/BeanPropertySetterRule.java
(original)
+++ commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/xmlrules/BeanPropertySetterRule.java
Mon Jun 27 18:43:13 2011
@@ -46,8 +46,8 @@ final class BeanPropertySetterRule
         BeanPropertySetterBuilder builder =
             linkedRuleBuilder.setBeanProperty().withName( attributes.getValue( "propertyname"
) );
 
-        int propertyNameFromAttributeIndex = -1;
-        if ( ( propertyNameFromAttributeIndex = attributes.getIndex( "propertynameFromAttribute"
) ) >= 0 )
+        int propertyNameFromAttributeIndex = attributes.getIndex( "propertynameFromAttribute"
);
+        if ( propertyNameFromAttributeIndex >= 0 )
         {
             builder.extractPropertyNameFromAttribute( attributes.getValue( propertyNameFromAttributeIndex
) );
         }



Mime
View raw message