commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simonetrip...@apache.org
Subject svn commit: r1139980 - in /commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3: AbstractRulesImpl.java ExtendedBaseRules.java
Date Mon, 27 Jun 2011 00:27:06 GMT
Author: simonetripodi
Date: Mon Jun 27 00:27:06 2011
New Revision: 1139980

URL: http://svn.apache.org/viewvc?rev=1139980&view=rev
Log:
add() method can be final in the abstract implementation, used the registerRule() method instead

Modified:
    commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/AbstractRulesImpl.java
    commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java

Modified: commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/AbstractRulesImpl.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/AbstractRulesImpl.java?rev=1139980&r1=1139979&r2=1139980&view=diff
==============================================================================
--- commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/AbstractRulesImpl.java
(original)
+++ commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/AbstractRulesImpl.java
Mon Jun 27 00:27:06 2011
@@ -85,7 +85,7 @@ public abstract class AbstractRulesImpl
     /**
      * {@inheritDoc}
      */
-    public void add( String pattern, Rule rule )
+    public final void add( String pattern, Rule rule )
     {
         // set up rule
         if ( this.digester != null )

Modified: commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java
URL: http://svn.apache.org/viewvc/commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java?rev=1139980&r1=1139979&r2=1139980&view=diff
==============================================================================
--- commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java
(original)
+++ commons/proper/digester/trunk/src/main/java/org/apache/commons/digester3/ExtendedBaseRules.java
Mon Jun 27 00:27:06 2011
@@ -164,9 +164,8 @@ public class ExtendedBaseRules
      * {@inheritDoc}
      */
     @Override
-    public void add( String pattern, Rule rule )
+    protected void registerRule( String pattern, Rule rule )
     {
-        super.add( pattern, rule );
         counter++;
         order.put( rule, counter );
     }



Mime
View raw message