commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pste...@apache.org
Subject svn commit: r1136191 - /commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDataSource.java
Date Wed, 15 Jun 2011 20:57:15 GMT
Author: psteitz
Date: Wed Jun 15 20:57:15 2011
New Revision: 1136191

URL: http://svn.apache.org/viewvc?rev=1136191&view=rev
Log:
Dropped redundant factory setter calls (which now throw ISE in pool2).

Modified:
    commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDataSource.java

Modified: commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDataSource.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDataSource.java?rev=1136191&r1=1136190&r2=1136191&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDataSource.java
(original)
+++ commons/proper/dbcp/trunk/src/test/org/apache/commons/dbcp2/TestPoolingDataSource.java
Wed Jun 15 20:57:15 2011
@@ -62,7 +62,6 @@ public class TestPoolingDataSource exten
                 new DriverConnectionFactory(new TesterDriver(),
                         "jdbc:apache:commons:testdriver", props),
                 pool, null, "SELECT DUMMY FROM DUAL", true, true);
-        pool.setFactory(factory);
         ds = new PoolingDataSource(pool);
         ds.setAccessToUnderlyingConnectionAllowed(true);
     }
@@ -120,7 +119,6 @@ public class TestPoolingDataSource exten
             new NonDelegatingPoolableConnectionFactory(
                 new DriverConnectionFactory(new TesterDriver(),
                         "jdbc:apache:commons:testdriver", props), pool);
-        pool.setFactory(factory);
         ds = new PoolingDataSource(pool);
         checkPoolGuardConnectionWrapperEqualsReflexive();
     }



Mime
View raw message