commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@apache.org
Subject svn commit: r1135299 - /commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPool.java
Date Mon, 13 Jun 2011 21:42:30 GMT
Author: markt
Date: Mon Jun 13 21:42:30 2011
New Revision: 1135299

URL: http://svn.apache.org/viewvc?rev=1135299&view=rev
Log:
This just works since LinkedBlockingDeque uses FIFO queues for waiting threads

Modified:
    commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPool.java

Modified: commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPool.java?rev=1135299&r1=1135298&r2=1135299&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPool.java
(original)
+++ commons/proper/pool/trunk/src/test/org/apache/commons/pool2/impl/TestGenericObjectPool.java
Mon Jun 13 21:42:30 2011
@@ -1489,16 +1489,10 @@ public class TestGenericObjectPool exten
     @Test
     public void testBorrowObjectFairness() {
         
-        // TODO - Restore fairness in GOP
-
-        /*
         // Config
         int numThreads = 30;
         int maxTotal = 10;
 
-        SimpleFactory factory = new SimpleFactory();
-        factory.setMaxTotal(maxTotal);
-        pool.setFactory(factory);
         pool.setMaxTotal(maxTotal);
         pool.setWhenExhaustedAction(WhenExhaustedAction.BLOCK);
         pool.setTimeBetweenEvictionRunsMillis(-1);
@@ -1530,7 +1524,6 @@ public class TestGenericObjectPool exten
                 fail("Thread "+i+" failed: "+threads[i]._error.toString());
             }
         }
-        */
     }
     
     /**



Mime
View raw message