Return-Path: X-Original-To: apmail-commons-commits-archive@minotaur.apache.org Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2F5BC404A for ; Tue, 31 May 2011 16:16:42 +0000 (UTC) Received: (qmail 31501 invoked by uid 500); 31 May 2011 16:16:41 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 31432 invoked by uid 500); 31 May 2011 16:16:41 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 31425 invoked by uid 99); 31 May 2011 16:16:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2011 16:16:41 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2011 16:16:39 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 8C5312388A60; Tue, 31 May 2011 16:16:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1129774 - /commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java Date: Tue, 31 May 2011 16:16:18 -0000 To: commits@commons.apache.org From: simonetripodi@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110531161618.8C5312388A60@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: simonetripodi Date: Tue May 31 16:16:18 2011 New Revision: 1129774 URL: http://svn.apache.org/viewvc?rev=1129774&view=rev Log: back to old iterators, the `ruleLoader == null` condition fixes the broken tests Modified: commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java Modified: commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java URL: http://svn.apache.org/viewvc/commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java?rev=1129774&r1=1129773&r2=1129774&view=diff ============================================================================== --- commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java (original) +++ commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/plugins/PluginManager.java Tue May 31 16:16:18 2011 @@ -20,6 +20,7 @@ package org.apache.commons.digester3.plu */ import java.util.HashMap; +import java.util.Iterator; import java.util.List; import java.util.Properties; @@ -172,8 +173,10 @@ public class PluginManager List ruleFinders = pluginContext.getRuleFinders(); RuleLoader ruleLoader = null; - for ( RuleFinder finder : ruleFinders ) + for ( Iterator i = ruleFinders.iterator(); i.hasNext() && ruleLoader == null; ) { + + RuleFinder finder = i.next(); if ( debug ) { log.debug( "checking finder of type " + finder.getClass().getName() );