commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1087391 - /commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTP.java
Date Thu, 31 Mar 2011 17:58:26 GMT
Author: sebb
Date: Thu Mar 31 17:58:26 2011
New Revision: 1087391

URL: http://svn.apache.org/viewvc?rev=1087391&view=rev
Log:
Simplify

Modified:
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTP.java

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTP.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTP.java?rev=1087391&r1=1087390&r2=1087391&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTP.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTP.java Thu Mar 31
17:58:26 2011
@@ -93,7 +93,7 @@ public class SMTP extends SocketClient
     private static final String __DEFAULT_ENCODING = "ISO-8859-1";
 
     /** The encoding to use (user-settable) */
-    private String encoding = __DEFAULT_ENCODING;
+    private final String encoding;
 
     /**
      * A ProtocolCommandSupport object used to manage the registering of
@@ -115,11 +115,7 @@ public class SMTP extends SocketClient
      ***/
     public SMTP()
     {
-        setDefaultPort(DEFAULT_PORT);
-        _replyLines = new ArrayList<String>();
-        _newReplyString = false;
-        _replyString = null;
-        _commandSupport_ = new ProtocolCommandSupport(this);
+        this(__DEFAULT_ENCODING);
     }
 
     /**
@@ -128,7 +124,11 @@ public class SMTP extends SocketClient
      * @since 2.0
      */
     public SMTP(String encoding) {
-        this();
+        setDefaultPort(DEFAULT_PORT);
+        _replyLines = new ArrayList<String>();
+        _newReplyString = false;
+        _replyString = null;
+        _commandSupport_ = new ProtocolCommandSupport(this);
         this.encoding = encoding;
     }
 



Mime
View raw message