commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1086056 - in /commons/proper/net/trunk/src: changes/changes.xml main/java/org/apache/commons/net/imap/IMAP.java
Date Sun, 27 Mar 2011 22:05:40 GMT
Author: sebb
Date: Sun Mar 27 22:05:40 2011
New Revision: 1086056

URL: http://svn.apache.org/viewvc?rev=1086056&view=rev
Log:
NET-393 Should the sendCommandWithID() methods be public?
Made methods private, and deleted currently unused ones.

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAP.java

Modified: commons/proper/net/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1086056&r1=1086055&r2=1086056&view=diff
==============================================================================
--- commons/proper/net/trunk/src/changes/changes.xml (original)
+++ commons/proper/net/trunk/src/changes/changes.xml Sun Mar 27 22:05:40 2011
@@ -57,6 +57,10 @@ The <action> type attribute can be add,u
 
     <body>
         <release version="3.0" date="TBA" description="TBA">
+            <action issue="NET-393" dev="sebb" type="update">
+            Should the sendCommandWithID() methods be public?
+            Made methods private, and deleted currently unused ones.
+            </action>
             <action issue="NET-394" dev="sebb" type="update">
             Are the sendUntaggedCommand() methods needed?
             Renamed the method as sendData(), as it's not a command.

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAP.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAP.java?rev=1086056&r1=1086055&r2=1086056&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAP.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/imap/IMAP.java Sun Mar 27
22:05:40 2011
@@ -222,7 +222,7 @@ public class IMAP extends SocketClient
      * @param args     The command arguments.
      * @return  The server reply code (either IMAPReply.OK, IMAPReply.NO or IMAPReply.BAD).
      */
-    public int sendCommandWithID(String commandID, String command, String args) throws IOException
+    private int sendCommandWithID(String commandID, String command, String args) throws IOException
     {
         String message;
 
@@ -252,47 +252,6 @@ public class IMAP extends SocketClient
     }
 
     /**
-     * Sends a command with no arguments to the server and returns the
-     * reply code.
-     * <p>
-     * @param commandID The ID (tag) of the command.
-     * @param command  The IMAP command to send.
-     * @return  The server reply code (see IMAPReply).
-     */
-    public int sendCommandWithID(String commandID, String command) throws IOException
-    {
-        return sendCommandWithID(commandID, command, null);
-    }
-
-    /**
-     * Sends a command an arguments to the server and returns the reply code.
-     * <p>
-     * @param commandID The ID (tag) of the command.
-     * @param command  The IMAP command to send
-     *                  (one of the IMAPCommand constants).
-     * @param args     The command arguments.
-     * @return  The server reply code (see IMAPReply).
-     */
-    public int sendCommandWithID(String commandID, IMAPCommand command, String args) throws
IOException
-    {
-        return sendCommandWithID(commandID, IMAPCommand.getCommand(command), args);
-    }
-
-    /**
-     * Sends a command with no arguments to the server and returns the
-     * reply code.
-     * <p>
-     * @param commandID The ID (tag) of the command.
-     * @param command  The IMAP command to send
-     *                  (one of the IMAPCommand constants).
-     * @return  The server reply code (see IMAPReply).
-    **/
-    public int sendCommandWithID(String commandID, IMAPCommand command) throws IOException
-    {
-        return sendCommandWithID(commandID, command, null);
-    }
-
-    /**
      * Sends a command an arguments to the server and returns the reply code.
      * <p>
      * @param command  The IMAP command to send.



Mime
View raw message