commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1084395 - in /commons/proper/net/trunk/src: changes/changes.xml main/java/org/apache/commons/net/nntp/Article.java
Date Tue, 22 Mar 2011 22:44:00 GMT
Author: sebb
Date: Tue Mar 22 22:43:59 2011
New Revision: 1084395

URL: http://svn.apache.org/viewvc?rev=1084395&view=rev
Log:
NET-369 Article.addHeaderField() is currently write-only - there is no way to retrieve the
headers - is it needed?
Method was removed, along with the field.

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Article.java

Modified: commons/proper/net/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1084395&r1=1084394&r2=1084395&view=diff
==============================================================================
--- commons/proper/net/trunk/src/changes/changes.xml (original)
+++ commons/proper/net/trunk/src/changes/changes.xml Tue Mar 22 22:43:59 2011
@@ -57,6 +57,10 @@ The <action> type attribute can be add,u
 
     <body>
         <release version="3.0" date="TBA" description="TBA">
+            <action issue="NET-369" dev="sebb" type="remove">
+            Article.addHeaderField() is currently write-only - there is no way to retrieve
the headers - is it needed?
+            Method was removed, along with the field.
+            </action>
             <action issue="NET-367" dev="sebb" type="fix">
             ntp.TimeStamp uses incorrect lazy initialisation of static fields simpleFormatter
and utcFormatter.
             </action>

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Article.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Article.java?rev=1084395&r1=1084394&r2=1084395&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Article.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Article.java Tue Mar
22 22:43:59 2011
@@ -31,30 +31,16 @@ public class Article implements Threadab
     private String articleId;
     private String simplifiedSubject;
     private String from;
-    private StringBuffer header;
     private ArrayList<String> references;
     private boolean isReply = false;
 
     public Article kid, next;
 
     public Article() {
-        header = new StringBuffer();
         articleNumber = -1; // isDummy
     }
 
     /**
-     * Adds an arbitrary header key and value to this message's header.
-     * @param name the header name
-     * @param val the header value
-     */
-    public void addHeaderField(String name, String val) {
-        header.append(name);
-        header.append(": ");
-        header.append(val);
-        header.append('\n');
-    }
-
-    /**
      * Adds a message-id to the list of messages that this message references (i.e. replies
to)
      * @param msgId
      */



Mime
View raw message