commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simonetrip...@apache.org
Subject svn commit: r1076240 - in /commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3: Digester.java internal/DigesterImpl.java
Date Wed, 02 Mar 2011 15:04:38 GMT
Author: simonetripodi
Date: Wed Mar  2 15:04:38 2011
New Revision: 1076240

URL: http://svn.apache.org/viewvc?rev=1076240&view=rev
Log:
used varargs ... for Digester.pushParams() stack method, thanks Jörg Schaible!!!
added missing warning in the javadoc section of Digester.parse(File) method

Modified:
    commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/Digester.java
    commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/internal/DigesterImpl.java

Modified: commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/Digester.java
URL: http://svn.apache.org/viewvc/commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/Digester.java?rev=1076240&r1=1076239&r2=1076240&view=diff
==============================================================================
--- commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/Digester.java
(original)
+++ commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/Digester.java
Wed Mar  2 15:04:38 2011
@@ -76,6 +76,9 @@ public interface Digester extends Conten
      * Parse the content of the specified file using this Digester.  Returns
      * the root element from the object stack (if any).
      *
+     * <b>WARNING</b>: this method is subject to {@link ClassCastException} if
+     * the returned object is not assignable to the generic type.
+     *
      * @param file File containing the XML data to be parsed
      *
      * @exception IOException if an input/output error occurs
@@ -354,9 +357,9 @@ public interface Digester extends Conten
      * <p>The parameters stack is used to store <code>CallMethodRule</code>
parameters. 
      * See {@link #params}.</p>
      *
-     * @param object The new object
+     * @param params The new object
      */
-    void pushParams(Object[] object);
+    void pushParams(Object...params);
 
     /**
      * <p>Pop the top object off of the parameters stack, and return it.  If there
are

Modified: commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/internal/DigesterImpl.java
URL: http://svn.apache.org/viewvc/commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/internal/DigesterImpl.java?rev=1076240&r1=1076239&r2=1076240&view=diff
==============================================================================
--- commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/internal/DigesterImpl.java
(original)
+++ commons/sandbox/digester3/trunk/src/main/java/org/apache/commons/digester3/internal/DigesterImpl.java
Wed Mar  2 15:04:38 2011
@@ -423,11 +423,11 @@ public final class DigesterImpl implemen
     /**
      * {@inheritDoc}
      */
-    public void pushParams(Object[] object) {
+    public void pushParams(Object...params) {
         if (this.log.isTraceEnabled()) {
             this.log.trace("Pushing params");
         }
-        this.params.push(object);
+        this.params.push(params);
     }
 
     /**



Mime
View raw message