commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1074982 - in /commons/proper/net/trunk/src: changes/changes.xml main/java/org/apache/commons/net/nntp/Threader.java
Date Sun, 27 Feb 2011 03:28:50 GMT
Author: sebb
Date: Sun Feb 27 03:28:50 2011
New Revision: 1074982

URL: http://svn.apache.org/viewvc?rev=1074982&view=rev
Log:
NET-289 StackOverflowError in Threader

Modified:
    commons/proper/net/trunk/src/changes/changes.xml
    commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java

Modified: commons/proper/net/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1074982&r1=1074981&r2=1074982&view=diff
==============================================================================
--- commons/proper/net/trunk/src/changes/changes.xml (original)
+++ commons/proper/net/trunk/src/changes/changes.xml Sun Feb 27 03:28:50 2011
@@ -54,6 +54,9 @@ The <action> type attribute can be add,u
 
     <body>
         <release version="3.0" date="TBA" description="TBA">
+            <action issue="NET-289" dev="sebb" type="fix" due-to="Luc Claes">
+            StackOverflowError in Threader.
+            </action>
             <action issue="NET-317" dev="sebb" type="fix">
             POP3MessageInfo fields should be final.
             </action>

Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java?rev=1074982&r1=1074981&r2=1074982&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/nntp/Threader.java Sun Feb
27 03:28:50 2011
@@ -141,7 +141,7 @@ public class Threader {
                 if ((parentRef != null)
                     && (ref.parent == null)
                     && (parentRef != ref)
-                    && !(parentRef.findChild(ref))) {
+                    && !(ref.findChild(parentRef))) {
                     // Link ref into the parent's child list
                     ref.parent = parentRef;
                     ref.next = parentRef.child;



Mime
View raw message