Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 81217 invoked from network); 25 Jan 2011 16:57:17 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 25 Jan 2011 16:57:17 -0000 Received: (qmail 13922 invoked by uid 500); 25 Jan 2011 16:57:16 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 13851 invoked by uid 500); 25 Jan 2011 16:57:16 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 13844 invoked by uid 99); 25 Jan 2011 16:57:16 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jan 2011 16:57:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Jan 2011 16:57:15 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 5DDE3238896F; Tue, 25 Jan 2011 16:56:55 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1063350 - /commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/ColognePhonetic.java Date: Tue, 25 Jan 2011 16:56:55 -0000 To: commits@commons.apache.org From: ggregory@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110125165655.5DDE3238896F@eris.apache.org> Author: ggregory Date: Tue Jan 25 16:56:55 2011 New Revision: 1063350 URL: http://svn.apache.org/viewvc?rev=1063350&view=rev Log: CologneBuffer does not need to implement CharSequence which then does not need to implement charAt and subSequence, which are themselves not used. Modified: commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/ColognePhonetic.java Modified: commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/ColognePhonetic.java URL: http://svn.apache.org/viewvc/commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/ColognePhonetic.java?rev=1063350&r1=1063349&r2=1063350&view=diff ============================================================================== --- commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/ColognePhonetic.java (original) +++ commons/proper/codec/trunk/src/java/org/apache/commons/codec/language/ColognePhonetic.java Tue Jan 25 16:56:55 2011 @@ -180,7 +180,7 @@ import org.apache.commons.codec.StringEn */ public class ColognePhonetic implements StringEncoder { - private abstract class CologneBuffer implements CharSequence { + private abstract class CologneBuffer { protected final char[] data; protected int length = 0; @@ -191,15 +191,8 @@ public class ColognePhonetic implements } public CologneBuffer(int buffSize) { - data = new char[buffSize]; - } - - public char charAt(int index) { - if (index < length) { - return data[index]; - } else { - throw new IndexOutOfBoundsException(); - } + this.data = new char[buffSize]; + this.length = 0; } protected abstract char[] copyData(int start, final int length); @@ -210,12 +203,6 @@ public class ColognePhonetic implements return length; } - public CharSequence subSequence(int start, int end) { - final int length = end - start; - char[] newData = copyData(start, length); - return createCologneBuffer(newData); - } - public String toString() { return new String(copyData(0, length)); }