From commits-return-15256-apmail-commons-commits-archive=commons.apache.org@commons.apache.org Wed Jan 12 12:36:12 2011 Return-Path: Delivered-To: apmail-commons-commits-archive@minotaur.apache.org Received: (qmail 85283 invoked from network); 12 Jan 2011 12:36:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Jan 2011 12:36:11 -0000 Received: (qmail 9705 invoked by uid 500); 12 Jan 2011 12:36:11 -0000 Delivered-To: apmail-commons-commits-archive@commons.apache.org Received: (qmail 9344 invoked by uid 500); 12 Jan 2011 12:36:07 -0000 Mailing-List: contact commits-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@commons.apache.org Delivered-To: mailing list commits@commons.apache.org Received: (qmail 9324 invoked by uid 99); 12 Jan 2011 12:36:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jan 2011 12:36:06 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jan 2011 12:36:05 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 2430823889D5; Wed, 12 Jan 2011 12:35:39 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1058110 - in /commons/proper/math/trunk/src: main/java/org/apache/commons/math/util/MathUtils.java test/java/org/apache/commons/math/util/MathUtilsTest.java Date: Wed, 12 Jan 2011 12:35:39 -0000 To: commits@commons.apache.org From: erans@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20110112123539.2430823889D5@eris.apache.org> Author: erans Date: Wed Jan 12 12:35:38 2011 New Revision: 1058110 URL: http://svn.apache.org/viewvc?rev=1058110&view=rev Log: MATH-470 "Un-deprecate" unit test. Javadoc clean up. Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/util/MathUtils.java commons/proper/math/trunk/src/test/java/org/apache/commons/math/util/MathUtilsTest.java Modified: commons/proper/math/trunk/src/main/java/org/apache/commons/math/util/MathUtils.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/main/java/org/apache/commons/math/util/MathUtils.java?rev=1058110&r1=1058109&r2=1058110&view=diff ============================================================================== --- commons/proper/math/trunk/src/main/java/org/apache/commons/math/util/MathUtils.java (original) +++ commons/proper/math/trunk/src/main/java/org/apache/commons/math/util/MathUtils.java Wed Jan 12 12:35:38 2011 @@ -519,14 +519,14 @@ public final class MathUtils { } /** - * Returns true iff both arguments are null or have same dimensions and all - * their elements are equal as defined by + * Returns {@code true} iff both arguments are {@code null} or have same + * dimensions and all their elements are equal as defined by * {@link #equals(double,double) this method}. * - * @param x first array - * @param y second array - * @return true if the values are both null or have same dimension - * and equal elements. + * @param x First array. + * @param y Second array. + * @return {@code true} if the values are both {@code null} or have same + * dimension and equal elements. */ public static boolean equals(double[] x, double[] y) { if ((x == null) || (y == null)) { @@ -544,14 +544,14 @@ public final class MathUtils { } /** - * Returns true iff both arguments are null or have same dimensions and all - * their elements are equal as defined by + * Returns {@code true} iff both arguments are {@code null} or have same + * dimensions and all their elements are equal as defined by * {@link #equalsIncludingNaN(double,double) this method}. * - * @param x first array - * @param y second array - * @return true if the values are both null or have same dimension and - * equal elements + * @param x First array. + * @param y Second array. + * @return {@code true} if the values are both {@code null} or have same + * dimension and equal elements. */ public static boolean equalsIncludingNaN(double[] x, double[] y) { if ((x == null) || (y == null)) { Modified: commons/proper/math/trunk/src/test/java/org/apache/commons/math/util/MathUtilsTest.java URL: http://svn.apache.org/viewvc/commons/proper/math/trunk/src/test/java/org/apache/commons/math/util/MathUtilsTest.java?rev=1058110&r1=1058109&r2=1058110&view=diff ============================================================================== --- commons/proper/math/trunk/src/test/java/org/apache/commons/math/util/MathUtilsTest.java (original) +++ commons/proper/math/trunk/src/test/java/org/apache/commons/math/util/MathUtilsTest.java Wed Jan 12 12:35:38 2011 @@ -439,11 +439,6 @@ public final class MathUtilsTest extends assertFalse(MathUtils.equalsIncludingNaN(Double.NEGATIVE_INFINITY, Double.POSITIVE_INFINITY, 100000)); } - /** - * @deprecated To be removed in release 3.0 (replaced by {@link - * #testArrayEqualsIncludingNaN()}. - */ - @Deprecated public void testArrayEquals() { assertFalse(MathUtils.equals(new double[] { 1d }, null)); assertFalse(MathUtils.equals(null, new double[] { 1d }));