commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simonetrip...@apache.org
Subject svn commit: r1051668 - /commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java
Date Tue, 21 Dec 2010 21:47:52 GMT
Author: simonetripodi
Date: Tue Dec 21 21:47:52 2010
New Revision: 1051668

URL: http://svn.apache.org/viewvc?rev=1051668&view=rev
Log:
getFactory() method doesn't need to be synchronized since _factory is private final

Modified:
    commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java?rev=1051668&r1=1051667&r2=1051668&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java
(original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool2/impl/StackKeyedObjectPool.java
Tue Dec 21 21:47:52 2010
@@ -379,8 +379,7 @@ public class StackKeyedObjectPool<K,V> e
      * @return the {@link KeyedPoolableObjectFactory} used by this pool to manage object
instances.
      * @since 1.5.5
      */
-    // TODO does this still need to be synchronised?
-    public synchronized KeyedPoolableObjectFactory<K,V> getFactory() {
+    public KeyedPoolableObjectFactory<K,V> getFactory() {
         return _factory;
     }
 



Mime
View raw message