commons-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1034827 - /commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java
Date Sat, 13 Nov 2010 17:56:26 GMT
Author: sebb
Date: Sat Nov 13 17:56:26 2010
New Revision: 1034827

URL: http://svn.apache.org/viewvc?rev=1034827&view=rev
Log:
Remove unthrown Exceptions
assertEquals(true|false => asserTrue|False

Modified:
    commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java

Modified: commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java
URL: http://svn.apache.org/viewvc/commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java?rev=1034827&r1=1034826&r2=1034827&view=diff
==============================================================================
--- commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java
(original)
+++ commons/proper/lang/trunk/src/test/java/org/apache/commons/lang3/concurrent/ConcurrentUtilsTest.java
Sat Nov 13 17:56:26 2010
@@ -17,8 +17,10 @@
 package org.apache.commons.lang3.concurrent;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertSame;
+import static org.junit.Assert.assertTrue;
 import static org.junit.Assert.fail;
 
 import java.util.concurrent.ExecutionException;
@@ -251,7 +253,7 @@ public class ConcurrentUtilsTest {
      * Tests handleCauseUnchecked() if the cause is an error.
      */
     @Test
-    public void testHandleCauseUncheckedError() throws ConcurrentException {
+    public void testHandleCauseUncheckedError() {
         Error err = new AssertionError("Test");
         try {
             ConcurrentUtils.handleCauseUnchecked(new ExecutionException(err));
@@ -265,8 +267,7 @@ public class ConcurrentUtilsTest {
      * Tests handleCauseUnchecked() if the cause is an unchecked exception.
      */
     @Test
-    public void testHandleCauseUncheckedUncheckedException()
-            throws ConcurrentException {
+    public void testHandleCauseUncheckedUncheckedException() {
         RuntimeException rex = new RuntimeException("Test");
         try {
             ConcurrentUtils.handleCauseUnchecked(new ExecutionException(rex));
@@ -296,7 +297,7 @@ public class ConcurrentUtilsTest {
      * exception is thrown.
      */
     @Test
-    public void testHandleCauseUncheckedNull() throws ConcurrentException {
+    public void testHandleCauseUncheckedNull() {
         ConcurrentUtils.handleCauseUnchecked(null);
         ConcurrentUtils.handleCauseUnchecked(new ExecutionException("Test",
                 null));
@@ -379,13 +380,13 @@ public class ConcurrentUtilsTest {
     public void testConstantFuture_Integer() throws Exception {
         Integer value = new Integer(5);
         Future<Integer> test = ConcurrentUtils.constantFuture(value);
-        assertEquals(true, test.isDone());
+        assertTrue(test.isDone());
         assertSame(value, test.get());
         assertSame(value, test.get(1000, TimeUnit.SECONDS));
         assertSame(value, test.get(1000, null));
-        assertEquals(false, test.isCancelled());
-        assertEquals(false, test.cancel(true));
-        assertEquals(false, test.cancel(false));
+        assertFalse(test.isCancelled());
+        assertFalse(test.cancel(true));
+        assertFalse(test.cancel(false));
     }
 
     /**
@@ -395,13 +396,13 @@ public class ConcurrentUtilsTest {
     public void testConstantFuture_null() throws Exception {
         Integer value = null;
         Future<Integer> test = ConcurrentUtils.constantFuture(value);
-        assertEquals(true, test.isDone());
+        assertTrue(test.isDone());
         assertSame(value, test.get());
         assertSame(value, test.get(1000, TimeUnit.SECONDS));
         assertSame(value, test.get(1000, null));
-        assertEquals(false, test.isCancelled());
-        assertEquals(false, test.cancel(true));
-        assertEquals(false, test.cancel(false));
+        assertFalse(test.isCancelled());
+        assertFalse(test.cancel(true));
+        assertFalse(test.cancel(false));
     }
 
 }



Mime
View raw message